From: Johannes Berg <johannes@sipsolutions.net>
To: Jason Huang <Jason.Huang2@infineon.com>, linux-wireless@vger.kernel.org
Cc: arend.vanspriel@broadcom.com, hsin-hung.li@cypress.com,
linux-kernel@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
wlan-kernel-dev-list@infineon.com,
jeff.johnson@oss.qualcomm.com,
Carella Chen <carella.chen@infineon.com>
Subject: Re: [PATCH v5 1/5] wifi: nl80211: add roam offload extended feature
Date: Fri, 04 Sep 2026 10:38:33 +0200 [thread overview]
Message-ID: <94f92252ee873146420ed2a53ac1b86dead1345b.camel@sipsolutions.net> (raw)
In-Reply-To: <20260821-upstream-wireless-next-main-jason-11r-support-v1-v5-1-eeab4fda0f31@infineon.com>
On Fri, 2026-08-21 at 15:56 +0800, Jason Huang wrote:
> @@ -18442,8 +18443,10 @@ static int nl80211_set_pmk(struct sk_buff *skb, struct genl_info *info)
> wdev->iftype != NL80211_IFTYPE_P2P_CLIENT)
> return -EOPNOTSUPP;
>
> - if (!wiphy_ext_feature_isset(&rdev->wiphy,
> - NL80211_EXT_FEATURE_4WAY_HANDSHAKE_STA_1X))
> + if (!wiphy_ext_feature_isset(wiphy,
> + NL80211_EXT_FEATURE_4WAY_HANDSHAKE_STA_1X) &&
> + !wiphy_ext_feature_isset(wiphy,
> + NL80211_EXT_FEATURE_ROAM_OFFLOAD))
> return -EOPNOTSUPP;
Shouldn't you have a similar change in _del_pmk()?
johannes
next prev parent reply other threads:[~2026-09-04 8:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 7:56 [PATCH v5 0/5] brcmfmac: add FT/OKC roaming offload support Jason Huang
2026-08-21 7:56 ` [PATCH v5 1/5] wifi: nl80211: add roam offload extended feature Jason Huang
2026-08-22 18:36 ` Arend van Spriel
2026-08-30 9:14 ` Arend van Spriel
2026-09-01 7:14 ` HungTsung Huang
2026-09-01 8:56 ` Arend van Spriel
2026-09-04 8:38 ` Johannes Berg [this message]
2026-08-21 7:56 ` [PATCH v5 2/5] wifi: brcmfmac: detect firmware FBT and OKC support Jason Huang
2026-08-21 7:56 ` [PATCH v5 3/5] wifi: brcmfmac: add PMK programming for firmware roaming offload Jason Huang
2026-08-21 7:56 ` [PATCH v5 4/5] wifi: brcmfmac: report port authorization after offloaded roaming Jason Huang
2026-08-22 18:24 ` [PATCH v5 0/5] brcmfmac: add FT/OKC roaming offload support Arend van Spriel
2026-08-22 18:26 ` Arend van Spriel
2026-08-24 3:08 ` HungTsung Huang
2026-08-24 2:27 ` [PATCH v5 5/5] wifi: brcmfmac: advertise firmware roam " Jason Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94f92252ee873146420ed2a53ac1b86dead1345b.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Jason.Huang2@infineon.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=carella.chen@infineon.com \
--cc=hsin-hung.li@cypress.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wlan-kernel-dev-list@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox