From: Ping-Ke Shih <pkshih@realtek.com>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"luka.gejak@linux.dev" <luka.gejak@linux.dev>,
"fiona.klute@gmx.de" <fiona.klute@gmx.de>,
"kvalo@kernel.org" <kvalo@kernel.org>
Subject: RE: [PATCH] wifi: rtw88: 8703b: avoid converting RX SNR twice
Date: Mon, 12 Oct 2026 05:56:36 +0000 [thread overview]
Message-ID: <95d9c1abf62d42269f1f3f90a2db2c2e@realtek.com> (raw)
In-Reply-To: <20261010183629.39748-1-dennylin0707@gmail.com>
Hungyu Lin <dennylin0707@gmail.com> wrote:
> query_phy_status_ofdm() divides the SNR report by two when filling
> pkt_stat->rx_snr, then shifts it again when updating dm_info->rx_snr.
> This halves the SNR used for diagnostics and average statistics.
>
> Store the raw report in pkt_stat->rx_snr and convert it only when
> updating dm_info->rx_snr, as the other chip drivers do.
>
> Fixes: 61a486bcd782 ("wifi: rtw88: Add rtw8703b.c")
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
prev parent reply other threads:[~2026-10-12 5:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 18:36 [PATCH] wifi: rtw88: 8703b: avoid converting RX SNR twice Hungyu Lin
2026-10-10 18:48 ` Luka Gejak
2026-10-10 18:49 ` Luka Gejak
2026-10-10 18:50 ` Luka Gejak
2026-10-12 5:56 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95d9c1abf62d42269f1f3f90a2db2c2e@realtek.com \
--to=pkshih@realtek.com \
--cc=dennylin0707@gmail.com \
--cc=fiona.klute@gmx.de \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox