Re: [PATCH 03/10] carl9170: mac80211: document spatial multiplexing power save handler

[Christian Lamparter <chunkeey@gmail.com>]

On 3/12/26 11:37 AM, Masi Osmani wrote:
> Replace the bare TODO comment in the SMPS configuration handler
> with documentation explaining why the driver accepts but does not
> act on SMPS mode changes.
> 
> The AR9170 advertises SM_PS disabled (both chains always active)
> in its HT capabilities.  While mac80211 may still send SMPS
> configuration requests, implementing static or dynamic SMPS would
> require firmware support for per-chain enable/disable that the
> AR9170 firmware (v1.9.9) does not provide.
> 
> Signed-off-by: Masi Osmani <mas-i@hotmail.de>

Sure, this patch is reasonable.

Acked-by: Christian Lamparter <chunkeey@gmail.com>

> ---
>   drivers/net/wireless/ath/carl9170/main.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/carl9170/main.c b/drivers/net/wireless/ath/carl9170/main.c
> index 6324b38..d75688c 100644
> --- a/drivers/net/wireless/ath/carl9170/main.c
> +++ b/drivers/net/wireless/ath/carl9170/main.c
> @@ -910,7 +910,13 @@ static int carl9170_op_config(struct ieee80211_hw *hw, int radio_idx, u32 change
>   	}
>   
>   	if (changed & IEEE80211_CONF_CHANGE_SMPS) {
> -		/* TODO */
> +		/*
> +		 * We advertise SM_PS disabled (all chains active).
> +		 * mac80211 may still request mode changes, which we
> +		 * accept but only support OFF (both chains active).
> +		 * Static/dynamic SMPS would require firmware support
> +		 * for chain control that the AR9170 does not provide.
> +		 */
>   		err = 0;
>   	}
>