From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.kundenserver.de ([212.227.126.133]:51660 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbcCXNTT (ORCPT ); Thu, 24 Mar 2016 09:19:19 -0400 From: Arnd Bergmann To: Kalle Valo Cc: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Hauke Mehrtens , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [1/2] bcma: fix building without OF_IRQ Date: Thu, 24 Mar 2016 14:19:08 +0100 Message-ID: <9767564.jLc8Ig1W5l@wuerfel> (sfid-20160324_141923_375725_78FD9636) In-Reply-To: <20160323155243.D1AB4615C6@smtp.codeaurora.org> References: <20160323155243.D1AB4615C6@smtp.codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wednesday 23 March 2016 15:52:43 Kalle Valo wrote: > > The bcma driver core can be built with or without DT support, but > > it fails to build when CONFIG_OF=y and CONFIG_OF_IRQ=n, which > > can happen on platforms that do not support IRQ domains. > > > > ERROR: "irq_create_of_mapping" [drivers/bcma/bcma.ko] undefined! > > ERROR: "of_irq_parse_raw" [drivers/bcma/bcma.ko] undefined! > > ERROR: "of_irq_parse_one" [drivers/bcma/bcma.ko] undefined! > > > > This adds another compile-time check for OF_IRQ, but also > > gets rid of now unneeded #ifdef checks: Using the simpler > > IS_ENABLED() check for OF_IRQ also covers the case of not > > having CONFIG_OF enabled. The check for CONFIG_OF_ADDRESS > > was added to allow building on architectures without > > OF_ADDRESS, but that has been addressed already in > > b1d06b60e90c ("of: Provide static inline function for > > of_translate_address if needed"). > > > > Signed-off-by: Arnd Bergmann > > Thanks, applied to wireless-drivers.git. > Thanks! I see you have applied patch 1/2 but not patch 2/2. As mentioned in the comment for patch 2, it should be tested better, but I want to make sure that someone still has it on their radar. Arnd