From: Johannes Berg <johannes@sipsolutions.net>
To: WangYuli <wangyuli@uniontech.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
zhanjun@uniontech.com, niecheng1@uniontech.com,
guanwentao@uniontech.com
Subject: Re: [PATCH] wifi: mac80211: warn on insufficient antennas for injected HT frames
Date: Mon, 14 Jul 2025 11:47:09 +0200 [thread overview]
Message-ID: <9a178703de98e87d9c046975de1b078086b7cf9f.camel@sipsolutions.net> (raw)
In-Reply-To: <53AD760311F904D0+20250714094456.259784-1-wangyuli@uniontech.com> (sfid-20250714_114552_432528_2BC595AD)
On Mon, 2025-07-14 at 17:44 +0800, WangYuli wrote:
> When injecting frames via radiotap, an HT MCS rate can be specified.
> The number of chains for that MCS implies a minimum number of
> antennas that must be enabled in the antenna bitmap. Previously,
> if the antenna bitmap specified fewer antennas than required by the
> MCS, the bitmap was silently cleared. This makes it hard to debug
> issues with injected frames.
>
> Add a WARN_ONCE() to log a descriptive error when this happens, make
> it clear that the antenna configuration was insufficient and has
> been reset.
>
No. We shouldn't WARN on userspace misbehaviour.
johannes
prev parent reply other threads:[~2025-07-14 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 9:44 [PATCH] wifi: mac80211: warn on insufficient antennas for injected HT frames WangYuli
2025-07-14 9:47 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a178703de98e87d9c046975de1b078086b7cf9f.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=guanwentao@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=niecheng1@uniontech.com \
--cc=wangyuli@uniontech.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).