From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bw0-f174.google.com ([209.85.218.174]:48945 "EHLO mail-bw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbZENJCx (ORCPT ); Thu, 14 May 2009 05:02:53 -0400 Received: by bwz22 with SMTP id 22so1145146bwz.37 for ; Thu, 14 May 2009 02:02:53 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <43e72e890905131445s5583481bgb556a925247368db@mail.gmail.com> References: <1242030669.6930.10.camel@johannes.local> <9b2b86520905120709v4bd00e1eo4da26e6c5f75c4ba@mail.gmail.com> <43e72e890905131445s5583481bgb556a925247368db@mail.gmail.com> Date: Thu, 14 May 2009 10:02:53 +0100 Message-ID: <9b2b86520905140202y539f8b93m9669e2c8c7ffbdcd@mail.gmail.com> Subject: Re: [RFT v9] rfkill: rewrite From: Alan Jenkins To: "Luis R. Rodriguez" Cc: Johannes Berg , linux-wireless , Vivek Natarajan , Easwar Krishnan , Nataraj Sadasivam , Kathir Ganapthy , Ponmudi Ramachandran , Senthilkumar Balasubramanian Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 5/13/09, Luis R. Rodriguez wrote: > On Tue, May 12, 2009 at 7:09 AM, Alan Jenkins > wrote: >> On 5/11/09, Johannes Berg wrote: >>> This patch completely rewrites the rfkill core to address >>> the following deficiencies: >> >> Btw, git-apply nitpicks on your whitespace >> >> rfkill-rewrite.patch:4335: space before tab in indent. >> mutex_unlock(&rfkill_global_mutex); >> warning: 1 line adds whitespace errors. >> >> >> I tested on todays wireless-testing, aka v2.6.30-rc5-23297-gbf2c6a3. >> Somehow, it triggers an OOPS >> >> Function: req_reg_info_regd >> Process: modprobe >> >> Call trace: >> wiphy_apply_custom_regulatory >> ath5k_regd_init >> ath5k_reg_notifier >> ath5k_pci_probe >> ... >> >> Photo: >> >> >> The kernel then hangs later on in the boot process. It responds to >> SysRq, but does not echo normal keypresses. SysRq+P shows that the >> kernel is in the idle task. I left it for three minutes, but I didn't >> get any trace from the hung task detector or soft lockup detector. >> >> At first I thought it must be a problem with wireless-testing. >> However, it went away when I eventually tried un-applying the rfkill >> rewrite patch. > > I think my new 4 patches should address this and it'd be great to hear > your tests as you can reproduce easily. We are able to see something > like this but only after 3 hours of testing. Since it seems you might > be able to reproduce quickly it would help. Glad to be of service :-). I applied your four patches on top of my current tree (wireless-testing+rfkill rewrite), and it fixed the OOPS. As a sanity check, I tried un-applying patch 4/4 (cfg80211: fix race between core hint and driver's custom apply), since that looked like the fix I was interested in. Un-applying this fix caused the OOPS to reappear. Thanks! Alan