From: Manikanta Pubbisetty <mpubbise@codeaurora.org>
To: greearb@candelatech.com, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org, kvalo@codeaurora.org
Subject: Re: [PATCH] ath10k: Don't allow tx logic when state is not ON.
Date: Wed, 20 Jun 2018 23:07:23 +0530 [thread overview]
Message-ID: <9ba64928-a73b-0fe6-9586-65929ca87013@codeaurora.org> (raw)
In-Reply-To: <1529506583-20204-1-git-send-email-greearb@candelatech.com>
> From: Ben Greear <greearb@candelatech.com>
>
> This is against the 4.16 kernel, likely applies to later kernels
> as well. Firmware is beta ath10k-ct firmware for 9984 NIC. The
> patch is not firmware or chipset specific.
>
> When firmware crashes, packets can still be sent from the
> mac80211 stack, and that can cause crashes in the ath10k
> tx path.
Yes, this is what I had observed and explained in the RFC patch which I
have sent some time back. In my case the device never comes up and the
entire system crashes; I hope you have observed the same behavior.
> After adding this patch, I saw cases where the tx path was
> called in state ATH10K_STATE_RESTARTED.
>
> I have not tested the tx_64 path, but assume it has similar
> issues, so same patch was added to it.
This case should not be dealt in ath10k, rather we should make sure
packets does not reach the driver during hardware restart after the
firmware crash.
Can you please try the RFC patch and see if it fixes the issue? I am
working on the patch and probably send it out after doing some testing
and cleanup.
https://patchwork.kernel.org/patch/10411967/
Thanks,
Manikanta
next prev parent reply other threads:[~2018-06-20 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 14:56 [PATCH] ath10k: Don't allow tx logic when state is not ON greearb
2018-06-20 17:37 ` Manikanta Pubbisetty [this message]
2018-06-20 17:42 ` Ben Greear
2018-06-20 18:48 ` Rajkumar Manoharan
2018-06-20 18:51 ` Ben Greear
2018-06-20 21:16 ` Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ba64928-a73b-0fe6-9586-65929ca87013@codeaurora.org \
--to=mpubbise@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).