Re: [PATCH v3] wifi: ath10k: Add WLAN firmware image version info into smem

["Youghandhar Chintala (Temp)" <quic_youghand@quicinc.com>]

On 11/14/2022 6:29 PM, Kalle Valo wrote:
> Youghandhar Chintala <quic_youghand@quicinc.com> writes:
>
>> In a SoC based solution, it would be useful to know the versions of the
>> various binary firmware blobs the system is running on. On a QCOM based
>> SoC, this info can be obtained from socinfo debugfs infrastructure. For
>> this to work, respective subsystem drivers have to export the firmware
>> version information to an SMEM based version information table.
>>
>> Having firmware version information at one place will help quickly
>> figure out the firmware versions of various subsystems on the device
>> instead of going through builds/logs in an event of a system crash.
>>
>> Fill WLAN firmware version information in SMEM version table to be
>> printed as part of socinfo debugfs infrastructure on a Qualcomm based
>> SoC.
>>
>> This change is applicable only for WCN399X targets.
>>
>> Example:
>> cat /sys/kernel/debug/qcom_socinfo/cnss/name
>> QC_IMAGE_VERSION_STRING=WLAN.HL.3.2.2.c10-00754-QCAHLSWMTPL-1
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2.c10-00754-QCAHLSWMTPL-1
>>
>> Signed-off-by: Youghandhar Chintala <quic_youghand@quicinc.com>
>> ---
>> Changes from v2:
>>   - Removed blank line between trailers
>>   - Changed memcpy to strscpy
>>   - Removed version_string_size
>>   - Added new condition fw_build_id against max length
>>   - Added depends on QCOM_SMEM for ath10k_snoc
>> ---
>>   drivers/net/wireless/ath/ath10k/Kconfig |  1 +
>>   drivers/net/wireless/ath/ath10k/qmi.c   | 34 +++++++++++++++++++++++++
>>   2 files changed, 35 insertions(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/Kconfig b/drivers/net/wireless/ath/ath10k/Kconfig
>> index ca007b800f75..e6ea884cafc1 100644
>> --- a/drivers/net/wireless/ath/ath10k/Kconfig
>> +++ b/drivers/net/wireless/ath/ath10k/Kconfig
>> @@ -44,6 +44,7 @@ config ATH10K_SNOC
>>   	tristate "Qualcomm ath10k SNOC support"
>>   	depends on ATH10K
>>   	depends on ARCH_QCOM || COMPILE_TEST
>> +	depends on QCOM_SMEM
>>   	select QCOM_SCM
>>   	select QCOM_QMI_HELPERS
> Is there a reason why you used "depends on"? Other QCOM dependencies
> used "select", so I'm wondering if QCOM_SMEM should also use select?
Sure Kalle. As suggested will change it to select.
>
> Please also use ath10k list for ath10k patches, not ath11k.
Apologies, My bad.