From: Ben Greear <greearb@candelatech.com>
To: Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76: improve signal strength reporting
Date: Tue, 15 Feb 2022 10:22:28 -0800 [thread overview]
Message-ID: <9bb8329d-b2c7-139a-9f0d-a10bba3f4d8b@candelatech.com> (raw)
In-Reply-To: <20220215125808.72378-1-nbd@nbd.name>
On 2/15/22 4:58 AM, Felix Fietkau wrote:
> Instead of just taking the maximum per-chain signal strength values,
> add an approximation for the sum of the combined signal.
> This should more accurately reflect the real signal strength, especially
> if the per-chain signal strength values are close to each other
My concern with this patch is that many of the mtk radios do not provide enough
info to know how many RX chains are used when receiving a frame. I think we should not
be summing more chains than the number of spatial streams received.
That said, this code may still be a closer estimate than existing code, and some
radios, like 7921 appear to report enough info by default to properly determine
the NSS count on a per frame basis.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2022-02-15 18:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 12:58 [PATCH] mt76: improve signal strength reporting Felix Fietkau
2022-02-15 18:22 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bb8329d-b2c7-139a-9f0d-a10bba3f4d8b@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox