From: Ping-Ke Shih <pkshih@realtek.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"fiona.klute@gmx.de" <fiona.klute@gmx.de>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"megi@xff.cz" <megi@xff.cz>
Subject: Re: [PATCH v2 4/9] wifi: rtw88: Add rtw8703b.h
Date: Sat, 2 Mar 2024 00:35:11 +0000 [thread overview]
Message-ID: <9ddefe40defef4ea2e2db0e2c2950d5f816bd2c6.camel@realtek.com> (raw)
In-Reply-To: <5f505604-7bf1-471d-9e36-d9712daa9064@gmx.de>
On Fri, 2024-03-01 at 18:15 +0100, Fiona Klute wrote:
>
> Am 01.03.24 um 17:35 schrieb Fiona Klute:
> >
> > If I remove them whether the code compiles depends on the order of
> > #includes. If some other header that includes those two is included
> > before rtw8703b.h it works, otherwise it will break. I don't think
> > that's desirable, though other rtw88 headers already behave that way
> > (e.g. main.h must be included before the others). Also, clangd will
> > complain about undefined types (u8, s8), which is less important but
> > still annoying when working on the code. So I'd prefer to keep the
> > includes.
>
> Correction: Only the linux/types.h is needed for that, I can definitely
> remove the linux/compiler_attributes.h one.
>
Please check mail that explains what I meant.
next prev parent reply other threads:[~2024-03-02 0:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 23:54 [PATCH v2 0/9] rtw88: Add support for RTL8723CS/RTL8703B Fiona Klute
2024-02-27 23:54 ` [PATCH v2 1/9] wifi: rtw88: Shared module for rtw8723x devices Fiona Klute
2024-02-27 23:54 ` [PATCH v2 2/9] wifi: rtw88: Debug output for rtw8723x EFUSE Fiona Klute
2024-02-27 23:54 ` [PATCH v2 3/9] wifi: rtw88: Add definitions for 8703b chip Fiona Klute
2024-02-27 23:54 ` [PATCH v2 4/9] wifi: rtw88: Add rtw8703b.h Fiona Klute
2024-03-01 2:09 ` Ping-Ke Shih
2024-03-01 16:35 ` Fiona Klute
2024-03-01 17:15 ` Fiona Klute
2024-03-02 0:35 ` Ping-Ke Shih [this message]
2024-03-02 0:33 ` Ping-Ke Shih
2024-03-02 0:57 ` Fiona Klute
2024-02-27 23:54 ` [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c Fiona Klute
2024-03-01 2:33 ` Ping-Ke Shih
2024-03-01 4:36 ` Ping-Ke Shih
2024-03-01 16:54 ` Fiona Klute
2024-02-27 23:55 ` [PATCH v2 6/9] wifi: rtw88: Add rtw8703b_tables.h Fiona Klute
2024-02-27 23:55 ` [PATCH v2 7/9] wifi: rtw88: Add rtw8703b_tables.c Fiona Klute
2024-03-01 2:36 ` Ping-Ke Shih
2024-03-01 16:46 ` Fiona Klute
2024-03-02 0:28 ` Ping-Ke Shih
2024-02-27 23:55 ` [PATCH v2 8/9] wifi: rtw88: Reset 8703b firmware before download Fiona Klute
2024-02-27 23:55 ` [PATCH v2 9/9] wifi: rtw88: SDIO device driver for RTL8723CS Fiona Klute
2024-03-01 2:39 ` Ping-Ke Shih
2024-02-29 6:40 ` [PATCH v2 0/9] rtw88: Add support for RTL8723CS/RTL8703B Ping-Ke Shih
2024-03-01 0:45 ` Fiona Klute
2024-03-01 0:57 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ddefe40defef4ea2e2db0e2c2950d5f816bd2c6.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=fiona.klute@gmx.de \
--cc=kvalo@kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
--cc=pavel@ucw.cz \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).