From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Ingyu Jang <ingyujang25@korea.ac.kr>, linux-wireless@vger.kernel.org
Cc: brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH] wifi: brcmsmac: phy: Remove unreachable error handling code
Date: Sun, 1 Feb 2026 10:37:31 +0100 [thread overview]
Message-ID: <9dfb36bb-07be-4559-be83-39fe5c4dc9aa@broadcom.com> (raw)
In-Reply-To: <20260131172355.3367673-1-ingyujang25@korea.ac.kr>
On 31/01/2026 18:23, Ingyu Jang wrote:
> wlc_phy_txpwr_srom_read_lcnphy() in wlc_phy_attach_lcnphy() always
> returns true, making the error handling code unreachable. Change the
> function's return type to void and remove the dead code, similar to
> the cleanup done for wlc_phy_txpwr_srom_read_nphy() in commit
> 47f0e32ffe4e ("wifi: brcmsmac: phy: Remove unreachable code").
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Ingyu Jang <ingyujang25@korea.ac.kr>
> ---
> .../wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
prev parent reply other threads:[~2026-02-01 9:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 17:23 [PATCH] wifi: brcmsmac: phy: Remove unreachable error handling code Ingyu Jang
2026-02-01 9:37 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dfb36bb-07be-4559-be83-39fe5c4dc9aa@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=ingyujang25@korea.ac.kr \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox