From: Johannes Berg <johannes@sipsolutions.net>
To: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
Mikhail Karpenko <mkarpenko@quantenna.com>
Subject: Re: [RFC PATCH v3 0/2] cfg80211: fix duplicated scan entries after channel switch
Date: Fri, 26 Jul 2019 14:02:10 +0200 [thread overview]
Message-ID: <9e95c120de95c9f5f64ea8e589f036a1d338ad96.camel@sipsolutions.net> (raw)
In-Reply-To: <20190726101150.lykay6apgzvsb4ov@bars>
Hi Sergey,
> Yes, this is the use-case that I tried to address in the last revision
> of the patch.
OK! I didn't see it here and I guess I didn't look at the latest version
yet, or I missed it.
> If you take a look at the top of new cfg80211_update_assoc_bss_entry
> function:
>
> + /* use transmitting bss */
> + if (cbss->pub.transmitted_bss)
> + cbss = container_of(cbss->pub.transmitted_bss,
> + struct cfg80211_internal_bss,
> + pub);
Right, makes sense!
> Actually one of the major concerns is the lack of testing for the 'multi-BSSID'
> scenario. I verified the 'normal' scenario using both mac80211 (iwlwifi) and
> FullMAC (qtnfmac) cards. But at the moment I don't have any mac80211 card
> supporting multi-BSSID.
You might be able to do that with hwsim? There are multi-bssid test
cases in the hostap repository, and CSA test cases as well, so I guess
it'd be possible to come up with a combined one.
I'm not *too* worried about this though - we're still all testing and
developing this.
johannes
prev parent reply other threads:[~2019-07-26 12:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 17:36 [RFC PATCH v3 0/2] cfg80211: fix duplicated scan entries after channel switch Sergey Matyukevich
2019-07-10 17:37 ` [RFC PATCH v3 1/2] cfg80211: refactor cfg80211_bss_update Sergey Matyukevich
2019-07-12 9:12 ` Johannes Berg
2019-07-10 17:37 ` [RFC PATCH v3 2/2] cfg80211: fix duplicated scan entries after channel switch Sergey Matyukevich
2019-07-26 12:04 ` Johannes Berg
2019-07-26 12:30 ` Sergey Matyukevich
2019-07-12 9:11 ` [RFC PATCH v3 0/2] " Johannes Berg
2019-07-12 9:27 ` Sergey Matyukevich
2019-07-12 9:40 ` Johannes Berg
2019-07-12 10:52 ` Sergey Matyukevich
2019-07-26 7:36 ` Johannes Berg
2019-07-26 10:11 ` Sergey Matyukevich
2019-07-26 12:02 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e95c120de95c9f5f64ea8e589f036a1d338ad96.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mkarpenko@quantenna.com \
--cc=sergey.matyukevich.os@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox