From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: Vasanthakumar Thiagarajan <vasanth@atheros.com>,
Senthil Balasubramanian <senthilkumar@atheros.com>,
Felix Fietkau <Felix.Fietkau@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: Fix bug in the way "bf_tx_aborted" of struct ath_buf is used
Date: Wed, 26 May 2010 20:10:35 -0700 [thread overview]
Message-ID: <AANLkTikgmkLklDfZUcHo4tQDqaXQcaaxt-HpPsoZmKU7@mail.gmail.com> (raw)
In-Reply-To: <1274926013-31968-1-git-send-email-vasanth@atheros.com>
On Wed, May 26, 2010 at 7:06 PM, Vasanthakumar Thiagarajan
<vasanth@atheros.com> wrote:
> This bug was introduced by the following commit
>
> Author: Vasanthakumar Thiagarajan <vasanth@atheros.com>
> Date: Thu Apr 15 17:38:46 2010 -0400
>
> ath9k: Remove ATH9K_TX_SW_ABORTED and introduce a bool for this purpose
>
> Wrong buffer is checked for bf_tx_aborted field in ath_tx_num_badfrms(),
> this may result in a rate scaling with wrong feedback (number
> of unacked frames in this case). It is the last one in the chain
> of buffers for an aggregate frame that should be checked.
>
> Also it misses the initialization of this field in the buffer,
> this may lead to a situation where we stop the sw retransmission
> of failed subframes associated to this buffer.
>
> Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
> ---
FWIW, for those who want to test this, I've applied this patch into
the compat-wireless linux-next-pending/ directory. I've also kicked
out a new linux-next based compat-wireless tarball with the
pending+crap patches applied and fixed today's new compile issue
introduced by:
Author: Alexey Dobriyan <adobriyan@gmail.com>
Date: Mon May 24 14:33:03 2010 -0700
kernel-wide: replace USHORT_MAX, SHORT_MAX and SHORT_MIN with
USHRT_MAX, SHRT_MAX and SHRT_MIN
- C99 knows about USHRT_MAX/SHRT_MAX/SHRT_MIN, not
USHORT_MAX/SHORT_MAX/SHORT_MIN.
- Make SHRT_MIN of type s16, not int, for consistency.
[akpm@linux-foundation.org: fix drivers/dma/timb_dma.c]
[akpm@linux-foundation.org: fix security/keys/keyring.c]
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This fix required a simple patch on compat.git.
The "pc" compat-wireless tarball for today then is:
http://www.orbit-lab.org/kernel/compat-wireless-2.6/compat-wireless-2010-05-26-pc.tar.bz2
sha1sum: 62937a3bec62cc564731b30295b44994504355cf
I've compile and load tested ath9k against 2.6.31-20-generic
Luis
prev parent reply other threads:[~2010-05-27 3:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 2:06 [PATCH] ath9k: Fix bug in the way "bf_tx_aborted" of struct ath_buf is used Vasanthakumar Thiagarajan
2010-05-27 3:10 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikgmkLklDfZUcHo4tQDqaXQcaaxt-HpPsoZmKU7@mail.gmail.com \
--to=mcgrof@gmail.com \
--cc=Felix.Fietkau@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=senthilkumar@atheros.com \
--cc=vasanth@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).