ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Weedy]

Running airodump on ubuntus 2.6.30 kernel works as expected. The
2.6.32 kernel shipped in lucid never sees data packets.

I have narrowed it down to channel hopping. modprobing the driver and
starting mon0 on a fixed channel works as expected, but allowing
airodump to channel hop breaks the interface until the driver is
reset.

I wrote a script to download and build compat wireless starting from
2009-01-01 (granted everything fails until half way through october),
but every version that is successfully installed also show the same
bug.

Further instructions welcome.

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Gábor Stefanik]

On Sun, May 16, 2010 at 10:41 PM, Weedy <weedy2887@gmail.com> wrote:
> Running airodump on ubuntus 2.6.30 kernel works as expected. The
> 2.6.32 kernel shipped in lucid never sees data packets.
>
> I have narrowed it down to channel hopping. modprobing the driver and
> starting mon0 on a fixed channel works as expected, but allowing
> airodump to channel hop breaks the interface until the driver is
> reset.
>
> I wrote a script to download and build compat wireless starting from
> 2009-01-01 (granted everything fails until half way through october),
> but every version that is successfully installed also show the same
> bug.
>
> Further instructions welcome.

Try checking out linux-2.6, and doing a bisect between 2.6.30 and 2.6.32.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Weedy]

2010/5/16 Gábor Stefanik <netrolller.3d@gmail.com>:
> On Sun, May 16, 2010 at 10:41 PM, Weedy <weedy2887@gmail.com> wrote:
>> Running airodump on ubuntus 2.6.30 kernel works as expected. The
>> 2.6.32 kernel shipped in lucid never sees data packets.
>>
>> I have narrowed it down to channel hopping. modprobing the driver and
>> starting mon0 on a fixed channel works as expected, but allowing
>> airodump to channel hop breaks the interface until the driver is
>> reset.
>>
>> I wrote a script to download and build compat wireless starting from
>> 2009-01-01 (granted everything fails until half way through october),
>> but every version that is successfully installed also show the same
>> bug.
>>
>> Further instructions welcome.
>
> Try checking out linux-2.6, and doing a bisect between 2.6.30 and 2.6.32.

Do I have to check out the entire kernel? even with scripting my
netbook would take forever to do this.

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Gábor Stefanik]

2010/5/17 Weedy <weedy2887@gmail.com>:
> 2010/5/16 Gábor Stefanik <netrolller.3d@gmail.com>:
>> On Sun, May 16, 2010 at 10:41 PM, Weedy <weedy2887@gmail.com> wrote:
>>> Running airodump on ubuntus 2.6.30 kernel works as expected. The
>>> 2.6.32 kernel shipped in lucid never sees data packets.
>>>
>>> I have narrowed it down to channel hopping. modprobing the driver and
>>> starting mon0 on a fixed channel works as expected, but allowing
>>> airodump to channel hop breaks the interface until the driver is
>>> reset.
>>>
>>> I wrote a script to download and build compat wireless starting from
>>> 2009-01-01 (granted everything fails until half way through october),
>>> but every version that is successfully installed also show the same
>>> bug.
>>>
>>> Further instructions welcome.
>>
>> Try checking out linux-2.6, and doing a bisect between 2.6.30 and 2.6.32.
>
> Do I have to check out the entire kernel? even with scripting my
> netbook would take forever to do this.
>

Yes, you need to check out the entire repo - but with git, you do not
need to re-download the whole tree everytime you check out a new
revision; it is a distributed system. git is not CVS. :-)

-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Gábor Stefanik]

2010/5/23 Weedy <weedy2887@gmail.com>:
> 2010/5/17 Gábor Stefanik <netrolller.3d@gmail.com>:
>> What about cutting down the kernel to the absolute minimum required by
>> your machine?
>>
>> Also, Kbuild supports incremental builds as long as you do not "make
>> clean" before builds.
>>
> I just finished the cycle (told you it would take forever on this
> crapbook) and this  is what I got. To be sure I have done multiple
> boots with vmlinuz-2.6.31-rc5fffffffff-01634-geadac6b and
> vmlinuz-2.6.31-rc5fffffffff-01635-g56d1de0 and confirmed it broken.
> Patching todays compat-wireless tar with the output of "git diff
> 56d1de0a21db28e41741cfa0a66e18bc8d920554
> 56d1de0a21db28e41741cfa0a66e18bc8d920554^ >fffffffff.diff " restores
> expected functionality (Does this mean I get my name in the kernel
> log? :D ).
>
> $ git bisect bad
> 56d1de0a21db28e41741cfa0a66e18bc8d920554 is the first bad commit
> commit 56d1de0a21db28e41741cfa0a66e18bc8d920554
> Author: Bob Copeland <me@bobcopeland.com>
> Date:   Mon Aug 24 23:00:30 2009 -0400
>
>    ath5k: clean up filter flags setting
>
>    The maze of if() statements in configure_filter is confusing.
>    Reorganizing it as a switch statement makes it more apparent what
>    is going on and reveals several suspicious settings.  This has no
>    functional changes, though it does remove some redundant flags
>    that are set earlier.
>
>    Also now that we can sleep, protect sc->filter_flags with the
>    sc lock.
>
>    Signed-off-by: Bob Copeland <me@bobcopeland.com>
>    Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> :040000 040000 1ca00241b99b379f192c1ade63c082955c7dda69
> 1a19187e11210e3c66c224dba62a1896c46d0114 M      drivers
>

Certainly a possible cause. Chances are some of the "redundant" flags
weren't so redundant at all...

However, the original code was wrong too - I highly doubt we can rely
on sc->opmode to set monitor mode filter flags. I will look into this
when I get to my Linux box again.

-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Gábor Stefanik]

2010/5/23 Gábor Stefanik <netrolller.3d@gmail.com>:
> 2010/5/23 Weedy <weedy2887@gmail.com>:
>> 2010/5/17 Gábor Stefanik <netrolller.3d@gmail.com>:
>>> What about cutting down the kernel to the absolute minimum required by
>>> your machine?
>>>
>>> Also, Kbuild supports incremental builds as long as you do not "make
>>> clean" before builds.
>>>
>> I just finished the cycle (told you it would take forever on this
>> crapbook) and this  is what I got. To be sure I have done multiple
>> boots with vmlinuz-2.6.31-rc5fffffffff-01634-geadac6b and
>> vmlinuz-2.6.31-rc5fffffffff-01635-g56d1de0 and confirmed it broken.
>> Patching todays compat-wireless tar with the output of "git diff
>> 56d1de0a21db28e41741cfa0a66e18bc8d920554
>> 56d1de0a21db28e41741cfa0a66e18bc8d920554^ >fffffffff.diff " restores
>> expected functionality (Does this mean I get my name in the kernel
>> log? :D ).
>>
>> $ git bisect bad
>> 56d1de0a21db28e41741cfa0a66e18bc8d920554 is the first bad commit
>> commit 56d1de0a21db28e41741cfa0a66e18bc8d920554
>> Author: Bob Copeland <me@bobcopeland.com>
>> Date:   Mon Aug 24 23:00:30 2009 -0400
>>
>>    ath5k: clean up filter flags setting
>>
>>    The maze of if() statements in configure_filter is confusing.
>>    Reorganizing it as a switch statement makes it more apparent what
>>    is going on and reveals several suspicious settings.  This has no
>>    functional changes, though it does remove some redundant flags
>>    that are set earlier.
>>
>>    Also now that we can sleep, protect sc->filter_flags with the
>>    sc lock.
>>
>>    Signed-off-by: Bob Copeland <me@bobcopeland.com>
>>    Signed-off-by: John W. Linville <linville@tuxdriver.com>
>>
>> :040000 040000 1ca00241b99b379f192c1ade63c082955c7dda69
>> 1a19187e11210e3c66c224dba62a1896c46d0114 M      drivers
>>
>
> Certainly a possible cause. Chances are some of the "redundant" flags
> weren't so redundant at all...
>
> However, the original code was wrong too - I highly doubt we can rely
> on sc->opmode to set monitor mode filter flags. I will look into this
> when I get to my Linux box again.
>
> --
> Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
>

In the meantime, one thing to test: Add a printk of sc->opmode. If I
am right, this will never be set to NL80211_IFTYPE_MONITOR... That
would mean the promisc flag would never be set. Prior to the patch,
this was taken care by the following code:
       if (sc->opmode != NL80211_IFTYPE_AP &&
               sc->opmode != NL80211_IFTYPE_MESH_POINT &&
               test_bit(ATH_STAT_PROMISC, sc->status))
               rfilt |= AR5K_RX_FILTER_PROM;


-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Gábor Stefanik]

2010/5/25 Weedy <weedy2887@gmail.com>:
> 2010/5/23 Gábor Stefanik <netrolller.3d@gmail.com>:
>> In the meantime, one thing to test: Add a printk of sc->opmode.
>
> May 24 22:04:20 tiny-h4x kernel: [41147.243149] sc->opmode: 02 (over9000 times)
>
> So i'm guessing I did it wrong (I don't know C).
>        printk(KERN_NOTICE "sc->opmode: %02x\n", sc->opmode);
>

No, that is correct, and proves my theory (2 is NL80211_IFTYPE_STATION
- it should be 6 for monitor mode).

BTW, please use "Reply to all".

-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Weedy]

2010/5/24 Gábor Stefanik <netrolller.3d@gmail.com>:
> 2010/5/25 Weedy <weedy2887@gmail.com>:
>> 2010/5/23 Gábor Stefanik <netrolller.3d@gmail.com>:
>>> In the meantime, one thing to test: Add a printk of sc->opmode.
>>
>> May 24 22:04:20 tiny-h4x kernel: [41147.243149] sc->opmode: 02 (over9000 times)
>>
>> So i'm guessing I did it wrong (I don't know C).
>>        printk(KERN_NOTICE "sc->opmode: %02x\n", sc->opmode);
>>
>
> No, that is correct, and proves my theory (2 is NL80211_IFTYPE_STATION
> - it should be 6 for monitor mode).
>
> BTW, please use "Reply to all".
>
gmail got rid of the "Reply to all by default" option :<

When you have a patch I will be waiting.

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Bob Copeland]

2010/5/25 Weedy <weedy2887@gmail.com>:
> 2010/5/24 Gábor Stefanik <netrolller.3d@gmail.com>:
>> 2010/5/25 Weedy <weedy2887@gmail.com>:
>>> 2010/5/23 Gábor Stefanik <netrolller.3d@gmail.com>:
>>>> In the meantime, one thing to test: Add a printk of sc->opmode.
>>>
>>> May 24 22:04:20 tiny-h4x kernel: [41147.243149] sc->opmode: 02 (over9000 times)
>>>
>>> So i'm guessing I did it wrong (I don't know C).
>>>        printk(KERN_NOTICE "sc->opmode: %02x\n", sc->opmode);
>>>
>>
>> No, that is correct, and proves my theory (2 is NL80211_IFTYPE_STATION
>> - it should be 6 for monitor mode).
>>
>> BTW, please use "Reply to all".
>>
> gmail got rid of the "Reply to all by default" option :<
>
> When you have a patch I will be waiting.

Sorry, I missed this thread somehow.  Thanks for the detective
work and apologies for my stupid goof.  Gábor, are you prepping
a patch?  I can fix it if you like.

-- 
Bob Copeland %% www.bobcopeland.com

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Gábor Stefanik]

On Tue, May 25, 2010 at 4:53 PM, Bob Copeland <me@bobcopeland.com> wrote:
> 2010/5/25 Weedy <weedy2887@gmail.com>:
>> 2010/5/24 Gábor Stefanik <netrolller.3d@gmail.com>:
>>> 2010/5/25 Weedy <weedy2887@gmail.com>:
>>>> 2010/5/23 Gábor Stefanik <netrolller.3d@gmail.com>:
>>>>> In the meantime, one thing to test: Add a printk of sc->opmode.
>>>>
>>>> May 24 22:04:20 tiny-h4x kernel: [41147.243149] sc->opmode: 02 (over9000 times)
>>>>
>>>> So i'm guessing I did it wrong (I don't know C).
>>>>        printk(KERN_NOTICE "sc->opmode: %02x\n", sc->opmode);
>>>>
>>>
>>> No, that is correct, and proves my theory (2 is NL80211_IFTYPE_STATION
>>> - it should be 6 for monitor mode).
>>>
>>> BTW, please use "Reply to all".
>>>
>> gmail got rid of the "Reply to all by default" option :<
>>
>> When you have a patch I will be waiting.
>
> Sorry, I missed this thread somehow.  Thanks for the detective
> work and apologies for my stupid goof.  Gábor, are you prepping
> a patch?  I can fix it if you like.
>

If you can, please fix it - I know what the bug is, but have no solid
idea about a fix.

(The long-term fix of course would be to make mac80211 say
NL80211_IFTYPE_MONITOR for monitor interfaces, but AFAIK it is
impossible or unwanted - Johannes can probably shed more light on
this. One thing is sure: saying NL80211_IFTYPE_STATION when only a
monitor interface is active is wrong; it should be IFTYPE_MONITOR, or
if that is impossible, IFTYPE_INVALID.)

-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Bob Copeland]

2010/5/25 Gábor Stefanik <netrolller.3d@gmail.com>:
> On Tue, May 25, 2010 at 4:53 PM, Bob Copeland <me@bobcopeland.com> wrote:
>> 2010/5/25 Weedy <weedy2887@gmail.com>:
>>> 2010/5/24 Gábor Stefanik <netrolller.3d@gmail.com>:
>>>> 2010/5/25 Weedy <weedy2887@gmail.com>:
>>>>> 2010/5/23 Gábor Stefanik <netrolller.3d@gmail.com>:
>>>>>> In the meantime, one thing to test: Add a printk of sc->opmode.
>>>>>
>>>>> May 24 22:04:20 tiny-h4x kernel: [41147.243149] sc->opmode: 02 (over9000 times)
>>>>>
>>>>> So i'm guessing I did it wrong (I don't know C).
>>>>>        printk(KERN_NOTICE "sc->opmode: %02x\n", sc->opmode);
>>>>>
>>>>
>>>> No, that is correct, and proves my theory (2 is NL80211_IFTYPE_STATION
>>>> - it should be 6 for monitor mode).
>>>>
>>>> BTW, please use "Reply to all".
>>>>
>>> gmail got rid of the "Reply to all by default" option :<
>>>
>>> When you have a patch I will be waiting.
>>
>> Sorry, I missed this thread somehow.  Thanks for the detective
>> work and apologies for my stupid goof.  Gábor, are you prepping
>> a patch?  I can fix it if you like.
>>
>
> If you can, please fix it - I know what the bug is, but have no solid
> idea about a fix.

Ok, it should be enough to look at the filter flags instead of
the opmode -- I knew in the back of my mind that the monitor
stuff was bogus (part of the reason I did the patch in the first
place) but just got confused by what was already there I guess.

-- 
Bob Copeland %% www.bobcopeland.com

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Weedy]

2010/5/26 Bob Copeland <me@bobcopeland.com>:
> 2010/5/25 Gábor Stefanik <netrolller.3d@gmail.com>:
>> On Tue, May 25, 2010 at 4:53 PM, Bob Copeland <me@bobcopeland.com> wrote:
>>> 2010/5/25 Weedy <weedy2887@gmail.com>:
>>>> 2010/5/24 Gábor Stefanik <netrolller.3d@gmail.com>:
>>>>> 2010/5/25 Weedy <weedy2887@gmail.com>:
>>>>>> 2010/5/23 Gábor Stefanik <netrolller.3d@gmail.com>:
>>>>>>> In the meantime, one thing to test: Add a printk of sc->opmode.
>>>>>>
>>>>>> May 24 22:04:20 tiny-h4x kernel: [41147.243149] sc->opmode: 02 (over9000 times)
>>>>>>
>>>>>> So i'm guessing I did it wrong (I don't know C).
>>>>>>        printk(KERN_NOTICE "sc->opmode: %02x\n", sc->opmode);
>>>>>>
>>>>>
>>>>> No, that is correct, and proves my theory (2 is NL80211_IFTYPE_STATION
>>>>> - it should be 6 for monitor mode).
>>>>>
>>>>> BTW, please use "Reply to all".
>>>>>
>>>> gmail got rid of the "Reply to all by default" option :<
>>>>
>>>> When you have a patch I will be waiting.
>>>
>>> Sorry, I missed this thread somehow.  Thanks for the detective
>>> work and apologies for my stupid goof.  Gábor, are you prepping
>>> a patch?  I can fix it if you like.
>>>
>>
>> If you can, please fix it - I know what the bug is, but have no solid
>> idea about a fix.
>
> Ok, it should be enough to look at the filter flags instead of
> the opmode -- I knew in the back of my mind that the monitor
> stuff was bogus (part of the reason I did the patch in the first
> place) but just got confused by what was already there I guess.
>
>

I await your patch with open arms.

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Richard Farina]

Bob Copeland wrote:
> 2010/5/25 Gábor Stefanik <netrolller.3d@gmail.com>:
>   
>> On Tue, May 25, 2010 at 4:53 PM, Bob Copeland <me@bobcopeland.com> wrote:
>>     
>>> 2010/5/25 Weedy <weedy2887@gmail.com>:
>>>       
>>>> 2010/5/24 Gábor Stefanik <netrolller.3d@gmail.com>:
>>>>         
>>>>> 2010/5/25 Weedy <weedy2887@gmail.com>:
>>>>>           
>>>>>> 2010/5/23 Gábor Stefanik <netrolller.3d@gmail.com>:
>>>>>>             
>>>>>>> In the meantime, one thing to test: Add a printk of sc->opmode.
>>>>>>>               
>>>>>> May 24 22:04:20 tiny-h4x kernel: [41147.243149] sc->opmode: 02 (over9000 times)
>>>>>>
>>>>>> So i'm guessing I did it wrong (I don't know C).
>>>>>>        printk(KERN_NOTICE "sc->opmode: %02x\n", sc->opmode);
>>>>>>
>>>>>>             
>>>>> No, that is correct, and proves my theory (2 is NL80211_IFTYPE_STATION
>>>>> - it should be 6 for monitor mode).
>>>>>
>>>>> BTW, please use "Reply to all".
>>>>>
>>>>>           
>>>> gmail got rid of the "Reply to all by default" option :<
>>>>
>>>> When you have a patch I will be waiting.
>>>>         
>>> Sorry, I missed this thread somehow.  Thanks for the detective
>>> work and apologies for my stupid goof.  Gábor, are you prepping
>>> a patch?  I can fix it if you like.
>>>
>>>       
>> If you can, please fix it - I know what the bug is, but have no solid
>> idea about a fix.
>>     
>
> Ok, it should be enough to look at the filter flags instead of
> the opmode -- I knew in the back of my mind that the monitor
> stuff was bogus (part of the reason I did the patch in the first
> place) but just got confused by what was already there I guess.
>
>   
I've got a lot of people very interested in this fix. Let me know what 
kind of support you need to make this happen.  You know where to find me 
on irc ;-)

Thanks,
Rick

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Bob Copeland]

[-- Attachment #1: Type: text/plain, Size: 2438 bytes --]

On Wed, May 26, 2010 at 11:49 PM, Richard Farina <sidhayn@gmail.com> wrote:
> Bob Copeland wrote:
>> Ok, it should be enough to look at the filter flags instead of
>> the opmode -- I knew in the back of my mind that the monitor
>> stuff was bogus (part of the reason I did the patch in the first
>> place) but just got confused by what was already there I guess.
>
> I've got a lot of people very interested in this fix. Let me know what kind
> of support you need to make this happen.  You know where to find me on irc
> ;-)

Ok, can you and Weedy try this patch?

Use the attachment -- gmail will screw up the whitespace, but I included
it inline for reference.

Weedy, if you want reported-by credit can you give your full name and
preferred email address?

From: Bob Copeland <me@bobcopeland.com>
Date: Thu, 27 May 2010 08:54:38 -0400
Subject: [PATCH] ath5k: retain promiscuous setting

Commit 56d1de0a21db28e41741cfa0a66e18bc8d920554, "ath5k: clean up
filter flags setting" introduced a regression in monitor mode such
that the promisc filter flag would get lost.

Although we set the promisc flag when it changed, we did not
preserve it across subsequent calls to configure_filter.  This patch
restores the original functionality.

Cc: stable@kernel.org
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---

Note, a better fix would be to just unconditionally look at new_flags,
but this is the minimal change for stable.  I'll add fixing all this
stuff up to my todo.

 drivers/net/wireless/ath/ath5k/base.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/base.c
b/drivers/net/wireless/ath/ath5k/base.c
index 9c27623..9e023b8 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -3153,13 +3153,15 @@ static void ath5k_configure_filter(struct
ieee80211_hw *hw,

 	if (changed_flags & (FIF_PROMISC_IN_BSS | FIF_OTHER_BSS)) {
 		if (*new_flags & FIF_PROMISC_IN_BSS) {
-			rfilt |= AR5K_RX_FILTER_PROM;
 			__set_bit(ATH_STAT_PROMISC, sc->status);
 		} else {
 			__clear_bit(ATH_STAT_PROMISC, sc->status);
 		}
 	}

+	if (test_bit(ATH_STAT_PROMISC, sc->status))
+		rfilt |= AR5K_RX_FILTER_PROM;
+
 	/* Note, AR5K_RX_FILTER_MCAST is already enabled */
 	if (*new_flags & FIF_ALLMULTI) {
 		mfilt[0] =  ~0;
-- 
1.6.3.3


-- 
Bob Copeland %% www.bobcopeland.com

[-- Attachment #2: 0001-ath5k-retain-promiscuous-setting.patch --]
[-- Type: text/x-patch, Size: 1638 bytes --]

From befe47a84a22312e0547d04cd3d250b0e49ecf54 Mon Sep 17 00:00:00 2001
From: Bob Copeland <me@bobcopeland.com>
Date: Thu, 27 May 2010 08:54:38 -0400
Subject: [PATCH] ath5k: retain promiscuous setting

Commit 56d1de0a21db28e41741cfa0a66e18bc8d920554, "ath5k: clean up
filter flags setting" introduced a regression in monitor mode such
that the promisc filter flag would get lost.

Although we set the promisc flag when it changed, we did not
preserve it across subsequent calls to configure_filter.  This patch
restores the original functionality.

Cc: stable@kernel.org
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---

Note, a better fix would be to just unconditionally look at new_flags,
but this is the minimal change for stable.  I'll add fixing all this
stuff up to my todo.

 drivers/net/wireless/ath/ath5k/base.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 9c27623..9e023b8 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -3153,13 +3153,15 @@ static void ath5k_configure_filter(struct ieee80211_hw *hw,
 
 	if (changed_flags & (FIF_PROMISC_IN_BSS | FIF_OTHER_BSS)) {
 		if (*new_flags & FIF_PROMISC_IN_BSS) {
-			rfilt |= AR5K_RX_FILTER_PROM;
 			__set_bit(ATH_STAT_PROMISC, sc->status);
 		} else {
 			__clear_bit(ATH_STAT_PROMISC, sc->status);
 		}
 	}
 
+	if (test_bit(ATH_STAT_PROMISC, sc->status))
+		rfilt |= AR5K_RX_FILTER_PROM;
+
 	/* Note, AR5K_RX_FILTER_MCAST is already enabled */
 	if (*new_flags & FIF_ALLMULTI) {
 		mfilt[0] =  ~0;
-- 
1.6.3.3

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Weedy]

On Thu, May 27, 2010 at 10:31 AM, Bob Copeland <me@bobcopeland.com> wrote:
>
> Ok, can you and Weedy try this patch?
Works for me but I only have 2 active APs around me at work. When I
get home I'll have access to a cloud.

> Weedy, if you want reported-by credit can you give your full name and
> preferred email address?
Do I have to? I don't really want to tie my name to this email :/

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Bob Copeland]

On Thu, May 27, 2010 at 1:40 PM, Weedy <weedy2887@gmail.com> wrote:

>> Weedy, if you want reported-by credit can you give your full name and
>> preferred email address?
> Do I have to? I don't really want to tie my name to this email :/

Honestly I don't know what reported-by policy is (other than I should
get your consent first).  I guess John can weigh in whether:

   Reported-by: weedy2887@gmail.com

is acceptable.  For S-o-b, the rule is no anonymous or pseudonymous
contributions.  Of course, you don't have to be credited, but your
bisection was a huge help in pinning it down :)

-- 
Bob Copeland %% www.bobcopeland.com

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[John W. Linville]

On Thu, May 27, 2010 at 02:31:12PM -0400, Bob Copeland wrote:
> On Thu, May 27, 2010 at 1:40 PM, Weedy <weedy2887@gmail.com> wrote:
> 
> >> Weedy, if you want reported-by credit can you give your full name and
> >> preferred email address?
> > Do I have to? I don't really want to tie my name to this email :/
> 
> Honestly I don't know what reported-by policy is (other than I should
> get your consent first).  I guess John can weigh in whether:
> 
>    Reported-by: weedy2887@gmail.com
> 
> is acceptable.  For S-o-b, the rule is no anonymous or pseudonymous
> contributions.  Of course, you don't have to be credited, but your
> bisection was a huge help in pinning it down :)

It isn't necessary, and I suspect that someone that doesn't want his
name attached doesn't wanted the addition of any further unnecessary
evidence in the git changelogs either. :-)

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Weedy]

On Thu, May 27, 2010 at 02:31:12PM -0400, Bob Copeland wrote:
> Honestly I don't know what reported-by policy is (other than I should
> get your consent first).  I guess John can weigh in whether:
>
>    Reported-by: weedy2887@gmail.com
>
> is acceptable.  For S-o-b, the rule is no anonymous or pseudonymous
> contributions.  Of course, you don't have to be credited, but your
> bisection was a huge help in pinning it down :)

Reported-by: Weedy (weedy2887@gmail.com)

 Is fine. (And I don't know C so I doubt I'll need to use my real name)

Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite)

[Richard Farina]

Bob Copeland wrote:
> On Wed, May 26, 2010 at 11:49 PM, Richard Farina <sidhayn@gmail.com> wrote:
>   
>> Bob Copeland wrote:
>>     
>>> Ok, it should be enough to look at the filter flags instead of
>>> the opmode -- I knew in the back of my mind that the monitor
>>> stuff was bogus (part of the reason I did the patch in the first
>>> place) but just got confused by what was already there I guess.
>>>       
>> I've got a lot of people very interested in this fix. Let me know what kind
>> of support you need to make this happen.  You know where to find me on irc
>> ;-)
>>     
>
> Ok, can you and Weedy try this patch?
>
> Use the attachment -- gmail will screw up the whitespace, but I included
> it inline for reference.
>
> Weedy, if you want reported-by credit can you give your full name and
> preferred email address?
>
> From: Bob Copeland <me@bobcopeland.com>
> Date: Thu, 27 May 2010 08:54:38 -0400
> Subject: [PATCH] ath5k: retain promiscuous setting
>
> Commit 56d1de0a21db28e41741cfa0a66e18bc8d920554, "ath5k: clean up
> filter flags setting" introduced a regression in monitor mode such
> that the promisc filter flag would get lost.
>
> Although we set the promisc flag when it changed, we did not
> preserve it across subsequent calls to configure_filter.  This patch
> restores the original functionality.
>
> Cc: stable@kernel.org
> Signed-off-by: Bob Copeland <me@bobcopeland.com>
> ---
>
> Note, a better fix would be to just unconditionally look at new_flags,
> but this is the minimal change for stable.  I'll add fixing all this
> stuff up to my todo.
>
>  drivers/net/wireless/ath/ath5k/base.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/base.c
> b/drivers/net/wireless/ath/ath5k/base.c
> index 9c27623..9e023b8 100644
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -3153,13 +3153,15 @@ static void ath5k_configure_filter(struct
> ieee80211_hw *hw,
>
>  	if (changed_flags & (FIF_PROMISC_IN_BSS | FIF_OTHER_BSS)) {
>  		if (*new_flags & FIF_PROMISC_IN_BSS) {
> -			rfilt |= AR5K_RX_FILTER_PROM;
>  			__set_bit(ATH_STAT_PROMISC, sc->status);
>  		} else {
>  			__clear_bit(ATH_STAT_PROMISC, sc->status);
>  		}
>  	}
>
> +	if (test_bit(ATH_STAT_PROMISC, sc->status))
> +		rfilt |= AR5K_RX_FILTER_PROM;
> +
>  	/* Note, AR5K_RX_FILTER_MCAST is already enabled */
>  	if (*new_flags & FIF_ALLMULTI) {
>  		mfilt[0] =  ~0;
>   
Tested-By: Rick Farina

This patch fixes the problem, data packets are now captured while in 
monitor mode.  Incidentally when I tried to chase this back to see when 
it started I found the same behavior in 2.6.32_rc and even in 2.6.29 
(which is funny since Weedy bisected the change to some time during 
2.6.31_rc5).  This fix should be pushed out to as much of stable as 
possible as soon as possible.  Thanks for the patch Bob!

-Rick Farina