From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from fg-out-1718.google.com ([72.14.220.154]:4986 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752881Ab0EWSMn convert rfc822-to-8bit (ORCPT ); Sun, 23 May 2010 14:12:43 -0400 Received: by fg-out-1718.google.com with SMTP id d23so1648347fga.1 for ; Sun, 23 May 2010 11:12:41 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: =?ISO-8859-1?Q?G=E1bor_Stefanik?= Date: Sun, 23 May 2010 20:12:21 +0200 Message-ID: Subject: Re: ath5k past 2.6.30 breaks monitor mode (and thus the aircrack suite) To: Weedy , linux-wireless Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2010/5/23 Weedy : > 2010/5/17 Gábor Stefanik : >> What about cutting down the kernel to the absolute minimum required by >> your machine? >> >> Also, Kbuild supports incremental builds as long as you do not "make >> clean" before builds. >> > I just finished the cycle (told you it would take forever on this > crapbook) and this  is what I got. To be sure I have done multiple > boots with vmlinuz-2.6.31-rc5fffffffff-01634-geadac6b and > vmlinuz-2.6.31-rc5fffffffff-01635-g56d1de0 and confirmed it broken. > Patching todays compat-wireless tar with the output of "git diff > 56d1de0a21db28e41741cfa0a66e18bc8d920554 > 56d1de0a21db28e41741cfa0a66e18bc8d920554^ >fffffffff.diff " restores > expected functionality (Does this mean I get my name in the kernel > log? :D ). > > $ git bisect bad > 56d1de0a21db28e41741cfa0a66e18bc8d920554 is the first bad commit > commit 56d1de0a21db28e41741cfa0a66e18bc8d920554 > Author: Bob Copeland > Date:   Mon Aug 24 23:00:30 2009 -0400 > >    ath5k: clean up filter flags setting > >    The maze of if() statements in configure_filter is confusing. >    Reorganizing it as a switch statement makes it more apparent what >    is going on and reveals several suspicious settings.  This has no >    functional changes, though it does remove some redundant flags >    that are set earlier. > >    Also now that we can sleep, protect sc->filter_flags with the >    sc lock. > >    Signed-off-by: Bob Copeland >    Signed-off-by: John W. Linville > > :040000 040000 1ca00241b99b379f192c1ade63c082955c7dda69 > 1a19187e11210e3c66c224dba62a1896c46d0114 M      drivers > Certainly a possible cause. Chances are some of the "redundant" flags weren't so redundant at all... However, the original code was wrong too - I highly doubt we can rely on sc->opmode to set monitor mode filter flags. I will look into this when I get to my Linux box again. -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)