From: Masi Osmani <mas-i@hotmail.de>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org, Masi Osmani <mas-i@hotmail.de>,
ath9k-devel@qca.qualcomm.com
Subject: [PATCH 10/10] carl9170: phy: add periodic runtime IQ calibration
Date: Thu, 12 Mar 2026 11:38:05 +0100 [thread overview]
Message-ID: <AM7PPF5613FA0B6567EFD98F8FD6FE6511E9444A@AM7PPF5613FA0B6.EURP251.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <cover.1773277728.git.mas-i@hotmail.de>
Add periodic runtime I/Q calibration triggered from the existing
survey statistics work handler (carl9170_stat_work). The AR9170
hardware performs initial IQ calibration during channel setup, but
I/Q imbalance drifts with temperature over time, degrading EVM
and increasing packet error rate.
The new carl9170_run_iq_calibration() function sets the DO_IQCAL
bit in PHY_TIMING_CTRL4 for both chains, which triggers the
hardware to re-measure I/Q imbalance and update the correction
coefficients automatically. This is a non-blocking operation --
the hardware runs the calibration in the background without
interrupting normal traffic.
The ath9k driver performs similar periodic calibration via its
longcal timer (every 30s). carl9170_stat_work runs at a
comparable interval, making it a natural trigger point.
Signed-off-by: Masi Osmani <mas-i@hotmail.de>
---
drivers/net/wireless/ath/carl9170/carl9170.h | 1 +
drivers/net/wireless/ath/carl9170/main.c | 2 ++
drivers/net/wireless/ath/carl9170/phy.c | 36 ++++++++++++++++++++
3 files changed, 39 insertions(+)
diff --git a/drivers/net/wireless/ath/carl9170/carl9170.h b/drivers/net/wireless/ath/carl9170/carl9170.h
index 2eedb2f..0175f8e 100644
--- a/drivers/net/wireless/ath/carl9170/carl9170.h
+++ b/drivers/net/wireless/ath/carl9170/carl9170.h
@@ -605,6 +605,7 @@ int carl9170_set_channel(struct ar9170 *ar, struct ieee80211_channel *channel,
enum nl80211_channel_type bw);
int carl9170_get_noisefloor(struct ar9170 *ar);
void carl9170_update_channel_maxpower(struct ar9170 *ar);
+int carl9170_run_iq_calibration(struct ar9170 *ar);
/* FW */
int carl9170_parse_firmware(struct ar9170 *ar);
diff --git a/drivers/net/wireless/ath/carl9170/main.c b/drivers/net/wireless/ath/carl9170/main.c
index ebf9fa9..50c0922 100644
--- a/drivers/net/wireless/ath/carl9170/main.c
+++ b/drivers/net/wireless/ath/carl9170/main.c
@@ -910,6 +910,8 @@ static void carl9170_stat_work(struct work_struct *work)
mutex_lock(&ar->mutex);
err = carl9170_update_survey(ar, false, true);
+ if (!err)
+ carl9170_run_iq_calibration(ar);
mutex_unlock(&ar->mutex);
if (err)
diff --git a/drivers/net/wireless/ath/carl9170/phy.c b/drivers/net/wireless/ath/carl9170/phy.c
index c294df7..b145e9e 100644
--- a/drivers/net/wireless/ath/carl9170/phy.c
+++ b/drivers/net/wireless/ath/carl9170/phy.c
@@ -1637,6 +1637,42 @@ void carl9170_update_channel_maxpower(struct ar9170 *ar)
}
}
+int carl9170_run_iq_calibration(struct ar9170 *ar)
+{
+ u32 val;
+ int err;
+
+ if (!ar->channel)
+ return 0;
+
+ /*
+ * Trigger runtime IQ calibration. The hardware measures
+ * I/Q imbalance and updates the correction coefficients
+ * automatically when DO_IQCAL is set. We trigger on both
+ * chains and re-enable the IQ correction afterwards.
+ */
+ err = carl9170_read_reg(ar, AR9170_PHY_REG_TIMING_CTRL4(0), &val);
+ if (err)
+ return err;
+
+ val |= AR9170_PHY_TIMING_CTRL4_DO_IQCAL;
+ err = carl9170_write_reg(ar, AR9170_PHY_REG_TIMING_CTRL4(0), val);
+ if (err)
+ return err;
+
+ /* chain 2 */
+ err = carl9170_read_reg(ar, AR9170_PHY_REG_TIMING_CTRL4(2), &val);
+ if (err)
+ return err;
+
+ val |= AR9170_PHY_TIMING_CTRL4_DO_IQCAL;
+ err = carl9170_write_reg(ar, AR9170_PHY_REG_TIMING_CTRL4(2), val);
+ if (err)
+ return err;
+
+ return 0;
+}
+
static int carl9170_set_radar_detection(struct ar9170 *ar,
struct ieee80211_channel *channel)
{
--
2.51.0
next prev parent reply other threads:[~2026-03-12 10:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1773277728.git.mas-i@hotmail.de>
2026-03-12 10:37 ` [PATCH 01/10] carl9170: mac80211: enable Short Guard Interval for 20 MHz Masi Osmani
2026-03-21 18:41 ` Christian Lamparter
2026-03-12 10:37 ` [PATCH 02/10] carl9170: mac80211: advertise RX STBC capability Masi Osmani
2026-03-21 18:47 ` Christian Lamparter
2026-03-12 10:37 ` [PATCH 03/10] carl9170: mac80211: document spatial multiplexing power save handler Masi Osmani
2026-03-21 18:57 ` Christian Lamparter
2026-03-12 10:37 ` [PATCH 04/10] carl9170: rx: wire up dropped frame counter Masi Osmani
2026-03-21 19:03 ` Christian Lamparter
2026-03-12 10:38 ` [PATCH 05/10] carl9170: rx: track PHY errors via debugfs Masi Osmani
2026-03-21 20:29 ` Christian Lamparter
2026-03-12 10:38 ` [PATCH 06/10] carl9170: phy: populate per-channel TX power from EEPROM Masi Osmani
2026-03-21 19:24 ` Christian Lamparter
2026-03-12 10:38 ` [PATCH 07/10] carl9170: main: add exponential restart backoff Masi Osmani
2026-03-21 20:42 ` Christian Lamparter
2026-03-12 10:38 ` [PATCH 08/10] carl9170: phy: enable antenna diversity for 2-chain devices Masi Osmani
2026-03-21 19:53 ` Christian Lamparter
2026-03-12 10:38 ` [PATCH 09/10] carl9170: fw: enable DFS radar detection Masi Osmani
2026-03-21 20:11 ` Christian Lamparter
2026-03-12 10:38 ` Masi Osmani [this message]
2026-03-21 21:25 ` [PATCH 10/10] carl9170: phy: add periodic runtime IQ calibration Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM7PPF5613FA0B6567EFD98F8FD6FE6511E9444A@AM7PPF5613FA0B6.EURP251.PROD.OUTLOOK.COM \
--to=mas-i@hotmail.de \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox