Re: [RFC] mac80211: reestablish mis-configured existing Rx BA sessions

[Arik Nemtsov <arik@wizery.com>]

On Thu, May 5, 2011 at 02:15, Arik Nemtsov <arik@wizery.com> wrote:
>
>
> On Wed, May 4, 2011 at 19:50, Johannes Berg <johannes@sipsolutions.net>
> wrote:
>>
>> On Tue, 2011-05-03 at 12:12 +0300, Arik Nemtsov wrote:
>> > When forming a Rx BA session, sometimes the ADDBA response gets lost.
>> > This leads to a situation where the session is configured locally, but
>> > doesn't exist on the remote side. Subsequent ADDBA requests are declined
>> > by mac80211.
>> >
>> > Fix this by assuming the session state of the initiator is the correct
>> > one. When receiving an unexpected ADDBA request on a TID with an active
>> > Rx BA session, delete the existing one and establish a new session.
>>
>> I thought about this for a while but I don't really have an opinion I
>> think. Maybe the behaviour could be avoided by checking the ack status,
>> but that wouldn't be good enough for devices that don't have that...
>
> It helped me with at least two APs (when I put them far enough from the
> station). I guess it won't hurt anything.
> Checking the ack won't do any actual good - if the AP doesn't send another
> ADDBA request we won't have a session up anyway. It just saves a little
> memory on the reorder buffer.
> Arik

[replying again with a plain text email]