From: Matteo Croce <matteo@openwrt.org>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] 802.11n frame injection
Date: Sun, 24 Apr 2011 22:42:07 +0200 [thread overview]
Message-ID: <BANLkTikWr0xsOcrKAGF4EVF02Ji=7s3vHg@mail.gmail.com> (raw)
In-Reply-To: <1303672484.14128.2.camel@maxim-laptop>
2011/4/24 Maxim Levitsky <maximlevitsky@gmail.com>:
> On Sun, 2011-04-24 at 10:15 +0200, Johannes Berg wrote:
>> On Fri, 2011-04-22 at 18:34 +0200, Matteo Croce wrote:
>> > This patch allows to set the tx rate and retries when injecting,
>> > and report correct MCS information on received frames.
>>
>> This description is wrong. It doesn't touch rx.c, does it?
>
> It does appear to touch radiotap processing, and I bet the developer
> tested this, but other than that don't know.
>
>>
>> johannes
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> Best regards,
> Maxim Levitsky
>
> Visit my blog: http://maximlevitsky.wordpress.com
> Warning: Above blog contains rants.
>
>
The old patch added RX processing but now all it's merged in mainline
and the only piece left in rx.c was:
--- a/net/mac80211/rx.c 2011-04-21 19:08:26.253148959 +0200
+++ b/net/mac80211/rx.c 2011-04-22 11:56:24.257134886 +0200
@@ -195,6 +195,7 @@
put_unaligned_le16(rx_flags, pos);
pos += 2;
+ /* IEEE80211_RADIOTAP_RATE_MCS */
if (status->flag & RX_FLAG_HT) {
rthdr->it_present |= cpu_to_le32(1 << IEEE80211_RADIOTAP_MCS);
*pos++ = IEEE80211_RADIOTAP_MCS_HAVE_MCS |
so I decided to remove this chunk, but I forget the original description
--
Matteo Croce
OpenWrt Developer
_______ ________ __
| |.-----.-----.-----.| | | |.----.| |_
| - || _ | -__| || | | || _|| _|
|_______|| __|_____|__|__||________||__| |____|
|__| W I R E L E S S F R E E D O M
ATTITUDE ADJUSTMENT (bleeding edge) --------------
* 1/4 oz Vodka Pour all ingredents into mixing
* 1/4 oz Gin tin with ice, strain into glass.
* 1/4 oz Amaretto
* 1/4 oz Triple sec
* 1/4 oz Peach schnapps
* 1/4 oz Sour mix
* 1 splash Cranberry juice
-----------------------------------------------------
next prev parent reply other threads:[~2011-04-24 20:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 16:34 [PATCH v2] 802.11n frame injection Matteo Croce
2011-04-24 8:15 ` Johannes Berg
2011-04-24 19:14 ` Maxim Levitsky
2011-04-24 20:42 ` Matteo Croce [this message]
2011-05-11 16:49 ` John W. Linville
2011-05-11 17:06 ` Johannes Berg
2011-05-14 22:07 ` Matteo Croce
2011-05-18 22:49 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikWr0xsOcrKAGF4EVF02Ji=7s3vHg@mail.gmail.com' \
--to=matteo@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=maximlevitsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).