* invalid regdomain: 0x5c (was: problem with D-Link DWA-160) [not found] <BANLkTinLdpaS9GLN88ObSACbmQJOK7wnug@mail.gmail.com> @ 2011-04-06 12:23 ` Christian Lamparter 2011-04-06 17:17 ` Luis R. Rodriguez 2011-04-08 0:41 ` invalid regdomain: 0x5c (was: problem with D-Link DWA-160) Joe Culler 0 siblings, 2 replies; 6+ messages in thread From: Christian Lamparter @ 2011-04-06 12:23 UTC (permalink / raw) To: Joe Culler; +Cc: linux-wireless, Michael Green, Luis R. Rodriguez, David Quan On Wednesday 06 April 2011 05:26:28 Joe Culler wrote: > [...] > I have a problem with carl9170 driver with my d-link dwa-160 under > linux-2.6.39-rc1. > Here's the dmesg: > [ 3114.257063] ath: EEPROM regdomain: 0x5c > [ 3114.257066] ath: EEPROM indicates we should expect a direct regpair map > [ 3114.257069] ath: invalid regulatory domain/country code 0x5c > [ 3114.257071] ath: Invalid EEPROM contents clearly, the regdomain code 0x5c is not defined in the drivers/net/wireless/ath/regd_common.h => regDomainPairs struct. this would be easy to fix [see attached patch], however I'm not quite sure what to do about the 5GHz band in this case, since the CTL_FCC is more restrictive than it should be. Regards, Chr --- diff --git a/drivers/net/wireless/ath/regd_common.h b/drivers/net/wireless/ath/regd_common.h index 248c670..5c2cfe6 100644 --- a/drivers/net/wireless/ath/regd_common.h +++ b/drivers/net/wireless/ath/regd_common.h @@ -195,6 +195,7 @@ static struct reg_dmn_pair_mapping regDomainPairs[] = { {APL9_WORLD, CTL_ETSI, CTL_ETSI}, {APL3_FCCA, CTL_FCC, CTL_FCC}, + {APL7_FCCA, CTL_FCC, CTL_FCC}, {APL1_ETSIC, CTL_FCC, CTL_ETSI}, {APL2_ETSIC, CTL_FCC, CTL_ETSI}, {APL2_APLD, CTL_FCC, NO_CTL}, ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: invalid regdomain: 0x5c (was: problem with D-Link DWA-160) 2011-04-06 12:23 ` invalid regdomain: 0x5c (was: problem with D-Link DWA-160) Christian Lamparter @ 2011-04-06 17:17 ` Luis R. Rodriguez 2011-04-06 17:17 ` Luis R. Rodriguez 2011-04-08 0:41 ` invalid regdomain: 0x5c (was: problem with D-Link DWA-160) Joe Culler 1 sibling, 1 reply; 6+ messages in thread From: Luis R. Rodriguez @ 2011-04-06 17:17 UTC (permalink / raw) To: Christian Lamparter; +Cc: Joe Culler, linux-wireless, Michael Green, David Quan On Wed, Apr 6, 2011 at 5:23 AM, Christian Lamparter <chunkeey@googlemail.com> wrote: > On Wednesday 06 April 2011 05:26:28 Joe Culler wrote: >> [...] >> I have a problem with carl9170 driver with my d-link dwa-160 under >> linux-2.6.39-rc1. >> Here's the dmesg: > >> [ 3114.257063] ath: EEPROM regdomain: 0x5c >> [ 3114.257066] ath: EEPROM indicates we should expect a direct regpair map >> [ 3114.257069] ath: invalid regulatory domain/country code 0x5c >> [ 3114.257071] ath: Invalid EEPROM contents > clearly, the regdomain code 0x5c is not defined in the > drivers/net/wireless/ath/regd_common.h => regDomainPairs struct. > > this would be easy to fix [see attached patch], however I'm > not quite sure what to do about the 5GHz band in this case, > since the CTL_FCC is more restrictive than it should be. > > Regards, > Chr > > --- > diff --git a/drivers/net/wireless/ath/regd_common.h b/drivers/net/wireless/ath/regd_common.h > index 248c670..5c2cfe6 100644 > --- a/drivers/net/wireless/ath/regd_common.h > +++ b/drivers/net/wireless/ath/regd_common.h > @@ -195,6 +195,7 @@ static struct reg_dmn_pair_mapping regDomainPairs[] = { > {APL9_WORLD, CTL_ETSI, CTL_ETSI}, > > {APL3_FCCA, CTL_FCC, CTL_FCC}, > + {APL7_FCCA, CTL_FCC, CTL_FCC}, > {APL1_ETSIC, CTL_FCC, CTL_ETSI}, > {APL2_ETSIC, CTL_FCC, CTL_ETSI}, > {APL2_APLD, CTL_FCC, NO_CTL}, I verified internally with our other code and this is correct, APL7 maps to FCC CTL and FCCA maps to FCC CTL as well. For an upstream patch: Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com> Luis ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: invalid regdomain: 0x5c (was: problem with D-Link DWA-160) 2011-04-06 17:17 ` Luis R. Rodriguez @ 2011-04-06 17:17 ` Luis R. Rodriguez 2011-04-06 17:18 ` John W. Linville 2011-04-06 18:40 ` [PATCH -stable] ath: add missing regdomain pair 0x5c mapping Christian Lamparter 0 siblings, 2 replies; 6+ messages in thread From: Luis R. Rodriguez @ 2011-04-06 17:17 UTC (permalink / raw) To: Christian Lamparter; +Cc: Joe Culler, linux-wireless, Michael Green, David Quan On Wed, Apr 6, 2011 at 10:17 AM, Luis R. Rodriguez <lrodriguez@atheros.com> wrote: > On Wed, Apr 6, 2011 at 5:23 AM, Christian Lamparter > <chunkeey@googlemail.com> wrote: >> On Wednesday 06 April 2011 05:26:28 Joe Culler wrote: >>> [...] >>> I have a problem with carl9170 driver with my d-link dwa-160 under >>> linux-2.6.39-rc1. >>> Here's the dmesg: >> >>> [ 3114.257063] ath: EEPROM regdomain: 0x5c >>> [ 3114.257066] ath: EEPROM indicates we should expect a direct regpair map >>> [ 3114.257069] ath: invalid regulatory domain/country code 0x5c >>> [ 3114.257071] ath: Invalid EEPROM contents >> clearly, the regdomain code 0x5c is not defined in the >> drivers/net/wireless/ath/regd_common.h => regDomainPairs struct. >> >> this would be easy to fix [see attached patch], however I'm >> not quite sure what to do about the 5GHz band in this case, >> since the CTL_FCC is more restrictive than it should be. >> >> Regards, >> Chr >> >> --- >> diff --git a/drivers/net/wireless/ath/regd_common.h b/drivers/net/wireless/ath/regd_common.h >> index 248c670..5c2cfe6 100644 >> --- a/drivers/net/wireless/ath/regd_common.h >> +++ b/drivers/net/wireless/ath/regd_common.h >> @@ -195,6 +195,7 @@ static struct reg_dmn_pair_mapping regDomainPairs[] = { >> {APL9_WORLD, CTL_ETSI, CTL_ETSI}, >> >> {APL3_FCCA, CTL_FCC, CTL_FCC}, >> + {APL7_FCCA, CTL_FCC, CTL_FCC}, >> {APL1_ETSIC, CTL_FCC, CTL_ETSI}, >> {APL2_ETSIC, CTL_FCC, CTL_ETSI}, >> {APL2_APLD, CTL_FCC, NO_CTL}, > > I verified internally with our other code and this is correct, APL7 > maps to FCC CTL and FCCA maps to FCC CTL as well. For an upstream > patch: > > Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com> Oh and please Cc stable@kernel.org, thanks a lot! Luis ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: invalid regdomain: 0x5c (was: problem with D-Link DWA-160) 2011-04-06 17:17 ` Luis R. Rodriguez @ 2011-04-06 17:18 ` John W. Linville 2011-04-06 18:40 ` [PATCH -stable] ath: add missing regdomain pair 0x5c mapping Christian Lamparter 1 sibling, 0 replies; 6+ messages in thread From: John W. Linville @ 2011-04-06 17:18 UTC (permalink / raw) To: Luis R. Rodriguez Cc: Christian Lamparter, Joe Culler, linux-wireless, Michael Green, David Quan On Wed, Apr 06, 2011 at 10:17:45AM -0700, Luis R. Rodriguez wrote: > On Wed, Apr 6, 2011 at 10:17 AM, Luis R. Rodriguez > <lrodriguez@atheros.com> wrote: > > On Wed, Apr 6, 2011 at 5:23 AM, Christian Lamparter > > <chunkeey@googlemail.com> wrote: > >> On Wednesday 06 April 2011 05:26:28 Joe Culler wrote: > >>> [...] > >>> I have a problem with carl9170 driver with my d-link dwa-160 under > >>> linux-2.6.39-rc1. > >>> Here's the dmesg: > >> > >>> [ 3114.257063] ath: EEPROM regdomain: 0x5c > >>> [ 3114.257066] ath: EEPROM indicates we should expect a direct regpair map > >>> [ 3114.257069] ath: invalid regulatory domain/country code 0x5c > >>> [ 3114.257071] ath: Invalid EEPROM contents > >> clearly, the regdomain code 0x5c is not defined in the > >> drivers/net/wireless/ath/regd_common.h => regDomainPairs struct. > >> > >> this would be easy to fix [see attached patch], however I'm > >> not quite sure what to do about the 5GHz band in this case, > >> since the CTL_FCC is more restrictive than it should be. > >> > >> Regards, > >> Chr > >> > >> --- > >> diff --git a/drivers/net/wireless/ath/regd_common.h b/drivers/net/wireless/ath/regd_common.h > >> index 248c670..5c2cfe6 100644 > >> --- a/drivers/net/wireless/ath/regd_common.h > >> +++ b/drivers/net/wireless/ath/regd_common.h > >> @@ -195,6 +195,7 @@ static struct reg_dmn_pair_mapping regDomainPairs[] = { > >> {APL9_WORLD, CTL_ETSI, CTL_ETSI}, > >> > >> {APL3_FCCA, CTL_FCC, CTL_FCC}, > >> + {APL7_FCCA, CTL_FCC, CTL_FCC}, > >> {APL1_ETSIC, CTL_FCC, CTL_ETSI}, > >> {APL2_ETSIC, CTL_FCC, CTL_ETSI}, > >> {APL2_APLD, CTL_FCC, NO_CTL}, > > > > I verified internally with our other code and this is correct, APL7 > > maps to FCC CTL and FCCA maps to FCC CTL as well. For an upstream > > patch: > > > > Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com> > > Oh and please Cc stable@kernel.org, thanks a lot! ...and don't forget the Signed-off-by... -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH -stable] ath: add missing regdomain pair 0x5c mapping 2011-04-06 17:17 ` Luis R. Rodriguez 2011-04-06 17:18 ` John W. Linville @ 2011-04-06 18:40 ` Christian Lamparter 1 sibling, 0 replies; 6+ messages in thread From: Christian Lamparter @ 2011-04-06 18:40 UTC (permalink / raw) To: Luis R. Rodriguez, linville; +Cc: Joe Culler, linux-wireless Joe Culler reported a problem with his AR9170 device: > ath: EEPROM regdomain: 0x5c > ath: EEPROM indicates we should expect a direct regpair map > ath: invalid regulatory domain/country code 0x5c > ath: Invalid EEPROM contents It turned out that the regdomain 'APL7_FCCA' was not mapped yet. According to Luis R. Rodriguez [Atheros' engineer] APL7 maps to FCC_CTL and FCCA maps to FCC_CTL as well, so the attached patch should be correct. Cc: <stable@kernel.org> Reported-by: Joe Culler <joe.culler@gmail.com> Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com> Signed-off-by: Christian Lamparter <chunkeey@googlemail.com> --- Joe, does this patch fix your problem? If so, can you please reply with a "tested-by:" tag? Regards, Christian --- diff --git a/drivers/net/wireless/ath/regd_common.h b/drivers/net/wireless/ath/regd_common.h index 248c670..5c2cfe6 100644 --- a/drivers/net/wireless/ath/regd_common.h +++ b/drivers/net/wireless/ath/regd_common.h @@ -195,6 +195,7 @@ static struct reg_dmn_pair_mapping regDomainPairs[] = { {APL9_WORLD, CTL_ETSI, CTL_ETSI}, {APL3_FCCA, CTL_FCC, CTL_FCC}, + {APL7_FCCA, CTL_FCC, CTL_FCC}, {APL1_ETSIC, CTL_FCC, CTL_ETSI}, {APL2_ETSIC, CTL_FCC, CTL_ETSI}, {APL2_APLD, CTL_FCC, NO_CTL}, ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: invalid regdomain: 0x5c (was: problem with D-Link DWA-160) 2011-04-06 12:23 ` invalid regdomain: 0x5c (was: problem with D-Link DWA-160) Christian Lamparter 2011-04-06 17:17 ` Luis R. Rodriguez @ 2011-04-08 0:41 ` Joe Culler 1 sibling, 0 replies; 6+ messages in thread From: Joe Culler @ 2011-04-08 0:41 UTC (permalink / raw) To: Christian Lamparter Cc: linux-wireless, Michael Green, Luis R. Rodriguez, David Quan Hello Christian, Your patch works for me, thanks. Tested-by: Joe Culler On Wed, Apr 6, 2011 at 8:23 PM, Christian Lamparter wrote: > On Wednesday 06 April 2011 05:26:28 Joe Culler wrote: >> [...] >> I have a problem with carl9170 driver with my d-link dwa-160 under >> linux-2.6.39-rc1. >> Here's the dmesg: > >> [ 3114.257063] ath: EEPROM regdomain: 0x5c >> [ 3114.257066] ath: EEPROM indicates we should expect a direct regpair map >> [ 3114.257069] ath: invalid regulatory domain/country code 0x5c >> [ 3114.257071] ath: Invalid EEPROM contents > clearly, the regdomain code 0x5c is not defined in the > drivers/net/wireless/ath/regd_common.h => regDomainPairs struct. > > this would be easy to fix [see attached patch], however I'm > not quite sure what to do about the 5GHz band in this case, > since the CTL_FCC is more restrictive than it should be. > > Regards, > Chr > > --- > diff --git a/drivers/net/wireless/ath/regd_common.h b/drivers/net/wireless/ath/regd_common.h > index 248c670..5c2cfe6 100644 > --- a/drivers/net/wireless/ath/regd_common.h > +++ b/drivers/net/wireless/ath/regd_common.h > @@ -195,6 +195,7 @@ static struct reg_dmn_pair_mapping regDomainPairs[] = { > {APL9_WORLD, CTL_ETSI, CTL_ETSI}, > > {APL3_FCCA, CTL_FCC, CTL_FCC}, > + {APL7_FCCA, CTL_FCC, CTL_FCC}, > {APL1_ETSIC, CTL_FCC, CTL_ETSI}, > {APL2_ETSIC, CTL_FCC, CTL_ETSI}, > {APL2_APLD, CTL_FCC, NO_CTL}, > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-08 0:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <BANLkTinLdpaS9GLN88ObSACbmQJOK7wnug@mail.gmail.com>
2011-04-06 12:23 ` invalid regdomain: 0x5c (was: problem with D-Link DWA-160) Christian Lamparter
2011-04-06 17:17 ` Luis R. Rodriguez
2011-04-06 17:17 ` Luis R. Rodriguez
2011-04-06 17:18 ` John W. Linville
2011-04-06 18:40 ` [PATCH -stable] ath: add missing regdomain pair 0x5c mapping Christian Lamparter
2011-04-08 0:41 ` invalid regdomain: 0x5c (was: problem with D-Link DWA-160) Joe Culler
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).