From: Arik Nemtsov <arik@wizery.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Luciano Coelho <coelho@ti.com>
Subject: Re: [RFC] mac80211: reestablish mis-configured existing Rx BA sessions
Date: Tue, 17 May 2011 16:01:52 +0300 [thread overview]
Message-ID: <BANLkTinB3fNDxQr+O4DaUpAiV4f2RXM4Tg@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=S1X1RRaeNmqAoqugoB-dByDsaSQ@mail.gmail.com>
On Thu, May 5, 2011 at 02:17, Arik Nemtsov <arik@wizery.com> wrote:
> On Thu, May 5, 2011 at 02:15, Arik Nemtsov <arik@wizery.com> wrote:
>>
>>
>> On Wed, May 4, 2011 at 19:50, Johannes Berg <johannes@sipsolutions.net>
>> wrote:
>>>
>>> On Tue, 2011-05-03 at 12:12 +0300, Arik Nemtsov wrote:
>>> > When forming a Rx BA session, sometimes the ADDBA response gets lost.
>>> > This leads to a situation where the session is configured locally, but
>>> > doesn't exist on the remote side. Subsequent ADDBA requests are declined
>>> > by mac80211.
>>> >
>>> > Fix this by assuming the session state of the initiator is the correct
>>> > one. When receiving an unexpected ADDBA request on a TID with an active
>>> > Rx BA session, delete the existing one and establish a new session.
>>>
>>> I thought about this for a while but I don't really have an opinion I
>>> think. Maybe the behaviour could be avoided by checking the ack status,
>>> but that wouldn't be good enough for devices that don't have that...
>>
>> It helped me with at least two APs (when I put them far enough from the
>> station). I guess it won't hurt anything.
>> Checking the ack won't do any actual good - if the AP doesn't send another
>> ADDBA request we won't have a session up anyway. It just saves a little
>> memory on the reorder buffer.
>> Arik
>
> [replying again with a plain text email]
>
ping?
prev parent reply other threads:[~2011-05-17 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 9:12 [RFC] mac80211: reestablish mis-configured existing Rx BA sessions Arik Nemtsov
2011-05-04 16:50 ` Johannes Berg
[not found] ` <BANLkTinB7cAmCahuK-qqejVWzO7T3Xq4Gg@mail.gmail.com>
2011-05-04 23:17 ` Arik Nemtsov
2011-05-17 13:01 ` Arik Nemtsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinB3fNDxQr+O4DaUpAiV4f2RXM4Tg@mail.gmail.com \
--to=arik@wizery.com \
--cc=coelho@ti.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).