Re: mesh RCU issues

[Javier Cardona <javier@cozybit.com>]

Johannes,

On Thu, May 12, 2011 at 5:25 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> I was reviewing sparse RCU warnings in mac80211...
>
> This seems to be some kind of bad joke:
>
> void mesh_path_timer(unsigned long data)
> {
>        struct ieee80211_sub_if_data *sdata;
>        struct mesh_path *mpath;
>
>        rcu_read_lock();
>        mpath = (struct mesh_path *) data;
>        mpath = rcu_dereference(mpath);
>        if (!mpath)
>                goto endmpathtimer;
>
> ????

Thanks for cleaning that up.

> And indeed I don't see a del_timer_sync() when the mesh path is freed.

Isn't the call to del_timer_sync() you are looking for in
mesh_path_node_reclaim() ?

> But this is _clearly_ totally bogus. Somebody please fix ASAP.

I'll run sparse and see if I see other rcu warnings that I can fix.

Thanks,

j


> johannes
>
>



-- 
Javier Cardona
cozybit Inc.
http://www.cozybit.com