From: "Rafał Miłecki" <zajec5@gmail.com>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH 2/9] b43: add bus device abstraction layer
Date: Wed, 18 May 2011 09:49:10 +0200 [thread overview]
Message-ID: <BANLkTinLFGzjFOtXZe1Zk2_jLjj2ZZVCrg@mail.gmail.com> (raw)
In-Reply-To: <BANLkTinaPMr-owT31e5hbRVKBad_u9XbUw@mail.gmail.com>
W dniu 18 maja 2011 09:21 użytkownik Julian Calaby
<julian.calaby@gmail.com> napisał:
> 2011/5/18 Rafał Miłecki <zajec5@gmail.com>:
>> W dniu 18 maja 2011 02:28 użytkownik Julian Calaby
>> <julian.calaby@gmail.com> napisał:
>>> Rafał,
>>>
>>> A quick question:
>>>
>>> 2011/5/18 Rafał Miłecki <zajec5@gmail.com>:
>>>>
>>>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>>>> ---
>>>> drivers/net/wireless/b43/Makefile | 1 +
>>>> drivers/net/wireless/b43/b43.h | 4 +++-
>>>> drivers/net/wireless/b43/bus.c | 36 ++++++++++++++++++++++++++++++++++++
>>>
>>> Would it make more sense to have this be called ssb.c as it contains
>>> all the ssb specific functions,
>>
>> It's only ssb specific for now. It will contain BCMA code later.
>>
>>
>>> that way you can then have an brcma.c
>>> file to contain the functions specific to that bus?
>>
>> I'll put BCMA specific code in bus.c.
>> Right now bus.c contains 100 LOC* and I believe its SSB part is
>> complete. All the ops functions are one liners. It's so small and
>> simple file I don't see sense to splitting it and having more mess in
>> list of files instead.
>
> As I see it, having two sets of mostly identical wrapper functions in
> a file seems incorrect to me. Especially as once the abstraction is
> complete it would technically be correct to build b43 without SSB
> support - it's much cleaner to not compile a file than have a massive
> #ifdef block in a common file.
>
> Anyway, it's only a minor thing.
Massive? It's *one* ifdef for one bus type in this file.
>> A one quick question:
>> Why didn't you respond in "[RFC][PATCH] b43: add bus abstraction
>> layer" on 2011-04-08? Or more recent "[RFC ONLY 2/5] b43: add bus
>> device abstraction later" posted on 2011-05-09?
>
> While I try to read every patch that passes through the linux-wireless
> mailing list, I only skim them, and tend to miss some details. The
> thing that prompted this comment was the SSB comment at the start of
> the SSB specific wrappers - something I probably didn't read the last
> two times the patch came up on the list.
OK, I ask because it's much easier to discuss such a things before you
got 20 patches. That's why I posted very early RFC.
--
Rafał
next prev parent reply other threads:[~2011-05-18 7:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 0:06 [PATCH 1/9] b43: rename ssb_device variable in ssb specific functions Rafał Miłecki
2011-05-18 0:06 ` [PATCH 2/9] b43: add bus device abstraction layer Rafał Miłecki
2011-05-18 0:28 ` Julian Calaby
2011-05-18 7:01 ` Rafał Miłecki
2011-05-18 7:21 ` Julian Calaby
2011-05-18 7:49 ` Rafał Miłecki [this message]
2011-05-18 12:26 ` Julian Calaby
2011-05-18 0:06 ` [PATCH 3/9] b43: bus: abstract R/W operations Rafał Miłecki
2011-05-18 0:06 ` [PATCH 4/9] b43: bus: abstract 80211 core info Rafał Miłecki
2011-05-18 0:06 ` [PATCH 5/9] b43: bus: abstract SPROM Rafał Miłecki
2011-05-18 0:06 ` [PATCH 6/9] b43: bus: abstract device structs and irq Rafał Miłecki
2011-05-18 0:06 ` [PATCH 7/9] b43: bus: abstract chip info Rafał Miłecki
2011-05-18 0:06 ` [PATCH 8/9] b43: bus: abstract board info Rafał Miłecki
2011-05-18 0:06 ` [PATCH 9/9] b43: bus: abstract bus and core operations Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinLFGzjFOtXZe1Zk2_jLjj2ZZVCrg@mail.gmail.com \
--to=zajec5@gmail.com \
--cc=b43-dev@lists.infradead.org \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).