From: Eliad Peller <eliad@wizery.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Luciano Coelho <coelho@ti.com>, linux-wireless@vger.kernel.org
Subject: Re: [RFC/PATCH 03/13] net: wl12xx: remove some unnecessary prints
Date: Sun, 22 May 2011 15:34:33 +0300 [thread overview]
Message-ID: <BANLkTinPipSVdsH5cTb24HKex_h7pOwpAg@mail.gmail.com> (raw)
In-Reply-To: <1305321990-22041-4-git-send-email-balbi@ti.com>
On Sat, May 14, 2011 at 12:26 AM, Felipe Balbi <balbi@ti.com> wrote:
> Those have little value. Remove those to make
> the driver less noisy.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
[...]
> @@ -287,8 +287,6 @@ static int __devinit wl1271_probe(struct sdio_func *func,
> /* Tell PM core that we don't need the card to be powered now */
> pm_runtime_put_noidle(&func->dev);
>
> - wl1271_notice("initialized");
> -
> return 0;
>
> static void __exit wl1271_exit(void)
> {
> sdio_unregister_driver(&wl1271_sdio_driver);
> -
> - wl1271_notice("unloaded");
> }
>
in fact, i find these prints pretty useful.
does changing wl1271_notice to wl1271_debug(DEBUG_MAC80211) will solve
the "nosiness"?
(i use DEBUG_MAC80211 rather than DEBUG_SDIO, as DEBUG_SDIO is really
*very* noisy)
(i'll send it as a new patch as the original patch was already applied)
Eliad.
next prev parent reply other threads:[~2011-05-22 12:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 21:26 [RFC/PATCH 00/13] wl12xx re-factor Felipe Balbi
2011-05-13 21:26 ` [RFC/PATCH 01/13] net: wl12xx: sdio: id_tables should be __devinitconst Felipe Balbi
2011-05-20 12:02 ` Luciano Coelho
2011-05-20 16:02 ` Ohad Ben-Cohen
2011-05-20 16:14 ` Michał Mirosław
2011-05-13 21:26 ` [RFC/PATCH 02/13] net: wl12xx: sdio: add a context structure Felipe Balbi
2011-05-13 21:26 ` [RFC/PATCH 03/13] net: wl12xx: remove some unnecessary prints Felipe Balbi
2011-05-20 12:03 ` Luciano Coelho
2011-05-22 12:34 ` Eliad Peller [this message]
2011-05-22 12:37 ` Eliad Peller
2011-05-22 17:30 ` Luciano Coelho
2011-05-22 21:57 ` Eliad Peller
2011-05-23 5:32 ` Luciano Coelho
2011-05-23 6:07 ` Felipe Balbi
2011-05-13 21:26 ` [RFC/PATCH 04/13] net: wl12xx: care for optional operations Felipe Balbi
2011-05-20 12:03 ` Luciano Coelho
2011-05-13 21:26 ` [RFC/PATCH 05/13] net: wl12xx: remove the nops Felipe Balbi
2011-05-20 12:04 ` Luciano Coelho
2011-05-13 21:26 ` [RFC/PATCH 06/13] net: wl12xx: remove unnecessary prints Felipe Balbi
2011-05-20 12:04 ` Luciano Coelho
2011-05-13 21:26 ` [RFC/PATCH 07/13] net: wl12xx: spi: add a context structure Felipe Balbi
2011-05-13 21:26 ` [RFC/PATCH 08/13] net: wl12xx: spi: add a platform_device Felipe Balbi
2011-05-13 21:26 ` [RFC/PATCH 09/13] net: wl12xx: sdio: " Felipe Balbi
2011-05-13 21:26 ` [RFC/PATCH 10/13] net: wl12xx: main: add platform device Felipe Balbi
2011-05-13 21:26 ` [RFC/PATCH 11/13] net: wireless: wl12xx: re-factor all drivers Felipe Balbi
2011-05-13 21:26 ` [RFC/PATCH 12/13] net: wireless: wl12xx: mark some symbols static Felipe Balbi
2011-05-13 21:26 ` [RFC/PATCH 13/13] net: wl12xx: main: drop unneded plat_dev Felipe Balbi
2011-05-19 12:49 ` [RFC/PATCH 00/13] wl12xx re-factor Luciano Coelho
2011-05-19 14:06 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinPipSVdsH5cTb24HKex_h7pOwpAg@mail.gmail.com \
--to=eliad@wizery.com \
--cc=balbi@ti.com \
--cc=coelho@ti.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).