From: "Rafał Miłecki" <zajec5@gmail.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] bcma: pci: implement enabling interrupts
Date: Wed, 18 May 2011 13:26:23 +0200 [thread overview]
Message-ID: <BANLkTinW=kfg2ONuA5NzmNbSAHUbUVOiRg@mail.gmail.com> (raw)
In-Reply-To: <4DD3A1CD.3040304@broadcom.com>
W dniu 18 maja 2011 12:39 użytkownik Arend van Spriel
<arend@broadcom.com> napisał:
> On 05/18/2011 12:58 PM, Rafał Miłecki wrote:
>>
>> Signed-off-by: Rafał Miłecki<zajec5@gmail.com>
>> ---
>> drivers/bcma/driver_pci.c | 18 ++++++++++++++++++
>> 1 files changed, 18 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/bcma/driver_pci.c b/drivers/bcma/driver_pci.c
>> index e757e4e..879fe1d 100644
>> --- a/drivers/bcma/driver_pci.c
>> +++ b/drivers/bcma/driver_pci.c
>> @@ -161,3 +161,21 @@ void bcma_core_pci_init(struct bcma_drv_pci *pc)
>> {
>> bcma_pcicore_serdes_workaround(pc);
>> }
>> +
>> +int bcma_core_pci_irq_enable(struct bcma_drv_pci *pc, struct bcma_device
>> *core)
>> +{
>> + struct pci_dev *pdev = pc->core->bus->host_pci;
>> + u32 coremask, tmp;
>> + int err;
>> +
>> + coremask = BIT(core->core_index);
>> +
>> + err = pci_read_config_dword(pdev, BCMA_PCI_IRQMASK,&tmp);
>> + if (err)
>> + goto out;
>> + tmp |= coremask<< 8;
>> + err = pci_write_config_dword(pdev, BCMA_PCI_IRQMASK, tmp);
>> +
>> +out:
>> + return err;
>> +}
>
> Hi Rafał,
>
> Do you intend to have a disable as well?
Sure. I just didn't test disabling function yet, that's why I didn't publish it.
--
Rafał
next prev parent reply other threads:[~2011-05-18 11:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 10:58 [PATCH] bcma: pci: implement enabling interrupts Rafał Miłecki
2011-05-18 10:39 ` Arend van Spriel
2011-05-18 11:26 ` Rafał Miłecki [this message]
2011-05-18 11:31 ` Arend van Spriel
2011-05-18 22:30 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTinW=kfg2ONuA5NzmNbSAHUbUVOiRg@mail.gmail.com' \
--to=zajec5@gmail.com \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).