From: Daniel Halperin <dhalperi@cs.washington.edu>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC ] wireless: Support can-scan-one logic.
Date: Tue, 10 May 2011 12:59:30 -0700 [thread overview]
Message-ID: <BANLkTinngCnqYOtbt8+X8u2xMp5kApOvwA@mail.gmail.com> (raw)
In-Reply-To: <1305057374-9875-1-git-send-email-greearb@candelatech.com>
See inline
On Tue, May 10, 2011 at 12:56 PM, <greearb@candelatech.com> wrote:
>
> +
> + /*
> + printk("start_sw_scan, can_scan_one: %i n_channels: %i\n",
> + local->scan_req->can_scan_one, local->scan_req->n_channels);
> + WARN_ON(!local->scan_req->can_scan_one);
> + */
Remove the debug print?
> +
> + /* If one sta is associated, we don't want another to start
> + * scanning on all channels, as that will interfere with the
> + * one already associated.
> + */
Comment style is wrong.
>
> + /* Special hack: channel -1 means 'scan only active
> + * channel if any VIFs on this device are associated
> + * on the channel.
> + */
Same.
>
> + /* If at least one VIF on this hardware is already associated, then
> + * only scan on the active channel.
> + */
Same.
Dan
next prev parent reply other threads:[~2011-05-10 19:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 19:56 [RFC ] wireless: Support can-scan-one logic greearb
2011-05-10 19:58 ` Ben Greear
2011-05-10 19:59 ` Daniel Halperin [this message]
2011-05-10 20:06 ` Ben Greear
2011-05-12 8:26 ` Johannes Berg
2011-05-12 16:43 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinngCnqYOtbt8+X8u2xMp5kApOvwA@mail.gmail.com \
--to=dhalperi@cs.washington.edu \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).