From: Matteo Croce <matteo@openwrt.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] 802.11n frame injection
Date: Sun, 15 May 2011 00:07:07 +0200 [thread overview]
Message-ID: <BANLkTinp0Hy3yhfxAEAX9jeKSaYRMddDew@mail.gmail.com> (raw)
In-Reply-To: <1305133583.17892.3.camel@jlt3.sipsolutions.net>
2011/5/11 Johannes Berg <johannes@sipsolutions.net>:
> On Fri, 2011-04-22 at 18:34 +0200, Matteo Croce wrote:
>
>> --- a/net/mac80211/status.c 2011-04-22 11:34:08.833135198 +0200
>> +++ b/net/mac80211/status.c 2011-04-22 11:34:54.037135187 +0200
>> @@ -405,6 +405,19 @@
>> !(info->status.rates[0].flags & IEEE80211_TX_RC_MCS))
>> rthdr->rate = sband->bitrates[
>> info->status.rates[0].idx].bitrate / 5;
>> + /* HT rates */
>> + if (info->status.rates[0].flags & IEEE80211_TX_RC_MCS) {
>> + rthdr->hdr.it_present |= cpu_to_le32(1 << IEEE80211_RADIOTAP_MCS);
>> + rthdr->rate = 0;
>> + rthdr->ht_known = IEEE80211_RADIOTAP_MCS_HAVE_BW |
>> + IEEE80211_RADIOTAP_MCS_HAVE_MCS |
>> + IEEE80211_RADIOTAP_MCS_HAVE_GI;
>> + rthdr->ht_mcs = info->status.rates[0].idx;
>> + if (info->status.rates[0].flags & IEEE80211_TX_RC_40_MHZ_WIDTH)
>> + rthdr->ht_flag |= IEEE80211_RADIOTAP_MCS_BW_40;
>> + if (info->status.rates[0].flags & IEEE80211_TX_RC_SHORT_GI)
>> + rthdr->ht_flag |= IEEE80211_RADIOTAP_MCS_SGI;
>> + }
>
> I think you should also split the patch -- this part isn't really only
> injection.
>
> johannes
>
>
After injecting a frame I have a TX feedback, why shouldn't it have
correct MCS informations?
--
Matteo Croce
OpenWrt Developer
_______ ________ __
| |.-----.-----.-----.| | | |.----.| |_
| - || _ | -__| || | | || _|| _|
|_______|| __|_____|__|__||________||__| |____|
|__| W I R E L E S S F R E E D O M
ATTITUDE ADJUSTMENT (bleeding edge) --------------
* 1/4 oz Vodka Pour all ingredents into mixing
* 1/4 oz Gin tin with ice, strain into glass.
* 1/4 oz Amaretto
* 1/4 oz Triple sec
* 1/4 oz Peach schnapps
* 1/4 oz Sour mix
* 1 splash Cranberry juice
-----------------------------------------------------
next prev parent reply other threads:[~2011-05-14 22:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 16:34 [PATCH v2] 802.11n frame injection Matteo Croce
2011-04-24 8:15 ` Johannes Berg
2011-04-24 19:14 ` Maxim Levitsky
2011-04-24 20:42 ` Matteo Croce
2011-05-11 16:49 ` John W. Linville
2011-05-11 17:06 ` Johannes Berg
2011-05-14 22:07 ` Matteo Croce [this message]
2011-05-18 22:49 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinp0Hy3yhfxAEAX9jeKSaYRMddDew@mail.gmail.com \
--to=matteo@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).