From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:36457 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708Ab1F0OJW convert rfc822-to-8bit (ORCPT ); Mon, 27 Jun 2011 10:09:22 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 27 Jun 2011 16:09:21 +0200 Message-ID: (sfid-20110627_160952_413347_9AC94A3E) Subject: Re: [PATCH -next] bcma: main.c needs to include From: Geert Uytterhoeven To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: linux-wireless@vger.kernel.org, linux-next@vger.kernel.org, Linux Kernel Development Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2011/6/27 Rafał Miłecki : > 2011/6/26 Geert Uytterhoeven : >> m68k allmodconfig: >> >> drivers/bcma/main.c: In function ‘bcma_release_core_dev’: >> drivers/bcma/main.c:68: error: implicit declaration of function ‘kfree’ > > We already include slab.h in: > host_pci.c > scan.c > sprom.c > > Maybe we can just include this in bcma.h as a better solution? We > could drop other includes then. > Can you submit patch for this? If bcma.h doesn't use linux/slab.h, IMHO it should not include linux/slab.h. Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds