From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 289AA14A0AB for ; Tue, 4 Jun 2024 23:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717544107; cv=none; b=IAqUwDOx9vR8pryLL0ETaRMWkL4nF5RDUUX4x7bPGWqRwZdwTc6JihlRcPLLIv9je7w60YBNUP4dqGHrt/0w8agtOFjV/E7W39KvGew5Jdvz+C2lQFNsYOZIaXsWRXA/+hNiHS1lHJLBLQb3zOk5CU4iEdyfwJGDrtJcK5eMImA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717544107; c=relaxed/simple; bh=ljUZwH0wfZx09w13YocP3uzPKY+TNatl/gsxBoW/3SE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=pmeyR1q/JuPcktgVem9/G8WfhndvLnpjKP8i75InK72bjOF4MUJJF+uepttrOureS3ibrSB++AA1UUtQgZqa3JzY6LSmgFfdtu4+xG7nZPSdOyWwW2qsIS8n1Ix3Gt/6yoZlxxmGBjwwDd9gjvwwaVzO/k9WdEc4zv4wrkq3Zqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ypqfFRu+; arc=none smtp.client-ip=209.85.219.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ypqfFRu+" Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-dfa71ded97bso313553276.1 for ; Tue, 04 Jun 2024 16:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717544104; x=1718148904; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=U5F59Y5F210ARWzU6IxQVbEufFPE5a5xbmD+TtWexxk=; b=ypqfFRu+uPKXPjMQPgBOuDv7GombmJURsrNzvb1dhGyJL++QPuKNJMwtjg7mzX2AGO EpJEE5DgnWwRbsoAbNI5wz4OPG1sEnjRhFT0XnPgxPWcjCEj3pZoXjhI6otg8UvBHBYO xl7w8Dcmya++BneGdZupinvOiyoHiLazgcFy+i1VS0V1rLcOMnh0f53A4K0rGqFAB1Ut xQlM465D31D1Jx6qDraao/DDsh5dKo0pArqVwUWIfXHPmkJeAmWgQWe/LfNLRmzsz4al rwFDPwRo2zLhMz6Ho4YTCJM+GDISJ87GtkipLCy4iQwWlfly7cXr8iDr1MiZo5t1Ofly jpwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717544104; x=1718148904; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U5F59Y5F210ARWzU6IxQVbEufFPE5a5xbmD+TtWexxk=; b=HWbzOZkc/VNAX0I5S0Dtjb0LCQG5ntrg8RD3smDcxh16voVzPTTSx3TI6RMpWs/Jr2 LQCCwXxzMBNU/NE7YVGHCyZHZESMJqZkAFsRbzjSWA8bFVn5kh7uUtS4kNvEOB8i5lea rF4vi0nu9XgoXfk1/6TdBnj+6zaCw0arxR16DB64/UPrwN3l7gESizSLNIj60LI3tkK+ GtnUWE97P0K1ZXmdSLaJfWFwRRMVZY12UF73CvHAVVKAbxhgJnV+L0uYxt5SrTD9/Faj eHeKH3pCB/fWZ35v3X8TcH9YT6fImLTrhqoEPOOjojDvstwPuNes0/RJTucGLpfy/1dj 6wkg== X-Forwarded-Encrypted: i=1; AJvYcCUx+PqoY73rMRWmZeWodQb+DsdUwa2buPTi4nWgH2+b73onSCBQp30Zx3VMtzO5b6GmQjVPvwEquTHs2mTg8Df8pOBFRFh7fpJ84JIAqZQ= X-Gm-Message-State: AOJu0YzCAWR0uyDg0i4RjE7qUnzgh52EJpCU5R5UFsqoFLrxtTSP8Y36 24/n53DWC+gdcYheIlLFuEGpk2ftFjmkXBv7YAUOjPGXUxOaT/hM/QzUDvQpuCfG/6ToZM8/tGa l9hlIq+z5wbgJaKmbHogkYvBEykAog1wLJg2ZbA== X-Google-Smtp-Source: AGHT+IFdoTto+OyWazk/s95VUduCXVBIPATg60NiVpHEaONaANNsRtZaVqiKS3evRYjowXOhqIkWoq2TlII04CwtgN4= X-Received: by 2002:a25:dcd0:0:b0:dfa:48d9:b0 with SMTP id 3f1490d57ef6-dfab8b0312fmr3125447276.22.1717544104107; Tue, 04 Jun 2024 16:35:04 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240528-pwrseq-v8-16-d354d52b763c@linaro.org> <20240604232347.GA740032@bhelgaas> In-Reply-To: <20240604232347.GA740032@bhelgaas> From: Dmitry Baryshkov Date: Wed, 5 Jun 2024 02:34:52 +0300 Message-ID: Subject: Re: [PATCH v8 16/17] PCI/pwrctl: add a PCI power control driver for power sequenced devices To: Bjorn Helgaas Cc: Bartosz Golaszewski , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marcel Holtmann , Luiz Augusto von Dentz , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Balakrishna Godavarthi , Rocky Liao , Kalle Valo , Jeff Johnson , Bjorn Andersson , Konrad Dybcio , Bjorn Helgaas , Srini Kandagatla , Elliot Berman , Caleb Connolly , Neil Armstrong , Alex Elder , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, Jeff Johnson , ath12k@lists.infradead.org, linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, Bartosz Golaszewski , kernel@quicinc.com, Amit Pundir Content-Type: text/plain; charset="UTF-8" On Wed, 5 Jun 2024 at 02:23, Bjorn Helgaas wrote: > > On Tue, May 28, 2024 at 09:03:24PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Add a PCI power control driver that's capable of correctly powering up > > devices using the power sequencing subsystem. The first users of this > > driver are the ath11k module on QCA6390 and ath12k on WCN7850. > > Can you add a little detail here about what benefit we will see from > this driver? E.g., something that doesn't work correctly now, but > will work with this driver? > > > +static const struct of_device_id pci_pwrctl_pwrseq_of_match[] = { > > + { > > + /* ATH11K in QCA6390 package. */ > > + .compatible = "pci17cb,1101", > > + .data = "wlan", > > + }, > > + { > > + /* ATH12K in WCN7850 package. */ > > + .compatible = "pci17cb,1107", > > + .data = "wlan", > > + }, > > IIUC, "pci17cb,1101" and "pci17cb,1107" exist partly so we can check > that a DTS conforms to the schema, e.g., a "pci17cb,1101" node > contains all the required regulators. For that use, we obviously need > a very specific "compatible" string. > > Is there any opportunity to add a more generic "compatible" string in > addition to those so this list doesn't have to be updated for every > PMU? The .data here is "wlan" in both cases, and for this purpose, we > don't care whether it's "pci17cb,1101" or "pci17cb,1107". These two devices have different set of regulators and different requirements to power them on. -- With best wishes Dmitry