From: Bartosz Markowski <bartosz.markowski@tieto.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] ath10k: remove P2P from supported interface modes for 10.X FW
Date: Mon, 21 Oct 2013 08:52:54 +0200 [thread overview]
Message-ID: <CACKGw+GgYwu-oQ12LjPm3FLKQ5PDG+KUVgoEM=KGH8q+SWvmBQ@mail.gmail.com> (raw)
In-Reply-To: <87mwm3uoep.fsf@kamboji.qca.qualcomm.com>
On 21 October 2013 08:30, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Bartosz Markowski <bartosz.markowski@tieto.com> writes:
>
>> FW 10.X does not support P2P, stop advertising it to mac80211.
>>
>> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
>
> [...]
>
>> @@ -3478,7 +3504,11 @@ int ath10k_mac_register(struct ath10k *ar)
>> */
>> ar->hw->queues = 4;
>>
>> - ar->hw->wiphy->iface_combinations = &ath10k_if_comb;
>> + if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features))
>> + ar->hw->wiphy->iface_combinations = &ath10k_10x_if_comb;
>> + else
>> + ar->hw->wiphy->iface_combinations = &ath10k_if_comb;
>
> I think it would be better to have a separate feature flag for this,
> like NO_P2P or something like that. Just in case we want to disable P2P
> in other firmware branches.
Make sense. I will change this.
--
Bartosz
prev parent reply other threads:[~2013-10-21 6:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 10:07 [PATCH 1/2] ath10k: remove P2P from supported interface modes for 10.X FW Bartosz Markowski
2013-10-18 10:07 ` [PATCH 2/2] ath10k: extend number of AP interfaces for 10.X firmware Bartosz Markowski
2013-10-21 6:31 ` Kalle Valo
2013-10-21 6:51 ` Bartosz Markowski
2013-10-21 6:30 ` [PATCH 1/2] ath10k: remove P2P from supported interface modes for 10.X FW Kalle Valo
2013-10-21 6:52 ` Bartosz Markowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACKGw+GgYwu-oQ12LjPm3FLKQ5PDG+KUVgoEM=KGH8q+SWvmBQ@mail.gmail.com' \
--to=bartosz.markowski@tieto.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).