From: "Rafał Miłecki" <zajec5@gmail.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: "Arend van Spriel" <arend.vanspriel@broadcom.com>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Pieter-Paul Giesberts" <pieter-paul.giesberts@broadcom.com>,
"Franky Lin" <frankyl@broadcom.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
<brcm80211-dev-list.pdl@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH RFC] brcmfmac: shutdown interfaces on PSM's watchdog fire
Date: Tue, 7 Mar 2017 15:38:23 +0100 [thread overview]
Message-ID: <CACna6ryvu-6j0s3VNbi2jAba=dsM3ERCfcUd34w=oC6VN_U4yQ@mail.gmail.com> (raw)
In-Reply-To: <87h9356wlf.fsf@purkki.adurom.net>
On 7 March 2017 at 14:32, Kalle Valo <kvalo@codeaurora.org> wrote:
> Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.com> writes:
>
>> From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>>
>> When PSM's watchdog fires hardware / firmware is not operational. It
>> seems there isn't a way to restart firmware & reapply all settings so
>> instead shut all interfaces down. This is at least some signal for the
>> user things went wrong and allows reacting to it.
>>
>> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>> ---
>> This patch is RFC as I'm wondering if there is any other way to handle
>> such errors. I couldn't find anything except for that
>> cfg80211_shutdown_all_interfaces.
>>
>> Unfortunately hostapd doesn't seem to react to this except for sth like:
>> Fri Feb 24 13:41:07 2017 daemon.notice hostapd: wlan0: INTERFACE-DISABLE=
D
>>
>> Shall we introduce some nl80211 even for such cases maybe?
>>
>> Or maybe I'm totally wrong and there is some simple way for a driver to
>> request reconfiguration of all interfaces?
>
> Did you notice this on your email:
>
> To: unlisted-recipients:; (no To-header on input)
I guess I should have put linux-wireless in To. Normally I put you,
but since it's RFC, I left it empty and it went like this.
Anyway I believe it still reached linux-wireless. So any comments on this? =
:)
--=20
Rafa=C5=82
prev parent reply other threads:[~2017-03-07 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 17:24 [PATCH RFC] brcmfmac: shutdown interfaces on PSM's watchdog fire Rafał Miłecki
2017-03-07 13:32 ` Kalle Valo
2017-03-07 14:38 ` Rafał Miłecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACna6ryvu-6j0s3VNbi2jAba=dsM3ERCfcUd34w=oC6VN_U4yQ@mail.gmail.com' \
--to=zajec5@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pieter-paul.giesberts@broadcom.com \
--cc=rafal@milecki.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).