From: Mohammed Shafi <shafi.wireless@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Catalin Marinas <catalin.marinas@arm.com>,
wireless <linux-wireless@vger.kernel.org>
Subject: Re: Suspicious RCU usage in mac80211
Date: Fri, 4 May 2012 20:05:59 +0530 [thread overview]
Message-ID: <CAD2nsn2xMg0oUwtzYbLTv1vjJSnyHnrvhvNSCQL-4qRJ4cLPUg@mail.gmail.com> (raw)
In-Reply-To: <4FA3DD87.7030004@lwfinger.net>
On Fri, May 4, 2012 at 7:15 PM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> On 05/04/2012 01:48 AM, Mohammed Shafi wrote:
>>
>> On Fri, May 4, 2012 at 12:10 PM, Mohammed Shafi
>> <shafi.wireless@gmail.com> wrote:
>>>
>>> Hi Larry,
>>>
>>> On Fri, May 4, 2012 at 11:47 AM, Larry Finger<Larry.Finger@lwfinger.net>
>>> wrote:
>>>>
>>>> On 05/03/2012 01:38 PM, Johannes Berg wrote:
>>>>>
>>>>>
>>>>> diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c
>>>>> index 5b7053c..40d3ff4 100644
>>>>> --- a/net/mac80211/agg-tx.c
>>>>> +++ b/net/mac80211/agg-tx.c
>>>>> @@ -421,16 +421,22 @@ static void
>>>>> sta_tx_agg_session_timer_expired(unsigned long data)
>>>>> struct tid_ampdu_tx *tid_tx;
>>>>> unsigned long timeout;
>>>>>
>>>>> - tid_tx = rcu_dereference_protected_tid_tx(sta, *ptid);
>>>>> - if (!tid_tx)
>>>>> + rcu_read_lock();
>>>>> + tid_tx = rcu_dereference(sta->ampdu_mlme.tid_tx[*ptid]);
>>
>>
>> Larry, Johannes seems to use rcu_dereference straight way just like in
>> 'sta_addba_resp_timer_expired'
>> and have it protected by rcu_read_locks
>
>
> Sorry. I missed that subtle difference. Submitted "from Johannes".
no problem thanks! yeah but it seems my gmail seems to be identify those
changes!!
--
thanks,
shafi
next prev parent reply other threads:[~2012-05-04 14:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 3:19 Suspicious RCU usage in mac80211 Larry Finger
2012-04-12 3:31 ` Johannes Berg
2012-04-12 3:51 ` Larry Finger
2012-04-12 3:54 ` Johannes Berg
2012-04-12 15:51 ` Larry Finger
2012-04-12 15:55 ` Johannes Berg
2012-05-01 14:25 ` Mohammed Shafi
2012-05-01 19:18 ` Larry Finger
2012-05-02 5:02 ` Mohammed Shafi
2012-05-02 10:00 ` Catalin Marinas
2012-05-02 17:07 ` Johannes Berg
2012-05-02 20:09 ` Paul E. McKenney
2012-05-03 18:38 ` Johannes Berg
2012-05-04 6:17 ` Larry Finger
2012-05-04 6:40 ` Mohammed Shafi
2012-05-04 6:48 ` Mohammed Shafi
2012-05-04 13:45 ` Larry Finger
2012-05-04 14:35 ` Mohammed Shafi [this message]
2012-05-03 3:02 ` Larry Finger
2012-05-03 8:47 ` Catalin Marinas
2012-05-03 16:54 ` Larry Finger
2012-05-03 17:12 ` Paul E. McKenney
2012-05-03 17:46 ` Larry Finger
2012-05-03 18:22 ` Paul E. McKenney
2012-05-03 18:32 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD2nsn2xMg0oUwtzYbLTv1vjJSnyHnrvhvNSCQL-4qRJ4cLPUg@mail.gmail.com \
--to=shafi.wireless@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=catalin.marinas@arm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).