From: Eugene Krasnikov <k.eugene.e@gmail.com>
To: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Chun-Yeow Yeoh <yeohchunyeow@cozybit.com>
Subject: Re: [PATCH] wcn36xx: enable the beaconing in mesh mode
Date: Mon, 9 Dec 2013 07:23:07 +0000 [thread overview]
Message-ID: <CAFSJ42bGVnSZfMdHdOJCSVRaAkMB52poJVrAPy1wUx-+2AaYhg@mail.gmail.com> (raw)
In-Reply-To: <1386300482-3352-1-git-send-email-yeohchunyeow@gmail.com>
Looks good to me.
On Fri, Dec 6, 2013 at 3:28 AM, Chun-Yeow Yeoh <yeohchunyeow@gmail.com> wrote:
> Enable the beaconing in wnc36xx by tweaking the tim offset and
> force the use of AP-style beaconing. Otherwise, beaconing is not
> working. The tim offset is set to 256. Otherwise, this will
> overwrite mesh beacon submitted by mac80211.
>
> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@cozybit.com>
> ---
> drivers/net/wireless/ath/wcn36xx/smd.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> index f8c3a10..19f43de 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> @@ -1134,14 +1134,14 @@ int wcn36xx_smd_config_bss(struct wcn36xx *wcn, struct ieee80211_vif *vif,
> /* STA */
> bss->oper_mode = 1;
> bss->wcn36xx_hal_persona = WCN36XX_HAL_STA_MODE;
> - } else if (vif->type == NL80211_IFTYPE_AP) {
> + } else if (vif->type == NL80211_IFTYPE_AP ||
> + vif->type == NL80211_IFTYPE_MESH_POINT) {
> bss->bss_type = WCN36XX_HAL_INFRA_AP_MODE;
>
> /* AP */
> bss->oper_mode = 0;
> bss->wcn36xx_hal_persona = WCN36XX_HAL_STA_SAP_MODE;
> - } else if (vif->type == NL80211_IFTYPE_ADHOC ||
> - vif->type == NL80211_IFTYPE_MESH_POINT) {
> + } else if (vif->type == NL80211_IFTYPE_ADHOC) {
> bss->bss_type = WCN36XX_HAL_IBSS_MODE;
>
> /* STA */
> @@ -1291,7 +1291,11 @@ int wcn36xx_smd_send_beacon(struct wcn36xx *wcn, struct ieee80211_vif *vif,
> memcpy(msg_body.bssid, vif->addr, ETH_ALEN);
>
> /* TODO need to find out why this is needed? */
> - msg_body.tim_ie_offset = tim_off+4;
> + if (vif->type == NL80211_IFTYPE_MESH_POINT)
> + /* mesh beacon don't need this, so push further down */
> + msg_body.tim_ie_offset = 256;
> + else
> + msg_body.tim_ie_offset = tim_off+4;
> msg_body.p2p_ie_offset = p2p_off;
> PREPARE_HAL_BUF(wcn->hal_buf, msg_body);
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best regards,
Eugene
next prev parent reply other threads:[~2013-12-09 7:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 3:28 [PATCH] wcn36xx: enable the beaconing in mesh mode Chun-Yeow Yeoh
2013-12-09 7:23 ` Eugene Krasnikov [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-10-31 6:04 Chun-Yeow Yeoh
2013-10-31 20:30 ` Eugene Krasnikov
2013-11-01 4:14 ` Thomas Pedersen
[not found] ` <CAEFj984AojwciEHGvOisoYX8h_vG4TqZmJCXL6B_vpDYMbf9HQ@mail.gmail.com>
2013-11-01 13:45 ` Eugene Krasnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFSJ42bGVnSZfMdHdOJCSVRaAkMB52poJVrAPy1wUx-+2AaYhg@mail.gmail.com \
--to=k.eugene.e@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yeohchunyeow@cozybit.com \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).