* [PATCH 2/2] nfc: remove unneeded nfc_put_device() calls
@ 2014-04-02 7:56 Daeseok Youn
2014-04-14 2:19 ` DaeSeok Youn
0 siblings, 1 reply; 2+ messages in thread
From: Daeseok Youn @ 2014-04-02 7:56 UTC (permalink / raw)
To: davem, lauro.venancio
Cc: aloisio.almeida, sameo, linux-wireless, linux-nfc, netdev,
linux-kernel
If local is NULL, nfs_put_device() is called twice.
So nfs_put_device() in "if (!local)" is removed.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
net/nfc/netlink.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
index b2ad570..3e0a676 100644
--- a/net/nfc/netlink.c
+++ b/net/nfc/netlink.c
@@ -1038,7 +1038,6 @@ static int nfc_genl_llc_sdreq(struct sk_buff *skb, struct genl_info *info)
local = nfc_llcp_find_local(dev);
if (!local) {
- nfc_put_device(dev);
rc = -ENODEV;
goto exit;
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/2] nfc: remove unneeded nfc_put_device() calls
2014-04-02 7:56 [PATCH 2/2] nfc: remove unneeded nfc_put_device() calls Daeseok Youn
@ 2014-04-14 2:19 ` DaeSeok Youn
0 siblings, 0 replies; 2+ messages in thread
From: DaeSeok Youn @ 2014-04-14 2:19 UTC (permalink / raw)
To: David Miller, lauro.venancio
Cc: aloisio.almeida, sameo, linux-wireless, linux-nfc, netdev,
linux-kernel
Hi,
Can you review this patch?
Thanks.
Daeseok Youn
2014-04-02 16:56 GMT+09:00 Daeseok Youn <daeseok.youn@gmail.com>:
>
> If local is NULL, nfs_put_device() is called twice.
> So nfs_put_device() in "if (!local)" is removed.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> net/nfc/netlink.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
> index b2ad570..3e0a676 100644
> --- a/net/nfc/netlink.c
> +++ b/net/nfc/netlink.c
> @@ -1038,7 +1038,6 @@ static int nfc_genl_llc_sdreq(struct sk_buff *skb, struct genl_info *info)
>
> local = nfc_llcp_find_local(dev);
> if (!local) {
> - nfc_put_device(dev);
> rc = -ENODEV;
> goto exit;
> }
> --
> 1.7.4.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-14 2:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 7:56 [PATCH 2/2] nfc: remove unneeded nfc_put_device() calls Daeseok Youn
2014-04-14 2:19 ` DaeSeok Youn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).