[PATCH 1/1] cfg80211: OWE DH IE handling offload

[PATCH 1/1] cfg80211: OWE DH IE handling offload

[Vinayak Yadawad]

[-- Attachment #1: Type: text/plain, Size: 1898 bytes --]

Introduce new feature flags for OWE offload that driver can
advertise to indicate kernel/application space to avoid DH IE
handling. When this flag is advertised, the driver/device will
take care of DH IE inclusion and processing of peer DH IE to
generate PMK.

Signed-off-by: Vinayak Yadawad <vinayak.yadawad@broadcom.com>
---
 include/uapi/linux/nl80211.h | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
index 88eb85c63029..5548cccc5c1c 100644
--- a/include/uapi/linux/nl80211.h
+++ b/include/uapi/linux/nl80211.h
@@ -334,6 +334,15 @@
  * use %NL80211_CMD_START_AP or similar functions.
  */
 
+/**
+ * DOC: OWE DH IE handling offload
+ *
+ * By setting @NL80211_EXT_FEATURE_OWE_OFFLOAD flag, drivers can indicate
+ * kernel/application space to avoid DH IE handling. When this flag is
+ * advertised, the driver/device will take care of DH IE inclusion and
+ * processing of peer DH IE to generate PMK.
+ */
+
 /**
  * enum nl80211_commands - supported nl80211 commands
  *
@@ -6400,6 +6409,12 @@ enum nl80211_feature_flags {
  *	in authentication and deauthentication frames sent to unassociated peer
  *	using @NL80211_CMD_FRAME.
  *
+ * @NL80211_EXT_FEATURE_OWE_OFFLOAD: Driver/Device wants to do OWE DH IE
+ *	handling in station mode.
+ *
+ * @NL80211_EXT_FEATURE_OWE_OFFLOAD_AP: Driver/Device wants to do OWE DH IE
+ *	handling in AP mode.
+ *
  * @NUM_NL80211_EXT_FEATURES: number of extended features.
  * @MAX_NL80211_EXT_FEATURES: highest extended feature index.
  */
@@ -6471,6 +6486,8 @@ enum nl80211_ext_feature_index {
 	NL80211_EXT_FEATURE_PUNCT,
 	NL80211_EXT_FEATURE_SECURE_NAN,
 	NL80211_EXT_FEATURE_AUTH_AND_DEAUTH_RANDOM_TA,
+	NL80211_EXT_FEATURE_OWE_OFFLOAD,
+	NL80211_EXT_FEATURE_OWE_OFFLOAD_AP,
 
 	/* add new features before the definition below */
 	NUM_NL80211_EXT_FEATURES,
-- 
2.32.0


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

Re: [PATCH 1/1] cfg80211: OWE DH IE handling offload

[Johannes Berg]

On Fri, 2023-09-22 at 14:55 +0530, Vinayak Yadawad wrote:
> Introduce new feature flags for OWE offload that driver can
> advertise to indicate kernel/application space to avoid DH IE
> handling. When this flag is advertised, the driver/device will
> take care of DH IE inclusion and processing of peer DH IE to
> generate PMK.
> 

Seems like you'd also need something that userspace actually says
"please offload this", so you don't end up doing it twice if it's an
older userspace?

johannes

Re: [PATCH 1/1] cfg80211: OWE DH IE handling offload

[Vinayak Yadawad]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

Hi Johannes,

>Seems like you'd also need something that userspace actually says
>"please offload this", so you don't end up doing it twice if it's an
>older userspace?
If its older user space, the connect context will prepare the DH IEs
and pass it down to the driver
and driver can use it without having to generate again- so no other
indication is required from user space.
With newer user space, the DH IEs won't come down.

Regards,
Vinayak


On Fri, Sep 22, 2023 at 3:01 PM Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Fri, 2023-09-22 at 14:55 +0530, Vinayak Yadawad wrote:
> > Introduce new feature flags for OWE offload that driver can
> > advertise to indicate kernel/application space to avoid DH IE
> > handling. When this flag is advertised, the driver/device will
> > take care of DH IE inclusion and processing of peer DH IE to
> > generate PMK.
> >
>
> Seems like you'd also need something that userspace actually says
> "please offload this", so you don't end up doing it twice if it's an
> older userspace?
>
> johannes

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]