From: Loic Poulain <loic.poulain@linaro.org>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Network Development <netdev@vger.kernel.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 08/10] net: wwan: core: implement TIOCINQ ioctl
Date: Tue, 8 Jun 2021 10:51:03 +0200 [thread overview]
Message-ID: <CAMZdPi-24bQUKWQK7fnuOdD85dSqys9-twUggbrbZUAGvOnRKA@mail.gmail.com> (raw)
In-Reply-To: <20210608040241.10658-9-ryazanov.s.a@gmail.com>
On Tue, 8 Jun 2021 at 06:02, Sergey Ryazanov <ryazanov.s.a@gmail.com> wrote:
>
> It is quite common for a userpace program to fetch the buffered amount
> of data in the rx queue to avoid the read block. Implement the TIOCINQ
> ioctl to make the migration to the WWAN port usage smooth.
>
> Despite the fact that the read call will return no more data than the
> size of a first skb in the queue, TIOCINQ returns the entire amount of
> buffered data (sum of all queued skbs). This is done to prevent the
> breaking of programs that optimize reading, avoiding it if the buffered
> amount of data is too small.
>
> Signed-off-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
next prev parent reply other threads:[~2021-06-08 8:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 4:02 [PATCH 00/10] net: WWAN subsystem improvements Sergey Ryazanov
2021-06-08 4:02 ` [PATCH 01/10] wwan_hwsim: WWAN device simulator Sergey Ryazanov
2021-06-08 4:02 ` [PATCH 02/10] wwan_hwsim: add debugfs management interface Sergey Ryazanov
2021-06-08 4:02 ` [PATCH 03/10] net: wwan: make WWAN_PORT_MAX meaning less surprised Sergey Ryazanov
2021-06-08 8:35 ` Loic Poulain
2021-06-08 4:02 ` [PATCH 04/10] net: wwan: core: init port type string array using enum values Sergey Ryazanov
2021-06-08 8:36 ` Loic Poulain
2021-06-08 4:02 ` [PATCH 05/10] net: wwan: core: spell port device name in lowercase Sergey Ryazanov
2021-06-08 8:37 ` Loic Poulain
2021-06-08 4:02 ` [PATCH 06/10] net: wwan: core: make port names more user-friendly Sergey Ryazanov
2021-06-08 4:02 ` [PATCH 07/10] net: wwan: core: expand ports number limit Sergey Ryazanov
2021-06-08 8:47 ` Loic Poulain
2021-06-08 4:02 ` [PATCH 08/10] net: wwan: core: implement TIOCINQ ioctl Sergey Ryazanov
2021-06-08 8:51 ` Loic Poulain [this message]
2021-06-08 4:02 ` [PATCH 09/10] net: wwan: core: implement terminal ioctls for AT port Sergey Ryazanov
2021-06-08 4:02 ` [PATCH 10/10] net: wwan: core: purge rx queue on port close Sergey Ryazanov
2021-06-08 21:50 ` [PATCH 00/10] net: WWAN subsystem improvements patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZdPi-24bQUKWQK7fnuOdD85dSqys9-twUggbrbZUAGvOnRKA@mail.gmail.com \
--to=loic.poulain@linaro.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).