From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: "Adrián García Casado" <adriangarciacasado42@gmail.com>
Cc: Miri Korenblit <miriam.rachel.korenblit@intel.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 1/2] wifi: iwlwifi: pcie: migrate to modern pci_alloc_irq_vectors API
Date: Thu, 19 Mar 2026 21:56:16 +0100 [thread overview]
Message-ID: <CANiq72k_Kn2xwLkdddwcsJONJbAJKu5iTyvTPGD41pggHwVs7g@mail.gmail.com> (raw)
In-Reply-To: <20260319204728.24836-1-adriangarciacasado42@gmail.com>
On Thu, Mar 19, 2026 at 9:47 PM Adrián García Casado
<adriangarciacasado42@gmail.com> wrote:
>
> The iwlwifi driver currently uses the deprecated pci_enable_msix_range()
> API and implements a manual loop for interrupt affinity distribution.
> This manual approach is less robust than the kernel's core affinity
> management and increases maintenance complexity.
>
> Migrate the driver to the modern pci_alloc_irq_vectors() API. Use the
> PCI_IRQ_AFFINITY flag to delegate MSI-X affinity distribution to the
> kernel core. Remove the manual iwl_pcie_irq_set_affinity() loop as it
> is now redundant.
>
> Additionally, remove the unused 'offset' variable to resolve a
> previously reported kbuild warning.
>
> Signed-off-by: Adrián García Casado <adriangarciacasado42@gmail.com>
As it was mentioned before, please reply or acknowledge the feedback
you are receiving, instead of sending new versions immediately:
https://docs.kernel.org/process/submitting-patches.html#don-t-get-discouraged-or-impatient
In addition, please use `scripts/get_maintainer.pl` to pick the right
list of Cc's, e.g. I am not sure why I am in the Cc list for this
patch.
Finally, if this happens to be assisted by an LLM or similar, please
disclose that fact:
https://docs.kernel.org/process/generated-content.html
https://docs.kernel.org/process/coding-assistants.html
Thanks!
Cheers,
Miguel
next prev parent reply other threads:[~2026-03-19 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 20:47 [PATCH v9 1/2] wifi: iwlwifi: pcie: migrate to modern pci_alloc_irq_vectors API Adrián García Casado
2026-03-19 20:56 ` Miguel Ojeda [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-19 21:21 Adrián García Casado
2026-03-20 1:09 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72k_Kn2xwLkdddwcsJONJbAJKu5iTyvTPGD41pggHwVs7g@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=adriangarciacasado42@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox