* ath9k: write-only variable rx.rxotherant ?!?!? @ 2012-05-14 7:57 Holger Schurig 2012-05-14 8:02 ` Johannes Berg 0 siblings, 1 reply; 3+ messages in thread From: Holger Schurig @ 2012-05-14 7:57 UTC (permalink / raw) To: linux-wireless I looks like sc->rx.rxotherant is an almost write-only variable: "grep -r rxotherant *": ./ath9k/recv.c: sc->rx.rxotherant = 0; ./ath9k/recv.c: if (++sc->rx.rxotherant >= 3) ./ath9k/recv.c: sc->rx.rxotherant = 0; ./ath9k/ath9k.h: u8 rxotherant; -- http://www.holgerschurig.de ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ath9k: write-only variable rx.rxotherant ?!?!? 2012-05-14 7:57 ath9k: write-only variable rx.rxotherant ?!?!? Holger Schurig @ 2012-05-14 8:02 ` Johannes Berg 2012-05-14 8:11 ` Holger Schurig 0 siblings, 1 reply; 3+ messages in thread From: Johannes Berg @ 2012-05-14 8:02 UTC (permalink / raw) To: Holger Schurig; +Cc: linux-wireless On Mon, 2012-05-14 at 09:57 +0200, Holger Schurig wrote: > I looks like sc->rx.rxotherant is an almost write-only variable: "grep > -r rxotherant *": > > ./ath9k/recv.c: sc->rx.rxotherant = 0; > ./ath9k/recv.c: if (++sc->rx.rxotherant >= 3) that reads it too johannes ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ath9k: write-only variable rx.rxotherant ?!?!? 2012-05-14 8:02 ` Johannes Berg @ 2012-05-14 8:11 ` Holger Schurig 0 siblings, 0 replies; 3+ messages in thread From: Holger Schurig @ 2012-05-14 8:11 UTC (permalink / raw) To: Johannes Berg; +Cc: linux-wireless Ups, I oversaw the ++. I thought only zeros would ever be written there. /me hides behind a tree ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-14 8:11 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-05-14 7:57 ath9k: write-only variable rx.rxotherant ?!?!? Holger Schurig 2012-05-14 8:02 ` Johannes Berg 2012-05-14 8:11 ` Holger Schurig
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).