From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from senator.holtmann.net ([87.106.208.187]:48555 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbbACSCH convert rfc822-to-8bit (ORCPT ); Sat, 3 Jan 2015 13:02:07 -0500 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Subject: Re: [PATCH] Revert "ipw2200: select CFG80211_WEXT" From: Marcel Holtmann In-Reply-To: <1420297188.2397.3.camel@tiscali.nl> Date: Sat, 3 Jan 2015 10:02:00 -0800 Cc: Stanislav Yakovlev , Kalle Valo , Jiri Kosina , Linus Torvalds , linux-wireless , Network Development , linux-kernel@vger.kernel.org Message-Id: (sfid-20150103_190233_895756_BA053CB5) References: <1420297188.2397.3.camel@tiscali.nl> To: Paul Bolle Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Paul, > This reverts commit dddd60220f41775e634258efd1b54c6fa81ce706. > > The raison d'être of commit dddd60220f41 ("ipw2200: select > CFG80211_WEXT") was reverted in commit 2d36e008739e ("Revert "cfg80211: > make WEXT compatibility unselectable""). So revert this commit too. > > Signed-off-by: Paul Bolle > --- > drivers/net/wireless/ipw2x00/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ipw2x00/Kconfig b/drivers/net/wireless/ipw2x00/Kconfig > index 21de4fe6cf2d..91c0cb3c368e 100644 > --- a/drivers/net/wireless/ipw2x00/Kconfig > +++ b/drivers/net/wireless/ipw2x00/Kconfig > @@ -65,8 +65,7 @@ config IPW2100_DEBUG > > config IPW2200 > tristate "Intel PRO/Wireless 2200BG and 2915ABG Network Connection" > - depends on PCI && CFG80211 > - select CFG80211_WEXT > + depends on PCI && CFG80211 && CFG80211_WEXT > select WIRELESS_EXT > select WEXT_SPY > select WEXT_PRIV why would you revert this? It is obviously the correct change to actually select CFG80211_WEXT. Regards Marcel