From: "Nicolas Escande" <nico.escande@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>,
"Nicolas Cavallari" <Nicolas.Cavallari@green-communications.fr>,
"Nicolas Escande" <nescande@freebox.fr>,
<linux-wireless@vger.kernel.org>
Subject: Re: Missing wiphy lock in ieee80211_color_collision_detection_work
Date: Fri, 20 Sep 2024 09:05:35 +0200 [thread overview]
Message-ID: <D4AX5T9YTARM.AJSGPZQJX8R7@gmail.com> (raw)
In-Reply-To: <c48876507ec971c9195e468e6037cc251dcf2218.camel@sipsolutions.net>
On Thu Sep 19, 2024 at 12:22 PM CEST, Johannes Berg wrote:
> >
> > Also the rate limiting uses delayed_work_pending(), There is no wiphy work queue
> > equivalent AFAIK, so the explicit lock is probably the way to go.
>
> That won't work, it's cancel_delayed_work_sync() under the wiphy mutex,
> so that'll cause deadlocks (and should cause lockdep complaints about
> them.)
>
> johannes
Ok then we'll go the wiphy work queue way.
next prev parent reply other threads:[~2024-09-20 7:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 8:15 Missing wiphy lock in ieee80211_color_collision_detection_work Nicolas Escande
2024-09-19 10:02 ` Nicolas Cavallari
2024-09-19 10:22 ` Johannes Berg
2024-09-20 7:05 ` Nicolas Escande [this message]
2024-09-20 8:28 ` Remi Pommarel
2024-09-20 8:41 ` Remi Pommarel
2024-09-20 10:00 ` Johannes Berg
2024-09-20 12:07 ` Remi Pommarel
2024-09-20 12:10 ` Remi Pommarel
2024-09-20 12:12 ` Johannes Berg
2024-09-20 13:37 ` Remi Pommarel
2024-09-20 11:35 ` Nicolas Cavallari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4AX5T9YTARM.AJSGPZQJX8R7@gmail.com \
--to=nico.escande@gmail.com \
--cc=Nicolas.Cavallari@green-communications.fr \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nescande@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).