From: "Nicolas Escande" <nico.escande@gmail.com>
To: "Jeff Johnson" <jeff.johnson@oss.qualcomm.com>,
<ath11k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath11k: remove peer extra rssi update
Date: Wed, 29 Jan 2025 10:24:01 +0100 [thread overview]
Message-ID: <D7EG56E1I0SX.3BZRTM7N6CQ44@gmail.com> (raw)
In-Reply-To: <d5eda793-c7e9-453f-9dbc-07e5df73c47d@oss.qualcomm.com>
On Tue Jan 28, 2025 at 11:29 PM CET, Jeff Johnson wrote:
> On 1/17/2025 10:19 AM, Nicolas Escande wrote:
>> Commit b205ce4c266c (ath11k: support avg signal in station dump) added an
>
> I'll fixup this reference to address the checkpatch error:
> ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit b205ce4c266c ("ath11k: support avg signal in station dump")'
> total: 1 errors, 0 warnings, 0 checks, 8 lines checked
Arf I can see that the commit format is wrong but I wonder why checkpatch didn't
arn me. Do I need more options set on the cmdline ?
scripts/checkpatch.pl mail/0001-wifi-ath11k-remove-extra-rssi-update-in-ath11k_dp_rx.patch
total: 0 errors, 0 warnings, 0 checks, 8 lines checked
mail/0001-wifi-ath11k-remove-extra-rssi-update-in-ath11k_dp_rx.patch has no obvious style problems and is ready for submission.
>
>> extra assignment of arsta->rssi_comb in ath11k_dp_rx_update_peer_stats
>> when it added the average rssi support. So lets keeps only one by removing
>> the legacy assignment so the two statements about rssi stay next to each
>> other. Compile tested only.
>>
>> Signed-off-by: Nicolas Escande <nico.escande@gmail.com>
next prev parent reply other threads:[~2025-01-29 9:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 18:19 [PATCH] wifi: ath11k: remove peer extra rssi update Nicolas Escande
2025-01-18 10:39 ` Vasanthakumar Thiagarajan
2025-01-28 22:29 ` Jeff Johnson
2025-01-29 0:08 ` Jeff Johnson
2025-01-29 9:18 ` Nicolas Escande
2025-01-29 9:24 ` Nicolas Escande [this message]
2025-01-30 17:44 ` Jeff Johnson
2025-01-29 17:03 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D7EG56E1I0SX.3BZRTM7N6CQ44@gmail.com \
--to=nico.escande@gmail.com \
--cc=ath11k@lists.infradead.org \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox