Re: [question, bug] regularly disconnecting wifi on RB1 and RB2 boards, ath10

["Alexey Klimov" <alexey.klimov@linaro.org>]

On Thu Jul 24, 2025 at 3:50 PM BST, Alexey Klimov wrote:
> Hi Loic,
>
> On Wed Jul 23, 2025 at 11:42 AM BST, Loic Poulain wrote:
>> Hi Alexey,
>>

[..]

>> Could you check if this change helps:
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c
>> b/drivers/net/wireless/ath/ath10k/mac.c
>> index c61b95a928da..4fa7dd62aeac 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -288,8 +288,10 @@ static int ath10k_send_key(struct ath10k_vif *arvif,
>>                 key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV;
>>
>>         if (cmd == DISABLE_KEY) {
>> -               arg.key_cipher = ar->wmi_key_cipher[WMI_CIPHER_NONE];
>> -               arg.key_data = NULL;
>> +               /*  Not all hardware supports key deletion operations. so we
>> +                *  replace the key with a junk value to invalidate it.
>> +                */
>> +               memset(arg.key_data, 0, arg.key_len);
>>         }

So far looks good.

I didn't see any kind of GROUP_KEY_HANDSHAKE_TIMEOUT messages and long wifi
outages leaving the RB1, for instance, overnight.

I do observe some packet loss while pinging the board for a while --
around 0.1..0.6% packet loss but that might be because of my wifi network
and absence of external antenna and it is still much much better than
default behaviour.

Could you please add me to C/c when you're going to send it over?

Thank you for looking into this,
Alexey