From: "Nicolas Escande" <nico.escande@gmail.com>
To: "Maharaja Kennadyrajan" <maharaja.kennadyrajan@oss.qualcomm.com>,
<ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>,
"Aishwarya R" <aishwarya.r@oss.qualcomm.com>
Subject: Re: [PATCH ath-next v2] wifi: ath12k: add basic hwmon temperature reporting
Date: Thu, 19 Feb 2026 10:15:08 +0100 [thread overview]
Message-ID: <DGITONL8L200.PJE38TDXYRQC@gmail.com> (raw)
In-Reply-To: <20260219073440.19618-1-maharaja.kennadyrajan@oss.qualcomm.com>
On Thu Feb 19, 2026 at 8:34 AM CET, Maharaja Kennadyrajan wrote:
> Add initial thermal support by wiring up a per-radio (pdev) hwmon temperature
> sensor backed by the existing WMI pdev temperature command and event.
> When userspace reads the sysfs file temp1_input, the driver sends
> WMI_PDEV_GET_TEMPERATURE_CMDID (tag WMI_TAG_PDEV_GET_TEMPERATURE_CMD) and waits
> for the corresponding WMI_PDEV_TEMPERATURE_EVENTID
> (tag WMI_TAG_PDEV_TEMPERATURE_EVENT) to get the temperature and pdev_id.
>
> Export the reported value in millidegrees Celsius as required by hwmon.
> The temperature reported is per-radio (pdev). In a multi-radio wiphy under a
> single phy, a separate hwmon device is created for each radio.
>
> Sample command and output:
> $ cat /sys/devices/pci0000:00/.../ieee80211/phyX/hwmonY/temp1_input
> $ 50000
>
Hello,
In ath10k & ath11k you guys also had the throtling feature. Do you guys plan to
add this also at some point ?
[...]
> --- a/drivers/net/wireless/ath/ath12k/Makefile
> +++ b/drivers/net/wireless/ath/ath12k/Makefile
> @@ -32,6 +32,7 @@ ath12k-$(CONFIG_ATH12K_TRACING) += trace.o
> ath12k-$(CONFIG_PM) += wow.o
> ath12k-$(CONFIG_ATH12K_COREDUMP) += coredump.o
> ath12k-$(CONFIG_NL80211_TESTMODE) += testmode.o
> +ath12k-$(CONFIG_THERMAL) += thermal.o
>
I may be wrong but I do not see Kconfig changes that allows to actually build
the new files. Is this intended ?
> # for tracing framework to find trace.h
> CFLAGS_trace.o := -I$(src)
> diff --git a/drivers/net/wireless/ath/ath12k/core.c b/drivers/net/wireless/ath/ath12k/core.c
next prev parent reply other threads:[~2026-02-19 9:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 7:34 [PATCH ath-next v2] wifi: ath12k: add basic hwmon temperature reporting Maharaja Kennadyrajan
2026-02-19 9:15 ` Nicolas Escande [this message]
2026-02-19 21:37 ` Jeff Johnson
2026-02-20 9:26 ` Nicolas Escande
2026-02-23 11:21 ` Maharaja Kennadyrajan
2026-02-19 11:31 ` Pablo MARTIN-GOMEZ
2026-02-19 11:45 ` Maharaja Kennadyrajan
2026-02-19 21:44 ` Jeff Johnson
2026-02-20 9:55 ` Maharaja Kennadyrajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGITONL8L200.PJE38TDXYRQC@gmail.com \
--to=nico.escande@gmail.com \
--cc=aishwarya.r@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maharaja.kennadyrajan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox