From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
"Luca Weiss" <luca.weiss@fairphone.com>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Marcel Holtmann" <marcel@holtmann.org>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
"Jeff Johnson" <jjohnson@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Vinod Koul" <vkoul@kernel.org>,
"Balakrishna Godavarthi" <quic_bgodavar@quicinc.com>,
"Matthias Kaehlcke" <mka@chromium.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-bluetooth@vger.kernel.org>,
<linux-wireless@vger.kernel.org>, <ath10k@lists.infradead.org>,
<linux-pm@vger.kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>
Subject: Re: [PATCH v3 3/8] wifi: ath10k: snoc: support powering on the device via pwrseq
Date: Mon, 20 Apr 2026 13:14:01 +0200 [thread overview]
Message-ID: <DHXXSDE9V52E.33D6CI1LWMHFP@fairphone.com> (raw)
In-Reply-To: <hdypom3nioc6tk26gh647imy5ykhcjqvknideilnbc2b5p7eo7@hm7fsscleutf>
On Sat Apr 18, 2026 at 9:38 PM CEST, Dmitry Baryshkov wrote:
> On Thu, Apr 16, 2026 at 12:06:09PM +0200, Luca Weiss wrote:
>> Hi Dmitry,
>>
>> On Mon Jan 19, 2026 at 6:07 PM CET, Dmitry Baryshkov wrote:
>> > The WCN39xx family of WiFi/BT chips incorporates a simple PMU, spreading
>> > voltages over internal rails. Implement support for using powersequencer
>> > for this family of ATH10k devices in addition to using regulators.
>> >
>> > Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
>> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>> > ---
>> > drivers/net/wireless/ath/ath10k/snoc.c | 53 ++++++++++++++++++++++++++++++++--
>> > drivers/net/wireless/ath/ath10k/snoc.h | 3 ++
>> > 2 files changed, 53 insertions(+), 3 deletions(-)
>> >
>> > + ar_snoc->pwrseq = devm_pwrseq_get(&pdev->dev, "wlan");
>> > + if (IS_ERR(ar_snoc->pwrseq)) {
>> > + ret = PTR_ERR(ar_snoc->pwrseq);
>> > + ar_snoc->pwrseq = NULL;
>> > + if (ret != -EPROBE_DEFER)
>> > + goto err_free_irq;
>>
>> I'm fairly sure this is now broken with CONFIG_POWER_SEQUENCING=n since
>> then pwrseq_get() is returning ERR_PTR(-ENOSYS) which is not handled
>> here.
>>
>> I'm observing my ath10k_snoc is now failing to probe "with error -38"
>> which definitely seems to be related, but I haven't debugged it further
>> yet.
>
> Posted https://patch.msgid.link/20260418-ath10k-snoc-pwrseq-v1-1-832594ba3294@oss.qualcomm.com
Thanks Dmitry!
next prev parent reply other threads:[~2026-04-20 11:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 17:07 [PATCH v3 0/8] Bluetooth, wifi, arm64: extend WCN driver to support WCN399x device Dmitry Baryshkov
2026-01-19 17:07 ` [PATCH v3 1/8] Bluetooth: qca: enable pwrseq support for WCN39xx devices Dmitry Baryshkov
2026-01-19 17:07 ` [PATCH v3 2/8] Bluetooth: qca: fix ROM version reading on WCN3998 chips Dmitry Baryshkov
2026-01-19 17:07 ` [PATCH v3 3/8] wifi: ath10k: snoc: support powering on the device via pwrseq Dmitry Baryshkov
2026-01-30 15:15 ` Jeff Johnson
2026-04-16 10:06 ` Luca Weiss
2026-04-18 19:38 ` Dmitry Baryshkov
2026-04-20 11:14 ` Luca Weiss [this message]
2026-01-19 17:07 ` [PATCH v3 4/8] arm64: dts: qcom: qrb2210-rb1: describe WiFi/BT properly Dmitry Baryshkov
2026-01-19 17:07 ` [PATCH v3 5/8] arm64: dts: qcom: qrb4210-rb2: " Dmitry Baryshkov
2026-01-19 17:08 ` [PATCH v3 6/8] arm64: dts: qcom: sda660-ifc6560: " Dmitry Baryshkov
2026-01-19 17:08 ` [PATCH v3 7/8] arm64: dts: qcom: sdm845-db845c: " Dmitry Baryshkov
2026-03-26 0:02 ` David Heidelberg
2026-03-26 1:59 ` Dmitry Baryshkov
2026-03-26 9:01 ` Konrad Dybcio
2026-01-19 17:08 ` [PATCH v3 8/8] arm64: dts: qcom: sm8150-hdk: " Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHXXSDE9V52E.33D6CI1LWMHFP@fairphone.com \
--to=luca.weiss@fairphone.com \
--cc=andersson@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=mani@kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
--cc=quic_bgodavar@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox