From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32CAA27453 for ; Fri, 19 Jun 2026 01:50:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781833819; cv=none; b=cL70BJEht8hUvBrvTkUUzemyVPP4q5zpRxvnyU3vvB0W4kdR4Rz2/ia76x8lxjnDP5Vm+aPpPbzqOag5F0PgkTYP5fIstaQEz/tMpcjm9iFmgXPxPpOBDiXVQ5awqVnk7fF1A55AxmLwXG3haaQho4UiWo3bMd6PfHgpSKs9K2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781833819; c=relaxed/simple; bh=BJ51igLEiNSOqU+Oprmh7TY8ZldodOtpB0GApKHNHmY=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=SzS5z1MJIcOAXXDHuhNqRtcZhJ4peAxmIypx2+IAGm+3vSqPugXjX0BqPFR7+s8qBiSaaUPjQ80LqCnRAk+PTQktF+2GJ+AhI1Q8ztY8kp2qSRXe6qestktKBzdcyRrHQd8m6wT52MHEBvMSPkX8VkZlhIVAkjhp9D89zsHebao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SAeptQi0; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SAeptQi0" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-37c8e7c8137so829441a91.1 for ; Thu, 18 Jun 2026 18:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781833818; x=1782438618; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GrtOo2Dm8vwbUCXe5Oa40jPMn4I218rLCkoAsNCnLeg=; b=SAeptQi0uGiRBlU1eBkKod/U7B29nNfWL1i6miTAOCx36pSzKLzpk1kmUz+rKiUQeP nW9vBrdU0cXEgUql64xvRywVtM/f29BCA3qSt3z42Rl4DXv8s8E5V6uiOJIGKWJXuukL gUCrS/hPev2tLlkMszLYiHfSU5hJjD4cfLTrD0IhBTT4lkaPYlX+Gn7th5hzDJSZQb3C IlYhiHEInenOY3YArrfB1OtWEg4eKab5+J2/T2ALWZHIcHqBQVvks2PG/zG+KG0nbWQH oJPUlzhQ8PhZ1B5Wr4X4iRma+tAaOU5GxiaDBEYOlpeJ0S/kDIxKzp3zsq8ZJBjKYjJD sgpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781833818; x=1782438618; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GrtOo2Dm8vwbUCXe5Oa40jPMn4I218rLCkoAsNCnLeg=; b=T+3taCAaJ/pq9rzd7p4ermkP4cC1WP/m+HSQWzu5796Vz9nGpAigIU3j6N9xt/N85F CMI8kAE4VVYww0n4FFAwA2vOQjVsV6smKMzuBkaWAlbvUpzCGMjW1FKQw4qhXzyqjCC/ Wq/Af6RhUKRr6y4u/oR6VPZ0kGRiv2J0YhlfbGzaG4XCX21KMXbOqeLsXURoexJSvAyF ZNBBtcDdtrs7OXPRAPE/9yUlmLiFizgByvVc1JM8iZ6Z5JDF0wEaqRlOjC1NE1wy7tX2 EBm9woIhSrD9XHs7b6W8YWPBU/UIrFcywF7GzuODJxwuH5YsxhebKW1DalVk+hCD8GKd fseg== X-Gm-Message-State: AOJu0YwS73oWX3RCaoNo9IJUL9ai2jQhcLEcXOwDgDJkf5rhmAKgmx1k dR3IPd37JsWvOLTwJ31/tX3zgmY+Jq5rCuG7blpGJV5d5x1kM/CiHBAh X-Gm-Gg: AfdE7cnLn7/DY8iqQH5dfr7h17vdgRXlNCNg58i9ED03PUUT2zUpD6VKS+XlMHMdQce YDAtq6dJ7upVv3m0/pztxQSSIz8rL8QATZpxWVOcYpV9chk8UJTlsPg7e/qRs4elCUYABuQDZjQ +KyQptbOg28RHJ5NNRhQHi8OcJ5XkkmN18ThbHOiJ6sd+8HiEJ+8GsfGYtsS8VSE1KPIo4IKFF0 k5rOk+TyDAFrSsqvenbgFh5tDypIdI8z69HF9z3//gwW0QOVEfSMyJeyULObcjMbFj8p3kw0LPx hvNmnScbRdhGeHfZ0YSERTdKD7zt8AGLpll/fNFca0w4YzWyZWXzNVVrjWGBn4WkNH7IX8fin0z TtYNrTmc79TDrJHfWrp4sU/6ibulsWmkcUJftbeB2deLcEvErUF6VwB+0m1CqgmJmywLYIs9PPA pb9ZqdfMB4jhZtsnP+iOUM2lpWIvtO3CsUpxklEybXMbPPjKwqIf6DMLFTxoD2AM6n4Pfal4y8w iO3WnJmT7J+yIeUnnReV4Fs+W8mGw== X-Received: by 2002:a17:902:cec1:b0:2c6:b3dc:b82a with SMTP id d9443c01a7336-2c725d33bccmr5323065ad.24.1781833817630; Thu, 18 Jun 2026 18:50:17 -0700 (PDT) Received: from localhost ([2601:644:8000:5b5d:3804:5798:1282:ed9e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7208e2e66sm4690245ad.34.2026.06.18.18.50.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 18:50:16 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 18 Jun 2026 18:50:15 -0700 Message-Id: To: "Klara Modin" , "Rosen Penev" Cc: , "Felix Fietkau" , "Lorenzo Bianconi" , "Ryder Lee" , "Shayne Chen" , "Sean Wang" , "Matthias Brugger" , "AngeloGioacchino Del Regno" , "open list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH wireless-next] wifi: mt76: fix of_get_mac_address error handling From: "Rosen Penev" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260427051746.954704-1-rosenp@gmail.com> In-Reply-To: On Thu Jun 18, 2026 at 4:51 PM PDT, Klara Modin wrote: > On 2026-06-18 16:01:45 -0700, Rosen Penev wrote: >> On Thu, Jun 18, 2026 at 2:47=E2=80=AFPM Klara Modin wrote: >> > >> > Hi, >> > >> > On 2026-04-26 22:17:46 -0700, Rosen Penev wrote: >> > > Check return value instead of is_valid_ether_addr. The latter is han= dled >> > > by the former. >> > > >> > > Signed-off-by: Rosen Penev >> > > --- >> > > drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > > >> > > diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/n= et/wireless/mediatek/mt76/eeprom.c >> > > index 93d91264687f..0f6ccf6ed53d 100644 >> > > --- a/drivers/net/wireless/mediatek/mt76/eeprom.c >> > > +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c >> > > @@ -93,7 +93,7 @@ mt76_eeprom_override(struct mt76_phy *phy) >> > > if (err =3D=3D -EPROBE_DEFER) >> > > return err; >> > > >> > > - if (!is_valid_ether_addr(phy->macaddr)) { >> > > + if (err) { >> > > eth_random_addr(phy->macaddr); >> > > dev_info(dev->dev, >> > > "Invalid MAC address, using random address %p= M\n", >> > > -- >> > > 2.54.0 >> > > >> > >> > Recently I have started to see randomized MAC-addresses on my x86 lapt= op >> > with a MT7922 and the above message printed in the kernel log. I have >> > CONFIG_OF turned on, but since this is an ACPI system the device is no= t >> > described by any device tree and the earlier of_get_mac_address() like= ly >> > fails with -ENODEV. Looking at the !CONFIG_OF stub for >> > of_get_mac_address it always returns -ENODEV, meaning this will always >> > randomize the mac in that case too. > >> IIRC, the normal device_get_mac_address supports nvmem now. Does that >> fix your use case? > > I tried this: > > diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wi= reless/mediatek/mt76/eeprom.c > index b99d7452800f..243a8f2c7bda 100644 > --- a/drivers/net/wireless/mediatek/mt76/eeprom.c > +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c > @@ -174,10 +174,9 @@ int > mt76_eeprom_override(struct mt76_phy *phy) > { > struct mt76_dev *dev =3D phy->dev; > - struct device_node *np =3D dev->dev->of_node; > int err; > > - err =3D of_get_mac_address(np, phy->macaddr); > + err =3D device_get_mac_address(dev->dev, phy->macaddr); > if (err =3D=3D -EPROBE_DEFER) > return err; > > > but I still get a random MAC. Then the original patch should be reverted. Unfortunate that it doesn't workq > >> > >> > Reverting this patch fixes the issue and the correct MAC address is >> > used. I'm not sure if there is any case where of_get_mac_addres() coul= d >> > fail in a way that results in a valid MAC address but it seems unlikel= y >> > to me. >> > >> > Regards, >> > Klara Modin