From: "Nicolas Escande" <nico.escande@gmail.com>
To: "Loic Poulain" <loic.poulain@oss.qualcomm.com>,
"Nicolas Escande" <nico.escande@gmail.com>
Cc: "Jeff Johnson" <jjohnson@kernel.org>,
"Filippo Falezza" <effeffe99@gmail.com>,
<linux-wireless@vger.kernel.org>, <ath10k@lists.infradead.org>
Subject: Re: [PATCH v2] wifi: ath10k: Stop unanswered temperature reads
Date: Mon, 16 Nov 2026 12:00:33 +0100 [thread overview]
Message-ID: <DMWL0GJF8W4F.LOVVKMQHF9R@gmail.com> (raw)
In-Reply-To: <CAFEp6-2a-0NSmSZXOdKNfB+C+2T6=hmaBC2zV-sfkCrDwZu0GA@mail.gmail.com>
On Thu Nov 12, 2026 at 5:56 PM CET, Loic Poulain wrote:
[...]
>
> The 100 ms timeout seems reasonable. However, will it actually help in
> your case? You mentioned that the failures are sporadic. If we happen
> to read the temperature at the "wrong" moment, is it likely that all
> three retry attempts will fail as well, or would it be better to wait
> a little longer before retrying the read?
>
> In other words, do we expect a short retry loop to be sufficient, or
> is the failure window long enough that spacing out the retries would
> improve the chances of success?
So from my POV I believe the driver should not do any kind ok retry by itself.
No need to add complexity. We (ath10k thermal users) already had to cope with
read failures.
So what I would do would is something along the lines:
- if we fail the first 3 times we read the temperature, disable it permanently
- past the first success, don't disable and report errors like before
- lower timeout value as this holds a lock for a longtime to no gain
>
> Regards,
> Loic
next prev parent reply other threads:[~2026-11-16 11:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 1:56 [PATCH v2] wifi: ath10k: Stop unanswered temperature reads Filippo Falezza
2026-10-27 8:43 ` Loic Poulain
2026-10-28 16:13 ` Jeff Johnson
2026-10-29 22:56 ` Jeff Johnson
2026-11-14 16:29 ` Jeff Johnson
2026-11-10 17:20 ` Nicolas Escande
2026-11-11 16:30 ` Loic Poulain
2026-11-12 16:46 ` Nicolas Escande
2026-11-12 16:56 ` Loic Poulain
2026-11-16 11:00 ` Nicolas Escande [this message]
2026-11-12 0:12 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMWL0GJF8W4F.LOVVKMQHF9R@gmail.com \
--to=nico.escande@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=effeffe99@gmail.com \
--cc=jjohnson@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox