From: "Luca Weiss" <luca.weiss@fairphone.com>
To: <arapaille@atlr-engineering.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Abel Vesa" <abelvesa@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Loic Poulain" <loic.poulain@oss.qualcomm.com>,
"Luca Weiss" <luca@lucaweiss.eu>,
"Eugene Krasnikov" <k.eugene.e@gmail.com>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <wcn36xx@lists.infradead.org>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/3] wifi: wcn36xx: Do not enforce interrupt trigger type
Date: Wed, 18 Nov 2026 17:13:20 +0100 [thread overview]
Message-ID: <DMYGX16XPQEY.PD4MUZN1IINL@fairphone.com> (raw)
In-Reply-To: <20261118-wcnss-series-v1-v1-2-a64d82e151bf@atlr-engineering.com>
On Wed Nov 18, 2026 at 3:58 PM CET, Alexandre Rapaille via B4 Relay wrote:
> From: Alexandre Rapaille <arapaille@atlr-engineering.com>
>
> Forcing IRQF_TRIGGER_HIGH over the DT type makes the re-probe after a WCNSS
> restart fail ("type mismatch, failed to map hwirq"). Rely on the DT, as
> commit 1ee6c5abebd3 ("ath10k: do not enforce interrupt trigger type") did.
Worth noting, that all upstream dts files that use qcom,wcnss-wlan
(apart from msm8974.dtsi which is getting updated in this series) are
already using IRQ_TYPE_LEVEL_HIGH, so this should not change behavior
for any other SoC.
>
> Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware")
> Signed-off-by: Alexandre Rapaille <arapaille@atlr-engineering.com>
> ---
> drivers/net/wireless/ath/wcn36xx/dxe.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/dxe.c b/drivers/net/wireless/ath/wcn36xx/dxe.c
> index 801f1218ef..7852f71368 100644
> --- a/drivers/net/wireless/ath/wcn36xx/dxe.c
> +++ b/drivers/net/wireless/ath/wcn36xx/dxe.c
> @@ -552,14 +552,14 @@ static int wcn36xx_dxe_request_irqs(struct wcn36xx *wcn)
> {
> int ret;
>
> - ret = request_irq(wcn->tx_irq, wcn36xx_irq_tx_complete,
> - IRQF_TRIGGER_HIGH, "wcn36xx_tx", wcn);
> + ret = request_irq(wcn->tx_irq, wcn36xx_irq_tx_complete, 0,
> + "wcn36xx_tx", wcn);
> if (ret) {
> wcn36xx_err("failed to alloc tx irq\n");
> goto out_err;
> }
>
> - ret = request_irq(wcn->rx_irq, wcn36xx_irq_rx_ready, IRQF_TRIGGER_HIGH,
> + ret = request_irq(wcn->rx_irq, wcn36xx_irq_rx_ready, 0,
> "wcn36xx_rx", wcn);
> if (ret) {
> wcn36xx_err("failed to alloc rx irq\n");
next prev parent reply other threads:[~2026-11-18 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 14:57 [PATCH 0/3] msm8974/wcn36xx: recover Wi-Fi after a WCNSS crash Alexandre Rapaille via B4 Relay
2026-11-18 14:57 ` [PATCH 1/3] ARM: dts: qcom: msm8974: Fix WCNSS wifi interrupt trigger type Alexandre Rapaille via B4 Relay
2026-11-18 16:14 ` Luca Weiss
2026-11-18 14:58 ` [PATCH 2/3] wifi: wcn36xx: Do not enforce " Alexandre Rapaille via B4 Relay
2026-11-18 16:13 ` Luca Weiss [this message]
2026-11-18 14:58 ` [PATCH 3/3] wifi: wcn36xx: Stop waiting on a dead firmware during remove Alexandre Rapaille via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMYGX16XPQEY.PD4MUZN1IINL@fairphone.com \
--to=luca.weiss@fairphone.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=arapaille@atlr-engineering.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=k.eugene.e@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=luca@lucaweiss.eu \
--cc=robh@kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox