From: Tim Shepard <shep@alum.mit.edu>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
make-wifi-fast@lists.bufferbloat.net,
linux-wireless@vger.kernel.org, "Felix Fietkau" <nbd@nbd.name>
Subject: Re: [v5] ath9k: Switch to using mac80211 intermediate software queues.
Date: Tue, 08 Nov 2016 21:44:42 -0500 [thread overview]
Message-ID: <E1c4IsV-0003Rk-00@www.xplot.org> (raw)
In-Reply-To: Your message of Wed, 09 Nov 2016 03:22:30 +0100. <1cd07522568b40a6a3e2db6170153c74@euamsexm01a.eu.qualcomm.com>
> While at it, could you also add to the commit log some info how awesome this
> patch is from user's point of view and how it helps. For example, before and
> and after numbers and other results.
That varies wildly, depending on many details of the scenario
(including the wireless capabilities of the clients connected to the
AP using this patch, and how far away those clients are). There's
really not enough room in a commit message to explain enough to make
any such claimed numbers reproducible.
And, BTW, this patch alone is not really where the big improvement
comes from. This just cuts ath9k over to use the new
transmit-a-packet interface between the mac80211 layer and the
wireless device driver. All the good work to improve latency is being
done on the new mac80211 interface to the driver to transmit a packet.
If you want numbers in a commit message, those numbers belong over on
those commits, not on this ath9k commit, IMHO.
And there's different patches that taken together achieve the best
improvement, and in various subsets differing amounts of improvement,
which again all depends on the scenarios.
And all this is complicated by how often real users are involved in
scenarios where this matters (hard to say).
This mainly improves things when you have an ath9k interface with
packets queued simultaneously to different wireless destinations,
which is typically when the ath9k interface is serving as an AP.
And I would expect similar improvements for any wireless driver cut
over to use the new mac80211 interface. (This patch might be a
helpful guide to other wireless driver maintainers wishing to see the
same improvements other wireless drivers.)
I hope that the above paragraphs were helpful.
-Tim Shepard
shep@alum.mit.edu
next prev parent reply other threads:[~2016-11-09 3:07 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 9:09 [PATCH 0/2] ath9k: Add airtime fairness scheduler Toke Høiland-Jørgensen
2016-06-17 9:09 ` [PATCH 1/2] ath9k: use mac80211 intermediate software queues Toke Høiland-Jørgensen
2016-06-17 13:28 ` Felix Fietkau
2016-06-17 13:41 ` Tim Shepard
2016-06-17 14:35 ` Felix Fietkau
2016-06-17 17:45 ` Tim Shepard
2016-06-17 19:15 ` Toke Høiland-Jørgensen
2016-06-17 13:43 ` Toke Høiland-Jørgensen
2016-06-17 13:48 ` Felix Fietkau
2016-06-17 16:33 ` Felix Fietkau
2016-06-17 14:10 ` [ath9k-devel] " Dave Taht
2016-06-18 19:05 ` [PATCH] ath9k: Switch to using " Toke Høiland-Jørgensen
2016-06-19 3:17 ` Tim Shepard
2016-06-19 8:52 ` Toke Høiland-Jørgensen
2016-06-19 13:39 ` Tim Shepard
2016-06-19 13:50 ` Toke Høiland-Jørgensen
2016-07-03 3:52 ` Tim Shepard
2016-07-04 17:46 ` Toke Høiland-Jørgensen
2016-07-06 13:23 ` Felix Fietkau
2016-07-06 14:45 ` Toke Høiland-Jørgensen
2016-07-06 16:16 ` [PATCH v2] " Toke Høiland-Jørgensen
2016-07-06 17:57 ` Sebastian Gottschall
2016-07-06 18:13 ` Felix Fietkau
2016-07-06 18:52 ` Toke Høiland-Jørgensen
2016-07-06 18:59 ` Felix Fietkau
2016-07-06 19:08 ` Toke Høiland-Jørgensen
2016-07-06 19:34 ` [PATCH v3] " Toke Høiland-Jørgensen
2016-07-08 14:26 ` [v3] " Kalle Valo
2016-07-08 15:53 ` Toke Høiland-Jørgensen
2016-07-08 16:10 ` Felix Fietkau
2016-07-08 16:28 ` Toke Høiland-Jørgensen
2016-07-08 16:31 ` Felix Fietkau
2016-07-08 16:38 ` Toke Høiland-Jørgensen
2016-07-08 18:24 ` Sebastian Gottschall
2016-07-09 12:00 ` Toke Høiland-Jørgensen
2016-07-08 16:38 ` [PATCH v3] " Tim Shepard
2016-07-09 15:44 ` Toke Høiland-Jørgensen
2016-08-05 16:03 ` [PATCH v4] " Toke Høiland-Jørgensen
2016-08-22 15:43 ` Kalle Valo
2016-08-22 16:16 ` Toke Høiland-Jørgensen
2016-08-22 17:02 ` Kalle Valo
2016-08-22 17:13 ` Toke Høiland-Jørgensen
2016-08-23 6:59 ` Kalle Valo
2016-08-23 8:52 ` Arend van Spriel
2016-10-05 14:02 ` Toke Høiland-Jørgensen
2016-10-05 15:50 ` Kalle Valo
2016-10-05 16:55 ` Toke Høiland-Jørgensen
2016-10-05 17:54 ` Kalle Valo
2016-10-05 19:56 ` Toke Høiland-Jørgensen
2016-09-02 14:00 ` [PATCH v5] " Toke Høiland-Jørgensen
2016-09-03 10:16 ` Felix Fietkau
2016-10-07 11:43 ` [v5] " Kalle Valo
2016-11-09 2:22 ` Kalle Valo
2016-11-09 2:44 ` Tim Shepard [this message]
2016-11-09 10:42 ` Toke Høiland-Jørgensen
2016-11-09 20:07 ` Valo, Kalle
2016-11-09 11:31 ` [PATCH v6] " Toke Høiland-Jørgensen
2016-11-09 22:42 ` [v6] " Kalle Valo
2016-11-09 23:10 ` Toke Høiland-Jørgensen
2016-11-15 15:00 ` Kalle Valo
2016-06-17 9:09 ` [PATCH 2/2] ath9k: Add a per-station airtime deficit scheduler Toke Høiland-Jørgensen
2016-11-24 13:54 ` [PATCH v2] ath9k: Introduce airtime fairness scheduling between stations Toke Høiland-Jørgensen
2016-11-25 15:16 ` Valo, Kalle
2016-11-27 15:58 ` Toke Høiland-Jørgensen
2016-11-28 9:34 ` Felix Fietkau
2016-11-28 10:00 ` Toke Høiland-Jørgensen
2016-11-28 10:12 ` [PATCH v3] " Toke Høiland-Jørgensen
2016-12-15 8:43 ` [v3] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1c4IsV-0003Rk-00@www.xplot.org \
--to=shep@alum.mit.edu \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).