From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D3EC3F2CD for ; Thu, 5 Mar 2020 14:10:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 986A6206D5 for ; Thu, 5 Mar 2020 14:10:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726263AbgCEOKB convert rfc822-to-8bit (ORCPT ); Thu, 5 Mar 2020 09:10:01 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:49810 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726079AbgCEOKB (ORCPT ); Thu, 5 Mar 2020 09:10:01 -0500 Received: from marcel-macpro.fritz.box (p4FEFC5A7.dip0.t-ipconnect.de [79.239.197.167]) by mail.holtmann.org (Postfix) with ESMTPSA id 70991CECEC; Thu, 5 Mar 2020 15:19:27 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: [PATCH] mac80211_hwsim: add frame transmission support over virtio From: Marcel Holtmann In-Reply-To: Date: Thu, 5 Mar 2020 15:09:59 +0100 Cc: linux-wireless@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <20200305143212.c6e4c87d225b.I7ce60bf143e863dcdf0fb8040aab7168ba549b99@changeid> <2F7ADB4C-8C2C-4DEC-80AF-9E2D6B55CA88@holtmann.org> To: Johannes Berg X-Mailer: Apple Mail (2.3608.60.0.2.5) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi Johannes, >>> This allows communication with external entities. >>> >>> It also required fixing up the netlink policy, since NLA_UNSPEC >>> attributes are no longer accepted. >>> >>> Signed-off-by: Erel Geron >>> [port to backports, inline the ID, use 29 as the ID as requested, >>> drop != NULL checks, reduce ifdefs] >>> Signed-off-by: Johannes Berg >> >> since the module now can auto-load, don’t you want to change radios = 2 to radio = 0? > > Hmm. I didn't really want to change the behaviour there, and the auto- > loading is *highly* unlikely, you need to specifically set up a vhost- > user wmediumd (which I'm in the process of publishing). > > And even then, you still need to have the radios, they just don't > communicate directly with each other but will go into wmediumd over the > virtio when you actually have virtio. > > I'm not principally opposed to changing the default, but I'm not > convinced it'd be related to this patch in any way. can we just make it a Kconfig option that defaults to 2, but gets set to 0 when virtio support is included. Regards Marcel