From: Brite <brite.airgeddon@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, fjhhz1997@gmail.com,
oscar.alfonso.diaz@gmail.com
Subject: Re: [PATCH] wifi: mac80211: restore monitor injection when coexisting with another VIF
Date: Sat, 25 Apr 2026 05:22:01 +1200 [thread overview]
Message-ID: <F76D3DCE-DF44-47E6-B12C-B8972C29EB8D@gmail.com> (raw)
In-Reply-To: <9f7df38831598001ac6cd79ab4fb95b4b6e042fd.camel@sipsolutions.net>
On April 25, 2026 1:55:46 AM GMT+12:00, Johannes Berg <johannes@sipsolutions.net> wrote:
>
>I don't believe that all this complexity is necessary, and the code
>changes have are fairly clearly LLM-created w/o such disclosures.
>Dropping.
>
Are you saying that the patch itself is created by llm? If yes, is that even possible? I do accept that yourself or experienced devs could come up with the simplest of a solution. My initial patch was spread across 6 or 7 files with a lot of debug lines added to find out the location of vm freeze. It has taken a lot of time to narrow it down to this patch. It's totally ok if you're dropping this but if you could at least see what this code does and do a proper minimal fix yourself, that would help out a lot of people in the community.
The only time I used the help of ai and google was during the initial stage trying to understand the different variables, structures, pointers etc. After that it was just me adding a lot of debug lines to all suspected functions but the vm froze even before anything got printed in dmesg. Then i added delay between the debugs and was finally able to see where the freeze happened. This might be totally unnecessary for an experienced dev like you but since I'm new, I found this the easiest way to get to the root of the issue.
I also took help from ai and google to help me prepare the patch file in the required format to be sent.
I don't understand why you think the whole patch is generated by llm. I wonder if it was that easy to be done.
next prev parent reply other threads:[~2026-04-24 17:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 16:45 [PATCH] wifi: mac80211: fix monitor mode frame capture for real chanctx drivers 傅继晗
2026-03-09 6:53 ` Johannes Berg
2026-03-09 10:45 ` 傅继晗
2026-03-16 10:38 ` Johannes Berg
[not found] ` <CA+bbHrX+xby2_drzo0457raoz-kgQ6eTCCHU91pR5BkvzMiq_A@mail.gmail.com>
2026-03-19 11:40 ` Óscar Alfonso Díaz
2026-03-25 0:15 ` 傅继晗
2026-03-25 10:59 ` Óscar Alfonso Díaz
2026-03-26 1:37 ` [PATCH v2] wifi: mac80211: fix the issue of NULL pointer access when deleting the virtual interface 傅继晗
2026-03-26 12:16 ` Óscar Alfonso Díaz
2026-03-29 21:55 ` Óscar Alfonso Díaz
2026-04-02 0:06 ` Óscar Alfonso Díaz
2026-04-21 8:50 ` Óscar Alfonso Díaz
2026-04-24 12:08 ` [PATCH] wifi: mac80211: restore monitor injection when coexisting with another VIF Brite
2026-04-24 12:17 ` Greg KH
2026-04-24 13:55 ` Johannes Berg
2026-04-24 14:17 ` Óscar Alfonso Díaz
2026-04-24 17:22 ` Brite [this message]
2026-04-25 0:34 ` Brite
2026-04-25 1:47 ` Lachlan Hodges
2026-04-25 2:43 ` Brite
2026-04-26 9:25 ` Óscar Alfonso Díaz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F76D3DCE-DF44-47E6-B12C-B8972C29EB8D@gmail.com \
--to=brite.airgeddon@gmail.com \
--cc=fjhhz1997@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=oscar.alfonso.diaz@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox