From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.w14.tutanota.de (mail.w14.tutanota.de [185.205.69.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77B7B26B973 for ; Thu, 28 May 2026 20:02:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.205.69.214 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779998578; cv=none; b=q9H27RJiTm3z3ghl9zjSnIfhd1tV15Nu4zEZFQSS1pDgVErzVpwikQ++0mbQVztbMn7+ANjongpthW8YeY3T5f3oFpwPsfhHmKawRGvV/4Ofyt7FUqPr7/uQ8Sg+rbgFEyv9JanNes5gin0FMwbusXV6AsnDsLLaWyh7g0PWJoE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779998578; c=relaxed/simple; bh=bkOO8dK9FModpVDPstluKF/k6niX4VlQtSSGk9nVeVo=; h=Date:From:To:Cc:Message-ID:Subject:MIME-Version:Content-Type; b=RrLaM8Fxr41a0TCCTyGnk9yqyagQ98Ol/fGv0QNaOWn4SSG7ns+vwSH2srLV6PnZmcLpl/7BT7X3Lrd4LQLyiozzv1U0H+jTu4o8GzGDeL8v66Tr37EA7jcXieJQhbcQh6Y3rjeA//IH4FvjDba2NBzGiC8WBM9QqlFKN9qaJdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuta.com; spf=pass smtp.mailfrom=tuta.com; dkim=pass (2048-bit key) header.d=tuta.com header.i=@tuta.com header.b=keGKdXab; arc=none smtp.client-ip=185.205.69.214 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuta.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuta.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuta.com header.i=@tuta.com header.b="keGKdXab" Received: from tutadb.w10.tutanota.de (w10.api.tuta.com [IPv6:fd:ac::d:10]) by mail.w14.tutanota.de (Postfix) with ESMTP id C6689146CBC19 for ; Thu, 28 May 2026 22:02:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779998575; s=s1; d=tuta.com; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:Sender; bh=v4eQcVkvhKe/jFgt+8d+WXy/FAN6JPuPwLyhKhNgabU=; b=keGKdXabSzdKXU9xNFBtgIQbAtSJZVTGEyKsZC9QGmF5s3rhdiF8gwEOGhjO6pUs T7RnpMvDa83YgbI3t/zzZxLe9lwqHpx72/7VxAp7glndltJ6ADMxTgg26+rf57BmFBG QM76wv0B9RLikYTj9DCG2+ru2r70HY3lvZWulF03a4gNuljnlB+AMt3WtKmcU5xTYEd NQ1TYv4DvZAwLJKrRVAhMny7mUBYgPI5GdxKAFJAoxENwsfkX24RlWjL66UowvBEisM DtNcRXYrvMRNr1wqz1jTiaU8tQ4SqPnaCx+YM4mHUgTgK/F2+JJ/Bdt96ujRqQBU5DK 0Y3QB9ts5g== Date: Thu, 28 May 2026 22:02:55 +0200 (CEST) From: VolcomIlluminated To: Pkshih Cc: Linux Wireless Message-ID: Subject: [PATCH] rtw88: usb: retry control message on -EPROTO error Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_451627_1218432542.1779998575807" Feedback-ID: 01c4e8c013a2562e865d8b77e5b3f9fcabf876cc11e122ee288eb6e126f2764b3bcd8be2e44ea7adb908e52f58339be100204e013477eb10895d54267c0038bec6:TurnOnPrivacy!:tutamail ------=_Part_451627_1218432542.1779998575807 Content-Type: multipart/alternative; boundary="----=_Part_451628_290176836.1779998575807" ------=_Part_451628_290176836.1779998575807 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Patch Attached! -- Secured with Tuta Mail: https://tuta.com/free-email ------=_Part_451628_290176836.1779998575807 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Patch Attached!

Secured with Tuta Mail:

------=_Part_451628_290176836.1779998575807-- ------=_Part_451627_1218432542.1779998575807 Content-Type: application/octet-stream; name=0002-rtw88-usb-retry-on-EPROTO-error.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0002-rtw88-usb-retry-on-EPROTO-error.patch RnJvbTogVm9sY29tSWxsdW1pbmF0ZWQgPHZvbGNvbWlsbHVtaW5hdGVkQHR1dGEuY29tPgpEYXRl OiBXZWQsIDI4IE1heSAyMDI2IDAwOjAwOjAwICswMDAwClN1YmplY3Q6IFtQQVRDSF0gcnR3ODg6 IHVzYjogcmV0cnkgY29udHJvbCBtZXNzYWdlIG9uIC1FUFJPVE8gZXJyb3IKClVTQiBjb250cm9s IG1lc3NhZ2VzIGNhbiB0cmFuc2llbnRseSBmYWlsIHdpdGggLUVQUk9UTyAoLTcxKSBkdXJpbmcK ZGV2aWNlIHByb2JlIG9uIHNvbWUgVVNCIGhvc3QgY29udHJvbGxlcnMuIFRoaXMgbWFuaWZlc3Rz IGFzIHJlcGVhdGVkCiJ3cml0ZSByZWdpc3RlciBmYWlsZWQgd2l0aCAtNzEiIGVycm9ycyBkdXJp bmcgZHJpdmVyIGluaXRpYWxpemF0aW9uLgoKQWRkIGEgcmV0cnkgbG9vcCBvZiB1cCB0byAzIGF0 dGVtcHRzIHdpdGggMTBtcyBkZWxheSB3aGVuIC1FUFJPVE8gaXMKcmV0dXJuZWQgZnJvbSB1c2Jf Y29udHJvbF9tc2cuIFRoaXMgcmVjb3ZlcnMgdGhlIHRyYW5zaWVudCBlcnJvciBhbmQKYWxsb3dz IHRoZSBkcml2ZXIgdG8gaW5pdGlhbGl6ZSBjbGVhbmx5LgoKVGVzdGVkIG9uIFJUTDg4MjJCVSAo RWRpbWF4IEVXLTc4MjJVTEMpIHdpdGggY2xlYW4gYm9vdCBhbmQgemVybwpwcm9iZSBlcnJvcnMu CgpTaWduZWQtb2ZmLWJ5OiBWb2xjb21JbGx1bWluYXRlZCA8dm9sY29taWxsdW1pbmF0ZWRAdHV0 YS5jb20+Ci0tLQotLS0gL3RtcC9saW51eC02LjE4L2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0 ZWsvcnR3ODgvdXNiLmMJMjAyNS0xMS0zMCAxNzo0MjoxMC4wMDAwMDAwMDAgLTA1MDAKKysrIC9o b21lL3B0cHg4Nm1tMS9rZXJuZWxidWlsZC9saW51eC02LjE4L2RyaXZlcnMvbmV0L3dpcmVsZXNz L3JlYWx0ZWsvcnR3ODgvdXNiLmMJMjAyNi0wNS0yNCAyMDowNjoyNy43OTgzMzcyMzcgLTA0MDAK QEAgLTE0MCw2ICsxNDAsMTYgQEAKIAlyZXQgPSB1c2JfY29udHJvbF9tc2codWRldiwgdXNiX3Nu ZGN0cmxwaXBlKHVkZXYsIDApLAogCQkJICAgICAgUlRXX1VTQl9DTURfUkVRLCBSVFdfVVNCX0NN RF9XUklURSwKIAkJCSAgICAgIGFkZHIsIDAsIGRhdGEsIGxlbiwgNTAwKTsKKwlpZiAocmV0ID09 IC1FUFJPVE8pIHsKKwkJaW50IHJldHJ5OworCisJCWZvciAocmV0cnkgPSAwOyByZXRyeSA8IDMg JiYgcmV0ID09IC1FUFJPVE87IHJldHJ5KyspIHsKKwkJCW1zbGVlcCgxMCk7CisJCQlyZXQgPSB1 c2JfY29udHJvbF9tc2codWRldiwgdXNiX3NuZGN0cmxwaXBlKHVkZXYsIDApLAorCQkJCQkgICAg ICBSVFdfVVNCX0NNRF9SRVEsIFJUV19VU0JfQ01EX1dSSVRFLAorCQkJCQkgICAgICBhZGRyLCAw LCBkYXRhLCBsZW4sIDUwMCk7CisJCX0KKwl9CiAJaWYgKHJldCA8IDAgJiYgcmV0ICE9IC1FTk9E RVYgJiYgY291bnQrKyA8IDQpCiAJCXJ0d19lcnIocnR3ZGV2LCAid3JpdGUgcmVnaXN0ZXIgMHgl eCBmYWlsZWQgd2l0aCAlZFxuIiwKIAkJCWFkZHIsIHJldCk7Cg== ------=_Part_451627_1218432542.1779998575807-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73B5D1DDC37 for ; Fri, 29 May 2026 01:09:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780016974; cv=none; b=bzPBbHw9YuLvWgkic77gKaZ5y5lQ+V/o/XPYEc8hGnI53MhjUOLYg2Tos664k7QAh3SSp6yKGJ4eDJ2LNwaD3Kbm4FJXy6qyLXVh8fdGJ+TerHpdlIH33Adx9uQNpbF2n2r8o2uxET/tRjNfPtKF83b9BJScGFZwu5MWfzLIPhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780016974; c=relaxed/simple; bh=oXga0y0icuidudiAD/PPcAQI5Sloe2EWGoit3w9u9Wc=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=NC7T+wc/mEuFWABQ4kMcjGJoitemgRXw89w7TRKqRsOLlReIogD/DnKMN4Kbo6Tmros2d8ccBXxWJcS8mvDNh35WSTZLI4cWzaVic1iHYb7n/ohG2wGy/yXCO+tGEY8nhV9SfBEs2GDgrEotMWAa8tppHQhCcIs1kCi1929eIVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; dkim=pass (2048-bit key) header.d=realtek.com header.i=@realtek.com header.b=SkkA5PA9; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=realtek.com header.i=@realtek.com header.b="SkkA5PA9" X-SpamFilter-By: ArmorX SpamTrap 5.80 with qID 64T19NFK03769972, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realtek.com; s=dkim; t=1780016963; bh=oXga0y0icuidudiAD/PPcAQI5Sloe2EWGoit3w9u9Wc=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:Content-Transfer-Encoding:MIME-Version; b=SkkA5PA9sbY/MrP6eX0wq5WLSSvCI6g+lucDMlZK/p6M8A1G4xY8LQrKxjihD9VLu O8ArQ3Ic4fNjXdXImA2ucQQM6nL07zx84gJtcidf0LWJDX05t8wgaBu7iIDeAaZV5S 4GRC162PhmrtQ2W/9JVxlA/88Ho8DHwyQLkockPjisPRnISqXo6xd9cBH2U9DsH7Zd JTBf3F6Snuj19hJGZeOGhNo9aVvk04iHLJfWbMz7HBZUpYCwPKm0gfYcRs/OAduazD Vjj3PdGt85bNYnrjIxXYJA0I8Zft2J3EGmEu4xTAjtugURw81LYTJTBfw68FfYzeLj yd0kp8AzQ1DAg== Received: from mail.realtek.com (rtkexhmbs04.realtek.com.tw[10.21.1.54]) by rtits2.realtek.com.tw (8.15.2/3.28/5.94) with ESMTPS id 64T19NFK03769972 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 May 2026 09:09:23 +0800 Received: from RTKEXHMBS06.realtek.com.tw (10.21.1.56) by RTKEXHMBS04.realtek.com.tw (10.21.1.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 29 May 2026 09:09:22 +0800 Received: from RTKEXHMBS06.realtek.com.tw ([::1]) by RTKEXHMBS06.realtek.com.tw ([fe80::e6fd:5a3f:8946:92c4%10]) with mapi id 15.02.2562.017; Fri, 29 May 2026 09:09:22 +0800 From: Ping-Ke Shih To: VolcomIlluminated , Bitterblue Smith CC: Linux Wireless Subject: RE: [PATCH] rtw88: usb: retry control message on -EPROTO error Thread-Topic: [PATCH] rtw88: usb: retry control message on -EPROTO error Thread-Index: AQHc7tz+Z+dcBepZBku/0c4Rq/9FiLYkLHcQ Date: Fri, 29 May 2026 01:09:22 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-TW Content-Language: zh-TW Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DQpWb2xjb21JbGx1bWluYXRlZCA8dm9sY29taWxsdW1pbmF0ZWRAdHV0YS5jb20+IHdyb3RlOg0K PiAtLS0gL3RtcC9saW51eC02LjE4L2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnR3ODgv dXNiLmMJMjAyNS0xMS0zMCAxNzo0MjoxMC4wMDAwMDAwMDAgLTA1MDANCj4gKysrIC9ob21lL3B0 cHg4Nm1tMS9rZXJuZWxidWlsZC9saW51eC02LjE4L2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0 ZWsvcnR3ODgvdXNiLmMJMjAyNi0wNS0yNCAyMDowNjoyNy43OTgzMzcyMzcgLTA0MDANCg0KWW91 ciBnaXQgcmVwb3NpdG9yeSBsb29rcyB3ZWlyZC4NCg0KUGxlYXNlIGNsb25lIGh0dHBzOi8vZ2l0 aHViLmNvbS9wa3NoaWgvcnR3LmdpdCBhbmQgc3dpdGNoIHRvIHJ0dy1uZXh0IGJyYW5jaC4NCg0K QnkgdGhlIHdheSwgdGhlIHN1YmplY3QgcHJlZml4IHNob3VsZCBiZSAiW1BBVENIIHJ0dy1uZXh0 XSB3aWZpOiBydHc4ODogLi4uIi4NCg0KPiBAQCAtMTQwLDYgKzE0MCwxNiBAQA0KPiAgCXJldCA9 IHVzYl9jb250cm9sX21zZyh1ZGV2LCB1c2Jfc25kY3RybHBpcGUodWRldiwgMCksDQo+ICAJCQkg ICAgICBSVFdfVVNCX0NNRF9SRVEsIFJUV19VU0JfQ01EX1dSSVRFLA0KPiAgCQkJICAgICAgYWRk ciwgMCwgZGF0YSwgbGVuLCA1MDApOw0KPiArCWlmIChyZXQgPT0gLUVQUk9UTykgew0KPiArCQlp bnQgcmV0cnk7DQo+ICsNCj4gKwkJZm9yIChyZXRyeSA9IDA7IHJldHJ5IDwgMyAmJiByZXQgPT0g LUVQUk9UTzsgcmV0cnkrKykgew0KPiArCQkJbXNsZWVwKDEwKTsNCj4gKwkJCXJldCA9IHVzYl9j b250cm9sX21zZyh1ZGV2LCB1c2Jfc25kY3RybHBpcGUodWRldiwgMCksDQo+ICsJCQkJCSAgICAg IFJUV19VU0JfQ01EX1JFUSwgUlRXX1VTQl9DTURfV1JJVEUsDQo+ICsJCQkJCSAgICAgIGFkZHIs IDAsIGRhdGEsIGxlbiwgNTAwKTsNCg0KRG9uJ3QgZHVwbGljYXRlIHRoZSBjb2RlIG9mIGlkZW50 aWNhbCB1c2JfY29udHJvbF9tc2coLi4uKS4NCg0KSnVzdCANCg0KZm9yIChyZXRyeSA9IDA7IHJl dHJ5IDwgMzsgcmV0cnkrKykgew0KCXJldCA9IHVzYl9jb250cm9sX21zZyguLi4pOw0KICAgIGlm IChyZXQgIT0gLUVQUk9UTykNCgkJYnJlYWs7DQoNCgltc2xlZXAoMTApOyAvKiBkZWxheSBiZWZv cmUgcmV0cnlpbmcgKi8NCn0NCg0KQml0dGVyYmx1ZSwgY291bGQgeW91IGhhdmUgc29tZSBpbnB1 dHMgYWJvdXQgdGhpcyByZXRyeSwgc2luY2UgSSBkb24ndCBoYXZlDQptdWNoIGtub3dsZWRnZSBh Ym91dCBVU0I/DQoNCj4gKwkJfQ0KPiArCX0NCj4gIAlpZiAocmV0IDwgMCAmJiByZXQgIT0gLUVO T0RFViAmJiBjb3VudCsrIDwgNCkNCj4gIAkJcnR3X2VycihydHdkZXYsICJ3cml0ZSByZWdpc3Rl ciAweCV4IGZhaWxlZCB3aXRoICVkXG4iLA0KPiAgCQkJYWRkciwgcmV0KTsNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D78D933F5B3 for ; Fri, 29 May 2026 13:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780062357; cv=none; b=cligRkE1OeGgqpzEK7o2gbIS5s7HyinNtYq8LyXECCoubQAxDv35QM4A2F1W2emJr4Ly97lulEoWSbKz48sQaXxtKYFXqM1qUWqF0527lfHwLYuFbM5sTsVygXf34dO5zedriBPPnug9IiQEDmr+KJaZECIW3/T7oETLorgc5k4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780062357; c=relaxed/simple; bh=7mfVA8366x+r5q5VqaheTajG/HCr4Dam/HxL8Elkz/w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VeYYKCpCV6na/O9HHjbjML2qWF+lIOPMx8iuHKm+9FNyFEEh/YKmIrhX7SYvsAFwKtQRxJ+tLSH20sbtj5+n4n6/+WHPInMJbs/rVfe7c4Qr8Eow8OOpyzNbT8VN38VJRmXDwOwYhrlQtOfNHgHIedD/u2RlXZ5Zc8ecVxFgL3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bOSFiqEZ; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bOSFiqEZ" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-48e8132c6d0so89104165e9.1 for ; Fri, 29 May 2026 06:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780062354; x=1780667154; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WI4JNNwTYXy5l2RpWx9tW3vfysaC7FsaBfx7HKpPLfs=; b=bOSFiqEZoiCxxGrUl+eSsJEmv/4LMIQU4DwTlmhxB9bc1xmh+PWmMxOKW0E8koVpai EgsU50vhWCFz0sMkermf+aMiezRLc6YI4UwUTRnc07Rt8X75MjcqzJydTTYFstwzvwmc di4PZbi6K1ud+zyyW2TsebOm7H52OHs10mLKY/bdpxGIdkrdlgUQEjHJRwtyos5ZM7vq Zg9stMlylKAEfLKMrulCpHSbuDQrc8l/1g/yrQVEaDTx2cpB25mkrrgd6XSFkR6OVBPQ JnTYZNmNovFzZCumXZ/22Edyg3t7KLMEsW9GKXhhWafA6r12GsI73VywPUAHTkaW9S5W pf1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780062354; x=1780667154; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WI4JNNwTYXy5l2RpWx9tW3vfysaC7FsaBfx7HKpPLfs=; b=rAhSjva2JCn/ehrtJ1XLaLPQTHUVTBV9opUk3quoW0YxYpsdjFxLg9S0T03RiZHeTO z5OO1qf6+NlruZAjE52fYuJMjqnNAN91TLc6K0YnO2uZblzQGM/qI0a1wnle+zQG9ZXL lj83nyvRqzQQtAHalUx2aYRVtAN+M7yxaP4Z6KULwCYfLAFOJwbn86M9ABJv38kUcb7b V8DEDre+jDcsqrBaMlUY+Iw6b0QXXRX9cCqCTOphGQxgcVQ7YYuvn+bJ6/+C74IJ1VqX 43XXLKGvTpATqEG/0HIuuy1MN0mXuzra+rwE9ERfgCMm62N4y3MM9MB6xhlMpGQafXSQ B+WQ== X-Gm-Message-State: AOJu0Yx0MwdivnjzG7KnkPzBbA7/RNvFLg+q4pBZXB1RwTvNg+aWLTIQ KhK6idYDqLJzE1x6El/TvjJs7OQ7NGPOmNhDfMaV6fr8Hgx2sxzu8BRv X-Gm-Gg: Acq92OE548TKEbn22Y7GMhQRruv0vMDRTHFR/ggz/UoZ4KbEOw61++dW2cnYW5wAdKq pbb2LcF4mK1LN8/xTijmsZWxQ1CV6CnLclcL/0i2UFiVCGO0VeHkwwdYpdFA6eLLok462K1PTDQ tNrduELfHoogkMDf1UDPL0c2R5pmqzE6MGi+vO8CoAv2kzg5S6rLx+dglrqwHHW4eg9WT8/pjLr +xxYTlcv6ilYbT8ySq3uBEawR9rrjCBzlYf2BS6Q5RvkW6Q99dwHeOyhnAhGfEUStePoXrOqoBL 3ivNqKt6XUq7QME0qmwifxd16tBH+bM4l8B7BpvPNrmhObtFmEdv71a/uPhyx8hVuTFMeSMaPju 4qIzjQXl9RMzEa+tZElPoy9oQKlu9XZCij1nbyhhe2Oe/g7tE7QM1Jb5pdOFdc5feRFuyvn7Xa8 42fBxkGrpwRuRy8Hha/MceLZfylfd7udUA7wK8D9BssA== X-Received: by 2002:a05:600c:3e87:b0:490:8a00:d250 with SMTP id 5b1f17b1804b1-4909d6e6922mr43960395e9.27.1780062354166; Fri, 29 May 2026 06:45:54 -0700 (PDT) Received: from [192.168.1.50] ([79.119.240.27]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909d6f3612sm41825215e9.12.2026.05.29.06.45.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2026 06:45:53 -0700 (PDT) Message-ID: Date: Fri, 29 May 2026 16:45:52 +0300 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rtw88: usb: retry control message on -EPROTO error To: Ping-Ke Shih , VolcomIlluminated Cc: Linux Wireless References: Content-Language: en-US From: Bitterblue Smith In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 29/05/2026 04:09, Ping-Ke Shih wrote: > > VolcomIlluminated wrote: >> --- /tmp/linux-6.18/drivers/net/wireless/realtek/rtw88/usb.c 2025-11-30 17:42:10.000000000 -0500 >> +++ /home/ptpx86mm1/kernelbuild/linux-6.18/drivers/net/wireless/realtek/rtw88/usb.c 2026-05-24 20:06:27.798337237 -0400 > > Your git repository looks weird. > > Please clone https://github.com/pkshih/rtw.git and switch to rtw-next branch. > > By the way, the subject prefix should be "[PATCH rtw-next] wifi: rtw88: ...". > >> @@ -140,6 +140,16 @@ >> ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), >> RTW_USB_CMD_REQ, RTW_USB_CMD_WRITE, >> addr, 0, data, len, 500); >> + if (ret == -EPROTO) { >> + int retry; >> + >> + for (retry = 0; retry < 3 && ret == -EPROTO; retry++) { >> + msleep(10); >> + ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), >> + RTW_USB_CMD_REQ, RTW_USB_CMD_WRITE, >> + addr, 0, data, len, 500); > > Don't duplicate the code of identical usb_control_msg(...). > > Just > > for (retry = 0; retry < 3; retry++) { > ret = usb_control_msg(...); > if (ret != -EPROTO) > break; > > msleep(10); /* delay before retrying */ > } > > Bitterblue, could you have some inputs about this retry, since I don't have > much knowledge about USB? > I think it's a good idea to retry in case of errors. The vendor drivers try the control messages up to 10 times, both reads and writes, and not just in case of -EPROTO. Except when writing the firmware for the 8051 chips (address range 0x1000..0x1fff). Those writes are not retried, instead the entire firmware download process is retried if it fails. Also, they don't sleep between attempts. But I would like to know more about the problem fixed by this patch. What register writes fail with -EPROTO? How often does it happen? How many times was this patch tested? I wonder if the problem is simply the write to register 0xc4 (REG_PAD_CTRL2) which triggers the switch to USB 3? Like with the wifi 6 and 7 chips, that call to usb_control_msg() always returns -EPROTO. I assume it's because it makes the USB device disappear. >> + } >> + } >> if (ret < 0 && ret != -ENODEV && count++ < 4) >> rtw_err(rtwdev, "write register 0x%x failed with %d\n", >> addr, ret); > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5DC85B1EB for ; Mon, 1 Jun 2026 01:27:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780277280; cv=none; b=dDtEVnnDKgtIWurqiUf2I2J8x5KvJhPSnlhzhZNu9myPWFDMI8o/066H3L4BfR1bfmUe+OlztIJqWiDQc8inWaUY65gOHb7yAASqfvJvZ5jsPEybxOIPi/3crQDonF6Zh47C3m9+gp6Vmyn8hc4if2HZRxyArXDwA+VpKKDHcRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780277280; c=relaxed/simple; bh=FWLmikSFOPFxI6Oa+72jmWWy5sc7rpCod5kP14uHuyI=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=aNFRP8kws5aOIjuC29pfvs849M6s1vxWQCUm/UCLeGuk8yjdyN/l5d3j5bfueH7Y0xXtaIKw7xeY/kRkzELpH1DsjELHis2FmKFUlX7yf8tdNIQRtNaWwCKTG3W9bzIwdV1lVJrGyd9T76gN/8x0+OeZGmvLBDQC78QaN5j6jgs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; dkim=pass (2048-bit key) header.d=realtek.com header.i=@realtek.com header.b=E4nArSQF; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=realtek.com header.i=@realtek.com header.b="E4nArSQF" X-SpamFilter-By: ArmorX SpamTrap 5.80 with qID 6511Rk6921706365, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realtek.com; s=dkim; t=1780277266; bh=FWLmikSFOPFxI6Oa+72jmWWy5sc7rpCod5kP14uHuyI=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:Content-Transfer-Encoding:MIME-Version; b=E4nArSQFP95RAqYyNqKOFLXDx/qFppKLUry/ezM3bcRbARSy7qrUukKqtFXOqECUE Emf5kg33xEYeeDjkRUUHCS6b8UVTDtZxiFyibh6OChEUGx1xOMw/kkYsmigen9UE38 7iwdo5JimU3AKkxBkFlTA8yX+hgRsbW4GThkPkVMGHRvrBnl/A0N5+2FoA17buurB9 y5geeN38hAxe1HYOpfNBNX2YhLsVRiXglBBMCCR5ORzdozVeXqoFy2cL9vItEtDg7K Tq/N37+60gSxKS23D9LU53hxxaeqoDw9bqbfbH0qcmJmx/OozZPw/BZp6i51a466cn WKhncWaHmSnbw== Received: from mail.realtek.com (rtkexhmbs03.realtek.com.tw[10.21.1.53]) by rtits2.realtek.com.tw (8.15.2/3.28/5.94) with ESMTPS id 6511Rk6921706365 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 1 Jun 2026 09:27:46 +0800 Received: from RTKEXHMBS05.realtek.com.tw (10.21.1.55) by RTKEXHMBS03.realtek.com.tw (10.21.1.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 1 Jun 2026 09:27:47 +0800 Received: from RTKEXHMBS06.realtek.com.tw (10.21.1.56) by RTKEXHMBS05.realtek.com.tw (10.21.1.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 1 Jun 2026 09:27:47 +0800 Received: from RTKEXHMBS06.realtek.com.tw ([::1]) by RTKEXHMBS06.realtek.com.tw ([fe80::e6fd:5a3f:8946:92c4%10]) with mapi id 15.02.2562.017; Mon, 1 Jun 2026 09:27:47 +0800 From: Ping-Ke Shih To: Bitterblue Smith , VolcomIlluminated CC: Linux Wireless Subject: RE: [PATCH] rtw88: usb: retry control message on -EPROTO error Thread-Topic: [PATCH] rtw88: usb: retry control message on -EPROTO error Thread-Index: AQHc7tz+Z+dcBepZBku/0c4Rq/9FiLYkLHcQgABSoACABG2cQA== Date: Mon, 1 Jun 2026 01:27:46 +0000 Message-ID: References:

In-Reply-To: Accept-Language: en-US, zh-TW Content-Language: zh-TW Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Qml0dGVyYmx1ZSBTbWl0aCA8cnRsODgyMWNlcmZlMkBnbWFpbC5jb20+IHdyb3RlOg0KPiBPbiAy OS8wNS8yMDI2IDA0OjA5LCBQaW5nLUtlIFNoaWggd3JvdGU6DQo+ID4NCj4gPiBWb2xjb21JbGx1 bWluYXRlZCA8dm9sY29taWxsdW1pbmF0ZWRAdHV0YS5jb20+IHdyb3RlOg0KPiA+PiAtLS0gL3Rt cC9saW51eC02LjE4L2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnR3ODgvdXNiLmMgMjAy NS0xMS0zMCAxNzo0MjoxMC4wMDAwMDAwMDAgLTA1MDANCj4gPj4gKysrIC9ob21lL3B0cHg4Nm1t MS9rZXJuZWxidWlsZC9saW51eC02LjE4L2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnR3 ODgvdXNiLmMgIDIwMjYtMDUtMjQNCj4gMjA6MDY6MjcuNzk4MzM3MjM3IC0wNDAwDQo+ID4NCj4g PiBZb3VyIGdpdCByZXBvc2l0b3J5IGxvb2tzIHdlaXJkLg0KPiA+DQo+ID4gUGxlYXNlIGNsb25l IGh0dHBzOi8vZ2l0aHViLmNvbS9wa3NoaWgvcnR3LmdpdCBhbmQgc3dpdGNoIHRvIHJ0dy1uZXh0 IGJyYW5jaC4NCj4gPg0KPiA+IEJ5IHRoZSB3YXksIHRoZSBzdWJqZWN0IHByZWZpeCBzaG91bGQg YmUgIltQQVRDSCBydHctbmV4dF0gd2lmaTogcnR3ODg6IC4uLiIuDQo+ID4NCj4gPj4gQEAgLTE0 MCw2ICsxNDAsMTYgQEANCj4gPj4gICAgICByZXQgPSB1c2JfY29udHJvbF9tc2codWRldiwgdXNi X3NuZGN0cmxwaXBlKHVkZXYsIDApLA0KPiA+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICBS VFdfVVNCX0NNRF9SRVEsIFJUV19VU0JfQ01EX1dSSVRFLA0KPiA+PiAgICAgICAgICAgICAgICAg ICAgICAgICAgICBhZGRyLCAwLCBkYXRhLCBsZW4sIDUwMCk7DQo+ID4+ICsgICAgaWYgKHJldCA9 PSAtRVBST1RPKSB7DQo+ID4+ICsgICAgICAgICAgICBpbnQgcmV0cnk7DQo+ID4+ICsNCj4gPj4g KyAgICAgICAgICAgIGZvciAocmV0cnkgPSAwOyByZXRyeSA8IDMgJiYgcmV0ID09IC1FUFJPVE87 IHJldHJ5KyspIHsNCj4gPj4gKyAgICAgICAgICAgICAgICAgICAgbXNsZWVwKDEwKTsNCj4gPj4g KyAgICAgICAgICAgICAgICAgICAgcmV0ID0gdXNiX2NvbnRyb2xfbXNnKHVkZXYsIHVzYl9zbmRj dHJscGlwZSh1ZGV2LCAwKSwNCj4gPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFJUV19VU0JfQ01EX1JFUSwgUlRXX1VTQl9DTURfV1JJVEUsDQo+ID4+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhZGRyLCAwLCBkYXRhLCBsZW4s IDUwMCk7DQo+ID4NCj4gPiBEb24ndCBkdXBsaWNhdGUgdGhlIGNvZGUgb2YgaWRlbnRpY2FsIHVz Yl9jb250cm9sX21zZyguLi4pLg0KPiA+DQo+ID4gSnVzdA0KPiA+DQo+ID4gZm9yIChyZXRyeSA9 IDA7IHJldHJ5IDwgMzsgcmV0cnkrKykgew0KPiA+ICAgICAgIHJldCA9IHVzYl9jb250cm9sX21z ZyguLi4pOw0KPiA+ICAgICBpZiAocmV0ICE9IC1FUFJPVE8pDQo+ID4gICAgICAgICAgICAgICBi cmVhazsNCj4gPg0KPiA+ICAgICAgIG1zbGVlcCgxMCk7IC8qIGRlbGF5IGJlZm9yZSByZXRyeWlu ZyAqLw0KPiA+IH0NCj4gPg0KPiA+IEJpdHRlcmJsdWUsIGNvdWxkIHlvdSBoYXZlIHNvbWUgaW5w dXRzIGFib3V0IHRoaXMgcmV0cnksIHNpbmNlIEkgZG9uJ3QgaGF2ZQ0KPiA+IG11Y2gga25vd2xl ZGdlIGFib3V0IFVTQj8NCj4gPg0KPiANCj4gSSB0aGluayBpdCdzIGEgZ29vZCBpZGVhIHRvIHJl dHJ5IGluIGNhc2Ugb2YgZXJyb3JzLiBUaGUgdmVuZG9yIGRyaXZlcnMNCj4gdHJ5IHRoZSBjb250 cm9sIG1lc3NhZ2VzIHVwIHRvIDEwIHRpbWVzLCBib3RoIHJlYWRzIGFuZCB3cml0ZXMsIGFuZCBu b3QNCj4ganVzdCBpbiBjYXNlIG9mIC1FUFJPVE8uDQo+IA0KPiBFeGNlcHQgd2hlbiB3cml0aW5n IHRoZSBmaXJtd2FyZSBmb3IgdGhlIDgwNTEgY2hpcHMgKGFkZHJlc3MgcmFuZ2UNCj4gMHgxMDAw Li4weDFmZmYpLiBUaG9zZSB3cml0ZXMgYXJlIG5vdCByZXRyaWVkLCBpbnN0ZWFkIHRoZSBlbnRp cmUNCj4gZmlybXdhcmUgZG93bmxvYWQgcHJvY2VzcyBpcyByZXRyaWVkIGlmIGl0IGZhaWxzLg0K PiANCj4gQWxzbywgdGhleSBkb24ndCBzbGVlcCBiZXR3ZWVuIGF0dGVtcHRzLg0KDQpUaGFua3Mg Zm9yIHRoZSBpbmZvLiANCg0KVm9sY29tSWxsdW1pbmF0ZWQsIHBsZWFzZSBmb2xsb3cgQml0dGVy Ymx1ZSdzIHN1Z2dlc3Rpb25zIGFzIHZlbmRvciBkcml2ZXIgZG9lcy4NCg0KPiANCj4gQnV0IEkg d291bGQgbGlrZSB0byBrbm93IG1vcmUgYWJvdXQgdGhlIHByb2JsZW0gZml4ZWQgYnkgdGhpcyBw YXRjaC4NCj4gV2hhdCByZWdpc3RlciB3cml0ZXMgZmFpbCB3aXRoIC1FUFJPVE8/IEhvdyBvZnRl biBkb2VzIGl0IGhhcHBlbj8NCj4gSG93IG1hbnkgdGltZXMgd2FzIHRoaXMgcGF0Y2ggdGVzdGVk Pw0KPiANCj4gSSB3b25kZXIgaWYgdGhlIHByb2JsZW0gaXMgc2ltcGx5IHRoZSB3cml0ZSB0byBy ZWdpc3RlciAweGM0DQo+IChSRUdfUEFEX0NUUkwyKSB3aGljaCB0cmlnZ2VycyB0aGUgc3dpdGNo IHRvIFVTQiAzPyBMaWtlIHdpdGggdGhlDQo+IHdpZmkgNiBhbmQgNyBjaGlwcywgdGhhdCBjYWxs IHRvIHVzYl9jb250cm9sX21zZygpIGFsd2F5cyByZXR1cm5zDQo+IC1FUFJPVE8uIEkgYXNzdW1l IGl0J3MgYmVjYXVzZSBpdCBtYWtlcyB0aGUgVVNCIGRldmljZSBkaXNhcHBlYXIuDQoNClRoZSBj b21taXQgbWVzc2FnZSBvZiBvcmlnaW5hbCBwYXRjaCBkb2Vzbid0IHBvaW50IG91dCAid3JpdGUg cmVnaXN0ZXIgMHgleCIuDQpWb2xjb21JbGx1bWluYXRlZCwgcGxlYXNlIHNoYXJlIHRoaXMgaW5m byB0b28uIA0KDQo+IA0KPiA+PiArICAgICAgICAgICAgfQ0KPiA+PiArICAgIH0NCj4gPj4gICAg ICBpZiAocmV0IDwgMCAmJiByZXQgIT0gLUVOT0RFViAmJiBjb3VudCsrIDwgNCkNCj4gPj4gICAg ICAgICAgICAgIHJ0d19lcnIocnR3ZGV2LCAid3JpdGUgcmVnaXN0ZXIgMHgleCBmYWlsZWQgd2l0 aCAlZFxuIiwNCj4gPj4gICAgICAgICAgICAgICAgICAgICAgYWRkciwgcmV0KTsNCj4gPg0KDQo=